Re: [PATCH v7 15/17] configs: Add am69_sk_* defconfig fragments

[Roger Quadros <rogerq@kernel.org>]

On 19/12/2023 21:15, Apurva Nandan wrote:
> From: Dasnavis Sabiya <sabiya.d@ti.com>
> 
> Add config fragments for am69_sk A72 and R5 configuration.
> 
> This applies on to:
> j784s4_evm_a72_defconfig -> am69_sk_a72.config
> j784s4_evm_r5_defconfig -> am69_sk_r5.config
> 
> The usage model (with the fragment) would be:
> make j784s4_evm_a72_defconfig am69_sk_a72.config
> make
> 
> OR
> 
> make j784s4_evm_r5_defconfig am69_sk_r5.config
> make
> 
> Signed-off-by: Dasnavis Sabiya <sabiya.d@ti.com>
> Signed-off-by: Apurva Nandan <a-nandan@ti.com>
> ---
>  configs/am69_sk_a72.config | 3 +++
>  configs/am69_sk_r5.config  | 3 +++

Shouldn't the config fragments lie in the board/<board>/configs directory?
Else we will just keep polluting the configs directory.

e.g.

u-boot$ find . -name "*.config"
./tools/env/fw_env.config
./board/asus/transformer-t30/configs/tf300tl.config
./board/asus/transformer-t30/configs/tf300tg.config
./board/asus/transformer-t30/configs/tf201.config
./board/asus/transformer-t30/configs/tf300t.config
./board/asus/transformer-t30/configs/p1801-t.config
./board/asus/transformer-t30/configs/tf600t.config
./board/asus/transformer-t30/configs/tf700t.config
./board/asus/grouper/configs/grouper_PM269.config
./board/asus/grouper/configs/grouper_E1565.config
./board/asus/grouper/configs/tilapia.config
./board/lg/x3-t30/configs/p880.config
./board/lg/x3-t30/configs/p895.config


>  2 files changed, 6 insertions(+)
>  create mode 100644 configs/am69_sk_a72.config
>  create mode 100644 configs/am69_sk_r5.config
> 
> diff --git a/configs/am69_sk_a72.config b/configs/am69_sk_a72.config
> new file mode 100644
> index 0000000000..5668e23b37
> --- /dev/null
> +++ b/configs/am69_sk_a72.config
> @@ -0,0 +1,3 @@
> +# Defconfig fragment to apply on top of j784s4_evm_a72_defconfig
> +
> +CONFIG_DEFAULT_DEVICE_TREE="k3-am69-sk"
> diff --git a/configs/am69_sk_r5.config b/configs/am69_sk_r5.config
> new file mode 100644
> index 0000000000..9194694393
> --- /dev/null
> +++ b/configs/am69_sk_r5.config
> @@ -0,0 +1,3 @@
> +# Defconfig fragment to apply on top of j784s4_evm_r5_defconfig
> +
> +CONFIG_DEFAULT_DEVICE_TREE="k3-am69-r5-sk"

-- 
cheers,
-roger