RE: [PATCH] tools: add fdt_add_pubkey

[Roman Kopytin <Roman.Kopytin@kaspersky.com>]

Thanks a lot.
Can I create 1 patch with tool + test?

-----Original Message-----
From: Rasmus Villemoes <rasmus.villemoes@prevas.dk> 
Sent: Thursday, August 5, 2021 10:56 AM
To: Roman Kopytin <Roman.Kopytin@kaspersky.com>; U-Boot-Denx <u-boot@lists.denx.de>
Subject: Re: [PATCH] tools: add fdt_add_pubkey

Caution: This is an external email. Be cautious while opening links or attachments.



On 03/08/2021 13.00, Roman Kopytin wrote:

Hi Roman

Thanks for picking this up. A few notes on the process:

- Don't attach the patch, it must be inline in the email. But do not copy-paste it in to your mail client, that will most likely make it whitespace-damaged. git send-email is your friend.

- Sending it to u-boot@lists.denx.de is correct, but you should also cc "interested parties", e.g. at least me (for obvious reasons) and anybody who participated in the earlier thread. If you had used git send-email, your "Cc: " line in the patch would actually automatically have included me on cc. Other people are just as easy to add (with the --cc option to "git send-email"). Very few people, if any, read every message on the U-Boot mailing list.

- It would be good if you could also add a test and ensure that it works. I think my original submission had three commits, of which the first is now moot, but that last patch was a test case. It may need some adjustments to apply nowadays, but it should give you a starting point.

Rasmus