From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ulf Samuelsson Date: Mon, 16 Oct 2006 20:09:39 +0200 Subject: [U-Boot-Users] Adding new commands References: <453368A1.5050407@dave-tech.it> <45337173.2070801@schweigstill.de> Message-ID: <011e01c6f14e$44fe56e0$01c4af0a@atmel.com> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Andreas Schweigstill wrote: > Dear llandre! > > llandre schrieb: >> #define CFG_CMD_NEW1 0x8000000000000000ULL >> #define CFG_CMD_NEW2 ??? >> >> IIUC we have 64 bits available for the commands and 63 commands are >> already defined. So how to define more than 64 commands? > > This is indeed a big problem which will occur to nearly every > developer who implements new commands. CFG_CMD_* and CONFIG_COMMANDS > are only used for preprocessor evaluation; they don't seem to be used > in object code. But they rely on the ULL (unsigned long long int) > type; I don't think that there is something like a 128bit type which > can be used directly for logical AND operations. > > For new command there could be used another macro like > CONFIG_COMMANDS2 and CFG_CMD2_* for the configuration values. > The number of options is growing all the time. Maybe it would be a good idea to adopt the Kconfig system. Wolfgang does not like to have a lot of files like they do in the kernel but you do not have to split it up like they do it in the kernel. You could have a single Config.in file. Best Regards, Ulf Samuelsson ulf at atmel.com GSM: +46 (706) 22 44 57 Tel: +46 (8) 441 54 22 Fax: +46 (8) 441 54 29 Mail: Box 2033 174 02 Sundbyberg Visit: Kavalleriv?gen 24 174 58 Sundbyberg' Sweden