From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ulf Samuelsson <ulf@atmel.com>
Date: Wed, 9 Jan 2008 19:26:08 +0100
Subject: [U-Boot-Users] [PATCH V2] Fix Ethernet init() return codes.
References: <4783F7D9.9050100@gmail.com> <20080109172628.07e6f921@siona>
Message-ID: <014701c852ed$4b0c4040$6103170a@atmel.com>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

> On Tue, 08 Jan 2008 17:23:21 -0500
> Ben Warren <biggerbadderben@gmail.com> wrote:
> 
>> diff --git a/drivers/net/macb.c b/drivers/net/macb.c
>> index 95cdc49..6657d22 100644
>> --- a/drivers/net/macb.c
>> +++ b/drivers/net/macb.c
>> @@ -423,12 +423,12 @@ static int macb_init(struct eth_device *netdev,
>> bd_t *bd) #endif
>>  
>>  if (!macb_phy_init(macb))
>> - return 0;
>> + return -1;
>>  
>>  /* Enable TX and RX */
>>  macb_writel(macb, NCR, MACB_BIT(TE) | MACB_BIT(RE));
>>  
>> - return 1;
>> + return 0;
>>  }
>>  


Why not use symbolic return values?
"return SUCCESS;" seems much more appropriate than 
"return 0;"  or "return -1;"

if(myfunction() == SUCCESS) {

}

is much more clear than 

if(myfunction()) {

}


Best Regards
Ulf Samuelsson