From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 93852C433F5 for ; Tue, 17 May 2022 22:00:30 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 9F8818426D; Wed, 18 May 2022 00:00:26 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="Egg7P7aF"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id D041283922; Wed, 18 May 2022 00:00:21 +0200 (CEST) Received: from mail-ej1-x62b.google.com (mail-ej1-x62b.google.com [IPv6:2a00:1450:4864:20::62b]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id E6AF38331B for ; Wed, 18 May 2022 00:00:13 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=daniel.schwierzeck@gmail.com Received: by mail-ej1-x62b.google.com with SMTP id j6so217992ejc.13 for ; Tue, 17 May 2022 15:00:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=message-id:date:mime-version:user-agent:subject:content-language:to :cc:references:from:in-reply-to:content-transfer-encoding; bh=qNgvn6ET4oAO1yI5Sd2+3Ly7/bVlQpVhpoQ0b7petTM=; b=Egg7P7aFSp7Jnrl7gQKOFuRv4DfYcdTyxRiQhXjj4SpBAo5CzwMUpWkQ5GXmUheiwW ijkjUrz/UUi9mZRsnp2R62cZIls4Je6jLEyLq7DklSblGVuFZESEMaJ412JKkhJZai9n wkyBS2T+jCMD4AQ6KRh5oPbPHHhuXiQJl8zgj7yjoy8OZrOxptvd5tLBp+vANmKqPC9L N8Sz7vCbO+awjQMHcyqX1mle7ZZ5Dlu3pJPgkziJWii77IUOmWApFWC1Epg1QFieNW7W VuBhzyPeWvmHLO08mdoxw6T23AO+4o2KzZHEk247NVxepEvJr70QrdtebNLjGw6QzP9C CRGQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=qNgvn6ET4oAO1yI5Sd2+3Ly7/bVlQpVhpoQ0b7petTM=; b=JAk+HySIhpOqLtyI79I8zRC4YXd8jNsxQyRa/wz6dhKdsA3NcXqCjJQzqWhBDxnpRQ yvrB4FezBsG3QZXNBeC1JTUuyKIRvmCuc60ENzbC/Qj+evhRSvHMqLq0aVah6i58YEc4 ywfZjlJWmAgQZwex9BrnK68eli4XsLIs3UQS/EM/ePjCZZpQPwQh41A7I5ClUdWx51v3 pNeg5TyRkFkRr8XBCjIkBEkgbdUvGZ2ZYKOwXR+T+cfjK8sPZ5viM+YyieQBe9BM3Wn4 fPAUdKGWuW8XeAooIVmdwvigF+a9HmT8ywrZ+Ac+JWhW0ksz/atmtNQFiev7CJ9mixq3 tITw== X-Gm-Message-State: AOAM532UG6M5RV81uwSiGoto/g8TFNyBBsWmoXkCVm8WWeO8cDCdAadI Hi57ZPAOB+0so9U5+lwhrLK9MbCp/h4= X-Google-Smtp-Source: ABdhPJx7ZFznVm+j84n5XPYq8sUWUxvgnMLlJt1utuq744/oHi3JssTujzM3MbUsmTRwOXRrTY+b+A== X-Received: by 2002:a17:907:7dab:b0:6f4:6650:395d with SMTP id oz43-20020a1709077dab00b006f46650395dmr21348046ejc.82.1652824813550; Tue, 17 May 2022 15:00:13 -0700 (PDT) Received: from [192.168.10.30] (i5E86074D.versanet.de. [94.134.7.77]) by smtp.gmail.com with ESMTPSA id j26-20020a170906475a00b006f3ef214dd9sm181072ejs.63.2022.05.17.15.00.12 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 17 May 2022 15:00:13 -0700 (PDT) Message-ID: <0179e4da-e5c0-d9e8-e692-040ab0512c40@gmail.com> Date: Wed, 18 May 2022 00:00:12 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.8.1 Subject: Re: [PATCH v5 22/25] spl: spl_legacy: fix the use of SPL_COPY_PAYLOAD_ONLY Content-Language: en-US To: Weijie Gao , u-boot@lists.denx.de Cc: GSS_MTK_Uboot_upstream , =?UTF-8?Q?Pali_Roh=c3=a1r?= , =?UTF-8?Q?Marek_Beh=c3=ban?= , Stefan Roese References: <093468ebfdc4dbb38758ebceee3fc102bdef71c4.1652667687.git.weijie.gao@mediatek.com> From: Daniel Schwierzeck In-Reply-To: <093468ebfdc4dbb38758ebceee3fc102bdef71c4.1652667687.git.weijie.gao@mediatek.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.5 at phobos.denx.de X-Virus-Status: Clean On 16.05.22 04:44, Weijie Gao wrote: > If the payload is compressed, SPL_COPY_PAYLOAD_ONLY should always be set > since the payload will not be directly read to its load address. The > payload will first be read to a temporary buffer, and then be decompressed > to its load address, without image header. > > If the payload is not compressed, and SPL_COPY_PAYLOAD_ONLY is set, image > header should be skipped on loading. Otherwise image header should also be > read to its load address. > > Signed-off-by: Weijie Gao > --- > v5 changes: none > v4 changes: new > --- > common/spl/spl_legacy.c | 21 +++++++++++++++++++-- > 1 file changed, 19 insertions(+), 2 deletions(-) > Reviewed-by: Daniel Schwierzeck -- - Daniel