[PATCH v2] ARM: dts: at91: sama5d3: add u-boot properties to sama5d3 pit timer

[PATCH v2] ARM: dts: at91: sama5d3: add u-boot properties to sama5d3 pit timer

[Manuel Reis]

in the early SPL boot stage whenever there is a call to udelay,
dm_timer_init fails to find the pit timer whenever it traverses
the device tree, if this property is not present

Signed-off-by: Manuel Reis <mluis.reis@gmail.com>
CC: Eugen Hristev <eugen.hristev@microchip.com>
---
 arch/arm/dts/sama5d3.dtsi | 1 +
 1 file changed, 1 insertion(+)

diff --git a/arch/arm/dts/sama5d3.dtsi b/arch/arm/dts/sama5d3.dtsi
index 6ed218eaad..42c30e9f30 100644
--- a/arch/arm/dts/sama5d3.dtsi
+++ b/arch/arm/dts/sama5d3.dtsi
@@ -1320,6 +1320,7 @@
 				reg = <0xfffffe30 0xf>;
 				interrupts = <3 IRQ_TYPE_LEVEL_HIGH 5>;
 				clocks = <&mck>;
+				u-boot,dm-pre-reloc;
 			};
 
 			watchdog at fffffe40 {
-- 
2.27.0

[PATCH v2] ARM: dts: at91: sama5d3: add u-boot properties to sama5d3 pit timer

[Derald Woods]

On Tue, Apr 6, 2021 at 4:40 AM Manuel Reis <mluis.reis@gmail.com> wrote:

> in the early SPL boot stage whenever there is a call to udelay,
> dm_timer_init fails to find the pit timer whenever it traverses
> the device tree, if this property is not present
>
> Signed-off-by: Manuel Reis <mluis.reis@gmail.com>
> CC: Eugen Hristev <eugen.hristev@microchip.com>
> ---
>  arch/arm/dts/sama5d3.dtsi | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/arch/arm/dts/sama5d3.dtsi b/arch/arm/dts/sama5d3.dtsi
> index 6ed218eaad..42c30e9f30 100644
> --- a/arch/arm/dts/sama5d3.dtsi
> +++ b/arch/arm/dts/sama5d3.dtsi
> @@ -1320,6 +1320,7 @@
>                                 reg = <0xfffffe30 0xf>;
>                                 interrupts = <3 IRQ_TYPE_LEVEL_HIGH 5>;
>                                 clocks = <&mck>;
> +                               u-boot,dm-pre-reloc;
>                         };
>
>                         watchdog at fffffe40 {
> --
> 2.27.0
>
>
This patch, on top of v2021.04, allows my SAMA5D3 Xplained board to boot
normally again.

Tested-by: Derald D. Woods <woods.technical@gmail.com>

[PATCH v2] ARM: dts: at91: sama5d3: add u-boot properties to sama5d3 pit timer

[Eugen.Hristev at microchip.com]

On 4/7/21 1:16 AM, Derald Woods wrote:
> On Tue, Apr 6, 2021 at 4:40 AM Manuel Reis <mluis.reis@gmail.com 
> <mailto:mluis.reis@gmail.com>> wrote:
> 
>     in the early SPL boot stage whenever there is a call to udelay,
>     dm_timer_init fails to find the pit timer whenever it traverses
>     the device tree, if this property is not present
> 
>     Signed-off-by: Manuel Reis <mluis.reis@gmail.com
>     <mailto:mluis.reis@gmail.com>>
>     CC: Eugen Hristev <eugen.hristev@microchip.com
>     <mailto:eugen.hristev@microchip.com>>
>     ---
>      ?arch/arm/dts/sama5d3.dtsi | 1 +
>      ?1 file changed, 1 insertion(+)
> 
>     diff --git a/arch/arm/dts/sama5d3.dtsi b/arch/arm/dts/sama5d3.dtsi
>     index 6ed218eaad..42c30e9f30 100644
>     --- a/arch/arm/dts/sama5d3.dtsi
>     +++ b/arch/arm/dts/sama5d3.dtsi
>     @@ -1320,6 +1320,7 @@
>      ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? reg = <0xfffffe30 0xf>;
>      ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? interrupts = <3 IRQ_TYPE_LEVEL_HIGH 5>;
>      ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? clocks = <&mck>;
>     +? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ?u-boot,dm-pre-reloc;
>      ? ? ? ? ? ? ? ? ? ? ? ? };
> 
>      ? ? ? ? ? ? ? ? ? ? ? ? watchdog at fffffe40 {
>     -- 
>     2.27.0
> 
> 
> This patch, on top of v2021.04, allows my SAMA5D3 Xplained board to boot 
> normally again.
> 
> Tested-by: Derald D. Woods <woods.technical@gmail.com 
> <mailto:woods.technical@gmail.com>>
> 

Hi Derald,

Could I ask, you are using the SPL to boot your board ?
Did you have to remove any udelay from the ddr2_init code , or it booted 
out of the box by applying this patch only ?

Thanks,
Eugen

[PATCH v2] ARM: dts: at91: sama5d3: add u-boot properties to sama5d3 pit timer

[Manuel Luís Reis]

Hi,

@Derald: Thanks for trying this out.

@Eugen: For what is worth, I can also confirm that I also tried with
the latest version v2021.04 and the board boots OK out of the box with
this patch only.

------------------------------------------------
RomBOOT
<debug_uart>
U-Boot SPL 2021.04-00372-g90eba245a6-dirty (Apr 07 2021 - 10:05:18 +0100)
Trying to boot from MMC1
<debug_uart>
U-Boot 2021.04-00372-g90eba245a6-dirty (Apr 07 2021 - 10:05:18 +0100)
CPU: SAMA5D36
Crystal frequency:       12 MHz
.....
------------------------------------------------

Thanks,
Manuel

On Wed, 7 Apr 2021 at 07:32, <Eugen.Hristev@microchip.com> wrote:
>
> On 4/7/21 1:16 AM, Derald Woods wrote:
> > On Tue, Apr 6, 2021 at 4:40 AM Manuel Reis <mluis.reis@gmail.com
> > <mailto:mluis.reis@gmail.com>> wrote:
> >
> >     in the early SPL boot stage whenever there is a call to udelay,
> >     dm_timer_init fails to find the pit timer whenever it traverses
> >     the device tree, if this property is not present
> >
> >     Signed-off-by: Manuel Reis <mluis.reis@gmail.com
> >     <mailto:mluis.reis@gmail.com>>
> >     CC: Eugen Hristev <eugen.hristev@microchip.com
> >     <mailto:eugen.hristev@microchip.com>>
> >     ---
> >       arch/arm/dts/sama5d3.dtsi | 1 +
> >       1 file changed, 1 insertion(+)
> >
> >     diff --git a/arch/arm/dts/sama5d3.dtsi b/arch/arm/dts/sama5d3.dtsi
> >     index 6ed218eaad..42c30e9f30 100644
> >     --- a/arch/arm/dts/sama5d3.dtsi
> >     +++ b/arch/arm/dts/sama5d3.dtsi
> >     @@ -1320,6 +1320,7 @@
> >                                      reg = <0xfffffe30 0xf>;
> >                                      interrupts = <3 IRQ_TYPE_LEVEL_HIGH 5>;
> >                                      clocks = <&mck>;
> >     +                               u-boot,dm-pre-reloc;
> >                              };
> >
> >                              watchdog at fffffe40 {
> >     --
> >     2.27.0
> >
> >
> > This patch, on top of v2021.04, allows my SAMA5D3 Xplained board to boot
> > normally again.
> >
> > Tested-by: Derald D. Woods <woods.technical@gmail.com
> > <mailto:woods.technical@gmail.com>>
> >
>
> Hi Derald,
>
> Could I ask, you are using the SPL to boot your board ?
> Did you have to remove any udelay from the ddr2_init code , or it booted
> out of the box by applying this patch only ?
>
> Thanks,
> Eugen

[PATCH v2] ARM: dts: at91: sama5d3: add u-boot properties to sama5d3 pit timer

[Eugen.Hristev at microchip.com]

On 4/7/21 12:16 PM, Manuel Lu?s Reis wrote:
> Hi,
> 
> @Derald: Thanks for trying this out.
> 
> @Eugen: For what is worth, I can also confirm that I also tried with
> the latest version v2021.04 and the board boots OK out of the box with
> this patch only.
> 

Ok, great news ! Thanks.

Until this patch can reach the master of u-boot, if anyone needs a tree, 
you can have my testing branch in u-boot-atmel custodian tree at denx:

https://source.denx.de/u-boot/custodians/u-boot-atmel/-/tree/testing

Eugen

> ------------------------------------------------
> RomBOOT
> <debug_uart>
> U-Boot SPL 2021.04-00372-g90eba245a6-dirty (Apr 07 2021 - 10:05:18 +0100)
> Trying to boot from MMC1
> <debug_uart>
> U-Boot 2021.04-00372-g90eba245a6-dirty (Apr 07 2021 - 10:05:18 +0100)
> CPU: SAMA5D36
> Crystal frequency:       12 MHz
> .....
> ------------------------------------------------
> 
> Thanks,
> Manuel
> 
> On Wed, 7 Apr 2021 at 07:32, <Eugen.Hristev@microchip.com> wrote:
>>
>> On 4/7/21 1:16 AM, Derald Woods wrote:
>>> On Tue, Apr 6, 2021 at 4:40 AM Manuel Reis <mluis.reis@gmail.com
>>> <mailto:mluis.reis@gmail.com>> wrote:
>>>
>>>      in the early SPL boot stage whenever there is a call to udelay,
>>>      dm_timer_init fails to find the pit timer whenever it traverses
>>>      the device tree, if this property is not present
>>>
>>>      Signed-off-by: Manuel Reis <mluis.reis@gmail.com
>>>      <mailto:mluis.reis@gmail.com>>
>>>      CC: Eugen Hristev <eugen.hristev@microchip.com
>>>      <mailto:eugen.hristev@microchip.com>>
>>>      ---
>>>        arch/arm/dts/sama5d3.dtsi | 1 +
>>>        1 file changed, 1 insertion(+)
>>>
>>>      diff --git a/arch/arm/dts/sama5d3.dtsi b/arch/arm/dts/sama5d3.dtsi
>>>      index 6ed218eaad..42c30e9f30 100644
>>>      --- a/arch/arm/dts/sama5d3.dtsi
>>>      +++ b/arch/arm/dts/sama5d3.dtsi
>>>      @@ -1320,6 +1320,7 @@
>>>                                       reg = <0xfffffe30 0xf>;
>>>                                       interrupts = <3 IRQ_TYPE_LEVEL_HIGH 5>;
>>>                                       clocks = <&mck>;
>>>      +                               u-boot,dm-pre-reloc;
>>>                               };
>>>
>>>                               watchdog at fffffe40 {
>>>      --
>>>      2.27.0
>>>
>>>
>>> This patch, on top of v2021.04, allows my SAMA5D3 Xplained board to boot
>>> normally again.
>>>
>>> Tested-by: Derald D. Woods <woods.technical@gmail.com
>>> <mailto:woods.technical@gmail.com>>
>>>
>>
>> Hi Derald,
>>
>> Could I ask, you are using the SPL to boot your board ?
>> Did you have to remove any udelay from the ddr2_init code , or it booted
>> out of the box by applying this patch only ?
>>
>> Thanks,
>> Eugen

[PATCH v2] ARM: dts: at91: sama5d3: add u-boot properties to sama5d3 pit timer

[Manuel Luís Reis]

Great, thanks for your help.

Cheers
Manuel

M. Lu?s Reis MSc MIET Chartered Engineer



On Wed, 7 Apr 2021 at 10:31, <Eugen.Hristev@microchip.com> wrote:
>
> On 4/7/21 12:16 PM, Manuel Lu?s Reis wrote:
> > Hi,
> >
> > @Derald: Thanks for trying this out.
> >
> > @Eugen: For what is worth, I can also confirm that I also tried with
> > the latest version v2021.04 and the board boots OK out of the box with
> > this patch only.
> >
>
> Ok, great news ! Thanks.
>
> Until this patch can reach the master of u-boot, if anyone needs a tree,
> you can have my testing branch in u-boot-atmel custodian tree at denx:
>
> https://source.denx.de/u-boot/custodians/u-boot-atmel/-/tree/testing
>
> Eugen
>
> > ------------------------------------------------
> > RomBOOT
> > <debug_uart>
> > U-Boot SPL 2021.04-00372-g90eba245a6-dirty (Apr 07 2021 - 10:05:18 +0100)
> > Trying to boot from MMC1
> > <debug_uart>
> > U-Boot 2021.04-00372-g90eba245a6-dirty (Apr 07 2021 - 10:05:18 +0100)
> > CPU: SAMA5D36
> > Crystal frequency:       12 MHz
> > .....
> > ------------------------------------------------
> >
> > Thanks,
> > Manuel
> >
> > On Wed, 7 Apr 2021 at 07:32, <Eugen.Hristev@microchip.com> wrote:
> >>
> >> On 4/7/21 1:16 AM, Derald Woods wrote:
> >>> On Tue, Apr 6, 2021 at 4:40 AM Manuel Reis <mluis.reis@gmail.com
> >>> <mailto:mluis.reis@gmail.com>> wrote:
> >>>
> >>>      in the early SPL boot stage whenever there is a call to udelay,
> >>>      dm_timer_init fails to find the pit timer whenever it traverses
> >>>      the device tree, if this property is not present
> >>>
> >>>      Signed-off-by: Manuel Reis <mluis.reis@gmail.com
> >>>      <mailto:mluis.reis@gmail.com>>
> >>>      CC: Eugen Hristev <eugen.hristev@microchip.com
> >>>      <mailto:eugen.hristev@microchip.com>>
> >>>      ---
> >>>        arch/arm/dts/sama5d3.dtsi | 1 +
> >>>        1 file changed, 1 insertion(+)
> >>>
> >>>      diff --git a/arch/arm/dts/sama5d3.dtsi b/arch/arm/dts/sama5d3.dtsi
> >>>      index 6ed218eaad..42c30e9f30 100644
> >>>      --- a/arch/arm/dts/sama5d3.dtsi
> >>>      +++ b/arch/arm/dts/sama5d3.dtsi
> >>>      @@ -1320,6 +1320,7 @@
> >>>                                       reg = <0xfffffe30 0xf>;
> >>>                                       interrupts = <3 IRQ_TYPE_LEVEL_HIGH 5>;
> >>>                                       clocks = <&mck>;
> >>>      +                               u-boot,dm-pre-reloc;
> >>>                               };
> >>>
> >>>                               watchdog at fffffe40 {
> >>>      --
> >>>      2.27.0
> >>>
> >>>
> >>> This patch, on top of v2021.04, allows my SAMA5D3 Xplained board to boot
> >>> normally again.
> >>>
> >>> Tested-by: Derald D. Woods <woods.technical@gmail.com
> >>> <mailto:woods.technical@gmail.com>>
> >>>
> >>
> >> Hi Derald,
> >>
> >> Could I ask, you are using the SPL to boot your board ?
> >> Did you have to remove any udelay from the ddr2_init code , or it booted
> >> out of the box by applying this patch only ?
> >>
> >> Thanks,
> >> Eugen
>

[PATCH v2] ARM: dts: at91: sama5d3: add u-boot properties to sama5d3 pit timer

[Eugen.Hristev at microchip.com]

On 4/7/21 12:39 PM, Manuel Lu?s Reis wrote:
> Great, thanks for your help.
> 
> Cheers
> Manuel
> 
> M. Lu?s Reis MSc MIET Chartered Engineer
> 
> 
> 
> On Wed, 7 Apr 2021 at 10:31, <Eugen.Hristev@microchip.com> wrote:
>>
>> On 4/7/21 12:16 PM, Manuel Lu?s Reis wrote:
>>> Hi,
>>>
>>> @Derald: Thanks for trying this out.
>>>
>>> @Eugen: For what is worth, I can also confirm that I also tried with
>>> the latest version v2021.04 and the board boots OK out of the box with
>>> this patch only.
>>>
>>
>> Ok, great news ! Thanks.
>>
>> Until this patch can reach the master of u-boot, if anyone needs a tree,
>> you can have my testing branch in u-boot-atmel custodian tree at denx:
>>
>> https://source.denx.de/u-boot/custodians/u-boot-atmel/-/tree/testing
>>
>> Eugen
>>
>>> ------------------------------------------------
>>> RomBOOT
>>> <debug_uart>
>>> U-Boot SPL 2021.04-00372-g90eba245a6-dirty (Apr 07 2021 - 10:05:18 +0100)
>>> Trying to boot from MMC1
>>> <debug_uart>
>>> U-Boot 2021.04-00372-g90eba245a6-dirty (Apr 07 2021 - 10:05:18 +0100)
>>> CPU: SAMA5D36
>>> Crystal frequency:       12 MHz
>>> .....
>>> ------------------------------------------------
>>>
>>> Thanks,
>>> Manuel
>>>
>>> On Wed, 7 Apr 2021 at 07:32, <Eugen.Hristev@microchip.com> wrote:
>>>>
>>>> On 4/7/21 1:16 AM, Derald Woods wrote:
>>>>> On Tue, Apr 6, 2021 at 4:40 AM Manuel Reis <mluis.reis@gmail.com
>>>>> <mailto:mluis.reis@gmail.com>> wrote:
>>>>>
>>>>>       in the early SPL boot stage whenever there is a call to udelay,
>>>>>       dm_timer_init fails to find the pit timer whenever it traverses
>>>>>       the device tree, if this property is not present
>>>>>
>>>>>       Signed-off-by: Manuel Reis <mluis.reis@gmail.com
>>>>>       <mailto:mluis.reis@gmail.com>>
>>>>>       CC: Eugen Hristev <eugen.hristev@microchip.com
>>>>>       <mailto:eugen.hristev@microchip.com>>
>>>>>       ---
>>>>>         arch/arm/dts/sama5d3.dtsi | 1 +
>>>>>         1 file changed, 1 insertion(+)
>>>>>
>>>>>       diff --git a/arch/arm/dts/sama5d3.dtsi b/arch/arm/dts/sama5d3.dtsi
>>>>>       index 6ed218eaad..42c30e9f30 100644
>>>>>       --- a/arch/arm/dts/sama5d3.dtsi
>>>>>       +++ b/arch/arm/dts/sama5d3.dtsi
>>>>>       @@ -1320,6 +1320,7 @@
>>>>>                                        reg = <0xfffffe30 0xf>;
>>>>>                                        interrupts = <3 IRQ_TYPE_LEVEL_HIGH 5>;
>>>>>                                        clocks = <&mck>;
>>>>>       +                               u-boot,dm-pre-reloc;
>>>>>                                };
>>>>>
>>>>>                                watchdog at fffffe40 {
>>>>>       --
>>>>>       2.27.0
>>>>>
>>>>>
>>>>> This patch, on top of v2021.04, allows my SAMA5D3 Xplained board to boot
>>>>> normally again.
>>>>>
>>>>> Tested-by: Derald D. Woods <woods.technical@gmail.com
>>>>> <mailto:woods.technical@gmail.com>>

Applied to u-boot-atmel/master, thanks, and,

Reviewed-by: Eugen Hristev <eugen.hristev@microchip.com>

>>>>>
>>>>
>>>> Hi Derald,
>>>>
>>>> Could I ask, you are using the SPL to boot your board ?
>>>> Did you have to remove any udelay from the ddr2_init code , or it booted
>>>> out of the box by applying this patch only ?
>>>>
>>>> Thanks,
>>>> Eugen
>>

[PATCH v2] ARM: dts: at91: sama5d3: add u-boot properties to sama5d3 pit timer

[Derald Woods]

On Wed, Apr 7, 2021 at 1:32 AM <Eugen.Hristev@microchip.com> wrote:

> On 4/7/21 1:16 AM, Derald Woods wrote:
> > On Tue, Apr 6, 2021 at 4:40 AM Manuel Reis <mluis.reis@gmail.com
> > <mailto:mluis.reis@gmail.com>> wrote:
> >
> >     in the early SPL boot stage whenever there is a call to udelay,
> >     dm_timer_init fails to find the pit timer whenever it traverses
> >     the device tree, if this property is not present
> >
> >     Signed-off-by: Manuel Reis <mluis.reis@gmail.com
> >     <mailto:mluis.reis@gmail.com>>
> >     CC: Eugen Hristev <eugen.hristev@microchip.com
> >     <mailto:eugen.hristev@microchip.com>>
> >     ---
> >       arch/arm/dts/sama5d3.dtsi | 1 +
> >       1 file changed, 1 insertion(+)
> >
> >     diff --git a/arch/arm/dts/sama5d3.dtsi b/arch/arm/dts/sama5d3.dtsi
> >     index 6ed218eaad..42c30e9f30 100644
> >     --- a/arch/arm/dts/sama5d3.dtsi
> >     +++ b/arch/arm/dts/sama5d3.dtsi
> >     @@ -1320,6 +1320,7 @@
> >                                      reg = <0xfffffe30 0xf>;
> >                                      interrupts = <3 IRQ_TYPE_LEVEL_HIGH
> 5>;
> >                                      clocks = <&mck>;
> >     +                               u-boot,dm-pre-reloc;
> >                              };
> >
> >                              watchdog at fffffe40 {
> >     --
> >     2.27.0
> >
> >
> > This patch, on top of v2021.04, allows my SAMA5D3 Xplained board to boot
> > normally again.
> >
> > Tested-by: Derald D. Woods <woods.technical@gmail.com
> > <mailto:woods.technical@gmail.com>>
> >
>
> Hi Derald,
>
> Could I ask, you are using the SPL to boot your board ?
> Did you have to remove any udelay from the ddr2_init code , or it booted
> out of the box by applying this patch only ?
>

With just this patch on top of v2021.04, the board booted as expected. It
did not work with v2021.01. So this patch works for "v2021.04" onward. I
did not touch ddr2_init code.

Derald



>
> Thanks,
> Eugen
>