From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id B9477ECAAA1 for ; Mon, 24 Oct 2022 10:54:45 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 72A57806F6; Mon, 24 Oct 2022 12:54:43 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=samsung.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=samsung.com header.i=@samsung.com header.b="swls54Vn"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id A49C4806F3; Mon, 24 Oct 2022 12:54:40 +0200 (CEST) Received: from mailout1.samsung.com (mailout1.samsung.com [203.254.224.24]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 01C5C806E6 for ; Mon, 24 Oct 2022 12:54:35 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=samsung.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=jh80.chung@samsung.com Received: from epcas1p1.samsung.com (unknown [182.195.41.45]) by mailout1.samsung.com (KnoxPortal) with ESMTP id 20221024105432epoutp01a8c51e8ea0d41b5975d594399eb4588e~g_-CJZEhJ1487914879epoutp019 for ; Mon, 24 Oct 2022 10:54:32 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 mailout1.samsung.com 20221024105432epoutp01a8c51e8ea0d41b5975d594399eb4588e~g_-CJZEhJ1487914879epoutp019 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=samsung.com; s=mail20170921; t=1666608872; bh=9/U07KinrNOBXG9EejRHetNhpqtRpinqbYjwZCDbgG0=; h=From:To:Cc:In-Reply-To:Subject:Date:References:From; b=swls54VnzoOZPuoBXcdyz/acPjEek9NXu27eOnVVcoBMluYOvXFemUah/B5qlCq8J wWwi0BbyxKacWeoABuP0RdmgDZR6R+NVG2ilwJ1w+qn3FZ8WuRRb0LShVzhSP/oxqL Mi8XMphEUpT0W4ro0phN2dgpQ7nD+KapfRoGzbSM= Received: from epsnrtp4.localdomain (unknown [182.195.42.165]) by epcas1p3.samsung.com (KnoxPortal) with ESMTP id 20221024105431epcas1p304e4f3229113962d46db9972d7e160d1~g_-BS83g82461724617epcas1p3F; Mon, 24 Oct 2022 10:54:31 +0000 (GMT) Received: from epsmges1p4.samsung.com (unknown [182.195.36.134]) by epsnrtp4.localdomain (Postfix) with ESMTP id 4MwsQZ5TJmz4x9Pw; Mon, 24 Oct 2022 10:54:30 +0000 (GMT) Received: from epcas1p2.samsung.com ( [182.195.41.46]) by epsmges1p4.samsung.com (Symantec Messaging Gateway) with SMTP id C0.30.07691.6EE66536; Mon, 24 Oct 2022 19:54:30 +0900 (KST) Received: from epsmtrp2.samsung.com (unknown [182.195.40.14]) by epcas1p3.samsung.com (KnoxPortal) with ESMTPA id 20221024105429epcas1p38bd50adea6d26be987795ff1df8e5798~g__-r0kXr2410224102epcas1p3M; Mon, 24 Oct 2022 10:54:29 +0000 (GMT) Received: from epsmgms1p1new.samsung.com (unknown [182.195.42.41]) by epsmtrp2.samsung.com (KnoxPortal) with ESMTP id 20221024105429epsmtrp2ea3ef9927169b11908e08ca7551c893a~g__-rL-kf0694806948epsmtrp2E; Mon, 24 Oct 2022 10:54:29 +0000 (GMT) X-AuditID: b6c32a38-0cdff70000021e0b-39-63566ee6e001 Received: from epsmtip1.samsung.com ( [182.195.34.30]) by epsmgms1p1new.samsung.com (Symantec Messaging Gateway) with SMTP id 9B.27.14392.5EE66536; Mon, 24 Oct 2022 19:54:29 +0900 (KST) Received: from jh80chung01 (unknown [10.113.111.84]) by epsmtip1.samsung.com (KnoxPortal) with ESMTPA id 20221024105429epsmtip187f41d4dd2109db17e15b76fe9338ae7~g__-ds5YS1589915899epsmtip18; Mon, 24 Oct 2022 10:54:29 +0000 (GMT) From: "Jaehoon Chung" To: "'Matt Ranostay'" , Cc: , "'Jaehoon Chung'" In-Reply-To: <028301d8e52c$9e1270c0$da375240$@samsung.com> Subject: RE: [PATCH] drivers: mmc: check the return value of mmc_send_if_cond() call Date: Mon, 24 Oct 2022 19:54:29 +0900 Message-ID: <01b301d8e796$fdcf1fb0$f96d5f10$@samsung.com> MIME-Version: 1.0 Content-Type: text/plain; charset="ks_c_5601-1987" Content-Transfer-Encoding: quoted-printable X-Mailer: Microsoft Outlook 15.0 Thread-Index: AQJkJlgyTmyA1y9whWcG0wPq5dROpgKBLgU6AYjGUD6s5pDVcA== Content-Language: ko X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFmpjk+LIzCtJLcpLzFFi42LZdlhTT/dZXliywZOfmhYXryxltlh+8Sij xY9VX1gt3u7tZHdg8dg56y67x9k7Oxg9Nr7bweRx/MZ2pgCWqGybjNTElNQihdS85PyUzLx0 WyXv4HjneFMzA0NdQ0sLcyWFvMTcVFslF58AXbfMHKCdSgpliTmlQKGAxOJiJX07m6L80pJU hYz84hJbpdSClJwC0wK94sTc4tK8dL281BIrQwMDI1OgwoTsjEVfdQqei1Xs+bePrYHxmWgX IyeHhICJRO/n7cxdjFwcQgI7GCX2rP3GCJIQEvjEKNHVqgOR+MYoMf3pM2aYjrP7J7JAJPYy SrxcdZ8NwnnJKHFn7j6wKjYBPYn/ixaC2SICNhLdvefBbGYBF4l7Wx6ygticAlYSzTeegNnC AmES0x+8Z+9i5OBgEVCVOHkhGiTMK2Ap8f/NXFYIW1Di5MwnLBBjjCSWrJ7PBGFrSyxb+Brq OAWJ3Z+OskKsdZI4/+4EI0SNiMTszjawNyUE/rJLHD20jxGiwUXi+codLBC2sMSr41vYIWwp ic/v9rJBNDQzSixdcpAVwulhlPjXcJ0NospYYv/SyUwQtqLEzt9zodbxSbz72sMK8o2EAK9E R5sQRImKxKXXL5lgFtx98p91AqPSLCTPzULy3Cwkz81C8sQCRpZVjGKpBcW56anFhgUm8OhO zs/dxAhOkFoWOxjnvv2gd4iRiYPxEKMEB7OSCC/Lk+BkId6UxMqq1KL8+KLSnNTiQ4ymwOCe yCwlmpwPTNF5JfGGJpYGJmZGxiYWhmaGSuK8DTO0koUE0hNLUrNTUwtSi2D6mDg4pRqYUnrF JvYomtjFn3CaM+Hxa6FJvBrPd9jueCy9Vv7LrM3fJm9zeqLw6X/n+UmbDmmGLa0/NUfd59Wq TVx/+pWO3Lu2silOybdHYtmqT3sfMzwwfrZIZdLpjhvh8/drKbRzLPzdnrze4KDILEbzRRsu Mfqu7GF6vSRuUUkvSzj3xYBvt+SMY+9p599e07zEapLPtIfhxia7TbNZkiSebP0unSK+QrKI eV/2mc8TOFwPSfR8a3fTvPagdi+f4MPlpwJfyZ/7Mln5cM37C9293oz6C8umcS7w+VzX8NT6 0IfQ0t5Gzi87X/57/3DbpxPVesqZSvN47QWWJcetechSaOz2N/fYV+2nsjti/s/xzvi/foIS S3FGoqEWc1FxIgDt5nSLGQQAAA== X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFnrHLMWRmVeSWpSXmKPExsWy7bCSnO7TvLBkgyk/TCwuXlnKbLH84lFG ix+rvrBavN3bye7A4rFz1l12j7N3djB6bHy3g8nj+I3tTAEsUVw2Kak5mWWpRfp2CVwZNz8q FfQJVCw+9oWtgfE+TxcjJ4eEgInE2f0TWboYuTiEBHYzStyb8YsJIiEl8fnpVLYuRg4gW1ji 8OFiiJrnjBJvrk1kA6lhE9CT+L9oITOILSJgJ7F44SJ2EJtZwE3i9s7TrBAN2xgl9s79AtbA KWAl0XzjCSuILSwQInF+6jpWkAUsAqoSJy9Eg4R5BSwl/r+ZywphC0qcnPmEBWKmiUTj4W4o W1ti2cLXzBB3Kkjs/nSUFeIGJ4nz704wQtSISMzubGOewCg8C8moWUhGzUIyahaSlgWMLKsY JVMLinPTc4sNCwzzUsv1ihNzi0vz0vWS83M3MYKjREtzB+P2VR/0DjEycTAeYpTgYFYS4WV5 EpwsxJuSWFmVWpQfX1Sak1p8iFGag0VJnPdC18l4IYH0xJLU7NTUgtQimCwTB6dUA9OhSXYJ Z4S6lANPf9ad6sYb/nFZ863PB4++/ceSdelx4KnJEzMOlmaoL/MwU+1QPm235dHerzGM8Uk+ e+Y9j1F738la/W5lkaN5xzSxWaG71n748fHqxSuVt5yeyLZyLZ69fklWwbU3h0O3zzr7PUi8 Yhoru87R77om7KtmLV7zYeK2v7N/TOHa5Bone96XpeZm/Vlf0c0VO1beOrR+56eyztjM0PkX TuufX3z4Ndul0G3rY9JetkVlil3d/u6rbtipjXu+Ojn/sBb+22HlNnXCAs4/Hk9eXch0MZl3 fcUOZpl5M6tS1G0mvPj2+rrQ3m2JxV3rMx2SbujO08vbk5LHVhvKbN+me9Oca8OG9IVrVZRY ijMSDbWYi4oTAZVqIYYBAwAA X-CMS-MailID: 20221024105429epcas1p38bd50adea6d26be987795ff1df8e5798 X-Msg-Generator: CA X-Sendblock-Type: SVC_REQ_APPROVE CMS-TYPE: 101P DLP-Filter: Pass X-CFilter-Loop: Reflected X-CMS-RootMailID: 20221021071627epcas1p443b2a156e4ef08f8be8b9d02cb699acc References: <20221021071602.349483-1-mranostay@ti.com> <028301d8e52c$9e1270c0$da375240$@samsung.com> X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.6 at phobos.denx.de X-Virus-Status: Clean Hi Matt, After applied this patch, CI Test is failed. Test for Nokia RX-51 (aka N900) I will not apply this patch at this time until fixing CI fail issue. Best Regards, Jaehoon Chung > -----Original Message----- > From: U-Boot =5Bmailto:u-boot-bounces=40lists.denx.de=5D On Behalf Of =C1= =A4=C0=E7=C8=C6=0D=0A>=20Sent:=20Friday,=20October=2021,=202022=206:08=20PM= =0D=0A>=20To:=20'Matt=20Ranostay'=20;=20peng.fan=40nxp.= com=0D=0A>=20Cc:=20u-boot=40lists.denx.de=0D=0A>=20Subject:=20RE:=20=5BPATC= H=5D=20drivers:=20mmc:=20check=20the=20return=20value=20of=20mmc_send_if_co= nd()=20call=0D=0A>=20=0D=0A>=20=0D=0A>=20>=20-----Original=20Message-----= =0D=0A>=20>=20From:=20Matt=20Ranostay=20=5Bmailto:mranostay=40ti.com=5D=0D= =0A>=20>=20Sent:=20Friday,=20October=2021,=202022=204:16=20PM=0D=0A>=20>=20= To:=20peng.fan=40nxp.com;=20jh80.chung=40samsung.com=0D=0A>=20>=20Cc:=20u-b= oot=40lists.denx.de;=20Matt=20Ranostay=20=0D=0A>=20>=20= Subject:=20=5BPATCH=5D=20drivers:=20mmc:=20check=20the=20return=20value=20o= f=20mmc_send_if_cond()=20call=0D=0A>=20>=0D=0A>=20>=20Return=20value=20from= =20mmc_send_if_cond()=20isn't=20checked=20if=20it=20is=20a=20error=20state= =0D=0A>=20>=20and=20the=20result=20immediately=20is=20overwritten=20with=20= the=20sd_send_op_cond()=20call.=0D=0A>=20>=0D=0A>=20>=20Add=20check=20for= =20-EOPNOTSUPP=20to=20fail=20early,=20and=20trigger=20a=20retry=20for=20any= =20other=0D=0A>=20>=20error=20code.=0D=0A>=20>=0D=0A>=20>=20Fixes:=20afd593= 2b2c27=20(=22Revert=20=22mmc:=20retry=20the=20cmd8=20to=20meet=2074=20clock= s=20requirement=20in=20the=20spec=22)=0D=0A>=20>=20Signed-off-by:=20Matt=20= Ranostay=20=0D=0A>=20=0D=0A>=20Reviewed-by:=20Jaehoon= =20Chung=20=0D=0A>=20=0D=0A>=20Best=20Regards,=0D= =0A>=20Jaehoon=20Chung=0D=0A>=20=0D=0A>=20>=20---=0D=0A>=20>=20=20drivers/m= mc/mmc.c=20=7C=207=20+++++++=0D=0A>=20>=20=201=20file=20changed,=207=20inse= rtions(+)=0D=0A>=20>=0D=0A>=20>=20diff=20--git=20a/drivers/mmc/mmc.c=20b/dr= ivers/mmc/mmc.c=0D=0A>=20>=20index=200b7c0be8cbc..e26a457a74c=20100644=0D= =0A>=20>=20---=20a/drivers/mmc/mmc.c=0D=0A>=20>=20+++=20b/drivers/mmc/mmc.c= =0D=0A>=20>=20=40=40=20-2862,6=20+2862,13=20=40=40=20retry:=0D=0A>=20>=0D= =0A>=20>=20=20=09/*=20Test=20for=20SD=20version=202=20*/=0D=0A>=20>=20=20= =09err=20=3D=20mmc_send_if_cond(mmc);=0D=0A>=20>=20+=09if=20(err=20=3D=3D= =20-EOPNOTSUPP)=0D=0A>=20>=20+=09=09return=20err;=0D=0A>=20>=20+=0D=0A>=20>= =20+=09if=20(err)=20=7B=0D=0A>=20>=20+=09=09mmc_power_cycle(mmc);=0D=0A>=20= >=20+=09=09goto=20retry;=0D=0A>=20>=20+=09=7D=0D=0A>=20>=0D=0A>=20>=20=20= =09/*=20Now=20try=20to=20get=20the=20SD=20card's=20operating=20condition=20= */=0D=0A>=20>=20=20=09err=20=3D=20sd_send_op_cond(mmc,=20uhs_en);=0D=0A>=20= >=20--=0D=0A>=20>=202.38.GIT=0D=0A>=20=0D=0A=0D=0A=0D=0A