From: victor <victor@keyasic.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] USB mass storage gadget patch
Date: Tue, 6 Nov 2012 17:58:33 +0800 [thread overview]
Message-ID: <01b501cdbc05$4b378300$e1a68900$@keyasic.com> (raw)
In-Reply-To: <20121106100343.3db7cc1a@amdc308.digital.local>
Lukasz,
> Hi victor,
>
> Regarding UMS support:
>
> The last version posted at u-boot ML can be found at [**]:
> http://thread.gmane.org/gmane.comp.boot-loaders.u-
> boot/113004/match=ums
>
>
> +if (fsg_fs_bulk_out_desc.bEndpointAddress != 0x1)
> + fsg_fs_bulk_out_desc.bEndpointAddress = 0x1;
> +
>
> If possible, please align to patch set [**], so we can have the same
setup.
>
> However, I will try to find some time to help you with the problem (that's
> why I've asked for description of the problem, which you are trying to
fix).
>
I hardcode bulk out endpoint to EP1 because the hardware only got one
endpoint. So the code has to use EP1 for both bulk in and bulk out data
transfer. Will this break the usb mass storage gadget code?
I will get the file_storage.c from [**].
The short description of the problem:
The U-boot usb mass storage gadget driver has problem with buffer
management, sometimes the buffer returned by IRQ routine and the
get_next_command function are different. It causes problem in processing
SCSI_MODE_SELECT_6 command.
The detailed description of the problem:
When receiving the SCSI_MODE_SELECT_6 command, in bulk_out_complete(), the
bh pointer is 0x1b872e4. Then, in get_next_command(), before calling
start_transfer(), the bh pointer becomes 0x1b87304. This changes in bh
pointer can cause data not to be processed by the usb mass storage gadget
code.
Thanks,
Victor
================================================================================================
CONFIDENTIALITY NOTE:
This e-mail and any attachments may contain confidential information and may be protected by legal privilege. If you are not the intended addressee (or authorized to receive for the addressee). be aware that any disclosure, copying, distribution or use of this e-mail or any attachment is prohibited. If you have received this e-mail in error, please notify us immediately by returning it to the sender and delete this copy from your system. Thank you for your cooperation.
KeyASIC Inc.
================================================================================================
next prev parent reply other threads:[~2012-11-06 9:58 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-11-02 11:07 [U-Boot] USB mass storage gadget patch victor
2012-11-02 13:19 ` Lukasz Majewski
2012-11-05 2:30 ` victor
2012-11-05 6:45 ` victor
2012-11-06 6:46 ` victor
2012-11-06 9:03 ` Lukasz Majewski
2012-11-06 9:58 ` victor [this message]
2012-11-06 11:08 ` victor
2012-11-22 2:24 ` victor
-- strict thread matches above, loose matches on Subject: below --
2012-11-02 11:43 victor
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='01b501cdbc05$4b378300$e1a68900$@keyasic.com' \
--to=victor@keyasic.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox