public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Heiko Schocher <hs@denx.de>
To: Fabio Estevam <festevam@denx.de>, sbabic@denx.de
Cc: uboot-imx@nxp.com, u-boot@lists.denx.de, heiko.thiery@gmail.com,
	frieder.schrempf@kontron.de, tharvey@gateworks.com
Subject: Re: [RFC] imx8mm-evk: Generate a bootable flash.bin again
Date: Tue, 17 Aug 2021 05:56:26 +0200	[thread overview]
Message-ID: <01dda5ff-e70c-cc20-183d-376f3d2104f7@denx.de> (raw)
In-Reply-To: <20210816152132.306399-1-festevam@denx.de>

Hello Fabio,

On 16.08.21 17:21, Fabio Estevam wrote:
> After the convesion to binman in commit 8996e6b7c6a1 ("imx8mm_evk: switch
> to use binman to pack images"), it is necessary to flash both flash.bin and
> u-boot.itb to get a bootable system. Prior to this commit, only flash.bin
> was needed.
> 
> Such new requirement breaks existing distro mechanisms to generate the
> final image because the extra u-boot.itb is now required.
> 
> Generate a final flash.bin image that can be used again as a single
> bootable image to keep the original behavior.
> 
> Suggested-by: Heiko Schocher <hs@denx.de>
> Signed-off-by: Fabio Estevam <festevam@denx.de>
> ---
>  arch/arm/dts/imx8mm-evk-u-boot.dtsi | 15 +++++++++++++++
>  1 file changed, 15 insertions(+)
> 
> diff --git a/arch/arm/dts/imx8mm-evk-u-boot.dtsi b/arch/arm/dts/imx8mm-evk-u-boot.dtsi
> index f200afac9f..ad3056c7c8 100644
> --- a/arch/arm/dts/imx8mm-evk-u-boot.dtsi
> +++ b/arch/arm/dts/imx8mm-evk-u-boot.dtsi
> @@ -217,4 +217,19 @@
>  			};
>  		};
>  	};
> +
> +	imx-boot {
> +		filename = "flash.bin";

I am unsure here, if it makes sense to overwrite flash.bin with the
binary which contains SPL and u-boot.itb. May others want to use
them (as I currently use them for signing them)

Why not imx-boot as image name as in NXP sources?
(Thats why I named it so in my "fast example approach")

> +		pad-byte = <0x00>;
> +
> +		spl: blob-ext@1 {
> +			offset = <0x0>;
> +			filename = "flash.bin";
> +		};
> +
> +		uboot: blob-ext@2 {
> +			offset = <0x57c00>;
> +			filename = "u-boot.itb";
> +		};
> +	};
>  };
> 

regarding the question, if we can make a generic file .. for example
on the imx8mp-phyboard-pollux-rdk u-boot is at offset 0x60000 in
QSPI NOR ( for QSPI boot of course)

So, there should be something like this:

+	imx-boot {
+		filename = "imx-boot";
+		pad-byte = <0x00>;
+
+		qspiheader: blob-ext@2 {
+			offset = <0x400>;
+			filename = "qspiheader.bin";
+		};
+
+		spl: blob-ext@2 {
+			offset = <0x1000>;
+			filename = "flash.bin";
+		};
+
+		uboot: blob-ext@3 {
+			offset = <0x60000>;
+			filename = "u-boot.itb";
+		};
+	};

On sd card boot it is without qspiheader and offsets -0x1000, so
may we make a imx-boot and imx-boot-qspi ?

+	imx-boot {
+		filename = "imx-boot";
+		pad-byte = <0x00>;
+
+		spl: blob-ext@1 {
+			offset = <0x0>;
+			filename = "flash.bin";
+		};
+
+		uboot: blob-ext@2 {
+			offset = <0x59000>;
+			filename = "u-boot.itb";
+		};
+	};

+	imx-boot-qspi {
+		filename = "imx-boot-qspi";
+		pad-byte = <0x00>;
+
+		qspiheader: blob-ext@2 {
+			offset = <0x400>;
+			filename = "qspiheader.bin";
+		};
+
+		imx-boot: blob-ext@2 {
+			offset = <0x1000>;
+			filename = "imx-boot";
+		};
+	};

And of course we must add a possibility to create qspi header. I have
here local some python script, but not sure how to integrate this to
binman.

And it would be very cool, to sign the image with binman!

bye,
Heiko
-- 
DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-52   Fax: +49-8142-66989-80   Email: hs@denx.de

  reply	other threads:[~2021-08-17  3:56 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-08-16 15:21 [RFC] imx8mm-evk: Generate a bootable flash.bin again Fabio Estevam
2021-08-17  3:56 ` Heiko Schocher [this message]
2021-08-17  9:37   ` Heiko Thiery
2021-08-17 10:08     ` Heiko Schocher
2021-08-18  1:44   ` Fabio Estevam
2021-08-18  5:19     ` Heiko Schocher
2021-08-18  6:36       ` Frieder Schrempf
2021-08-18  6:47         ` Frieder Schrempf
2021-08-18  8:24           ` Marcel Ziswiler
2021-08-18  6:30     ` Frieder Schrempf

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=01dda5ff-e70c-cc20-183d-376f3d2104f7@denx.de \
    --to=hs@denx.de \
    --cc=festevam@denx.de \
    --cc=frieder.schrempf@kontron.de \
    --cc=heiko.thiery@gmail.com \
    --cc=sbabic@denx.de \
    --cc=tharvey@gateworks.com \
    --cc=u-boot@lists.denx.de \
    --cc=uboot-imx@nxp.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox