public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
* [PATCH] mmc: spl: select SPL_BLK for SPL_DM_MMC
@ 2023-08-23 15:45 ` Oleksandr Suvorov
  2023-08-23 17:50   ` Tom Rini
  2023-10-31  5:03   ` Jaehoon Chung
  0 siblings, 2 replies; 4+ messages in thread
From: Oleksandr Suvorov @ 2023-08-23 15:45 UTC (permalink / raw)
  To: u-boot; +Cc: Oleksandr Suvorov, Jaehoon Chung, Peng Fan

mmc_bind() in mmc-uclass.c calls blk_create_devicef() which is
defined in blk-uclass.c, so SPL_BLK is required by SPL_DM_MMC.
Implicitly select SPL_BLK for SPL_DM_MMC.

Signed-off-by: Oleksandr Suvorov <oleksandr.suvorov@foundries.io>
---

 drivers/mmc/Kconfig | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/mmc/Kconfig b/drivers/mmc/Kconfig
index de01b9687ba..d24677de076 100644
--- a/drivers/mmc/Kconfig
+++ b/drivers/mmc/Kconfig
@@ -46,6 +46,7 @@ config SPL_DM_MMC
 	depends on SPL_DM && DM_MMC
 	default n if ARCH_MVEBU && !MVEBU_SPL_BOOT_DEVICE_MMC
 	default y
+	select SPL_BLK
 	help
 	  This enables the MultiMediaCard (MMC) uclass which supports MMC and
 	  Secure Digital I/O (SDIO) cards. Both removable (SD, micro-SD, etc.)
-- 
2.41.0


^ permalink raw reply related	[flat|nested] 4+ messages in thread

* Re: [PATCH] mmc: spl: select SPL_BLK for SPL_DM_MMC
  2023-08-23 15:45 ` [PATCH] mmc: spl: select SPL_BLK for SPL_DM_MMC Oleksandr Suvorov
@ 2023-08-23 17:50   ` Tom Rini
  2023-10-31  5:03   ` Jaehoon Chung
  1 sibling, 0 replies; 4+ messages in thread
From: Tom Rini @ 2023-08-23 17:50 UTC (permalink / raw)
  To: Oleksandr Suvorov; +Cc: u-boot, Jaehoon Chung, Peng Fan

[-- Attachment #1: Type: text/plain, Size: 378 bytes --]

On Wed, Aug 23, 2023 at 06:45:45PM +0300, Oleksandr Suvorov wrote:

> mmc_bind() in mmc-uclass.c calls blk_create_devicef() which is
> defined in blk-uclass.c, so SPL_BLK is required by SPL_DM_MMC.
> Implicitly select SPL_BLK for SPL_DM_MMC.
> 
> Signed-off-by: Oleksandr Suvorov <oleksandr.suvorov@foundries.io>

Reviewed-by: Tom Rini <trini@konsulko.com>

-- 
Tom

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 659 bytes --]

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] mmc: spl: select SPL_BLK for SPL_DM_MMC
  2023-08-23 15:45 ` [PATCH] mmc: spl: select SPL_BLK for SPL_DM_MMC Oleksandr Suvorov
  2023-08-23 17:50   ` Tom Rini
@ 2023-10-31  5:03   ` Jaehoon Chung
  2023-11-01  5:44     ` Jaehoon Chung
  1 sibling, 1 reply; 4+ messages in thread
From: Jaehoon Chung @ 2023-10-31  5:03 UTC (permalink / raw)
  To: Oleksandr Suvorov, u-boot; +Cc: Peng Fan

On 8/24/23 00:45, Oleksandr Suvorov wrote:
> mmc_bind() in mmc-uclass.c calls blk_create_devicef() which is
> defined in blk-uclass.c, so SPL_BLK is required by SPL_DM_MMC.
> Implicitly select SPL_BLK for SPL_DM_MMC.
> 
> Signed-off-by: Oleksandr Suvorov <oleksandr.suvorov@foundries.io>
> Reviewed-by: Tom Rini <trini@konsulko.com>

Reviewed-by: Jaehoon Chung <jh80.chung@samsung.com>

Best Regards,
Jaehoon Chung

> ---
> 
>  drivers/mmc/Kconfig | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/mmc/Kconfig b/drivers/mmc/Kconfig
> index de01b9687ba..d24677de076 100644
> --- a/drivers/mmc/Kconfig
> +++ b/drivers/mmc/Kconfig
> @@ -46,6 +46,7 @@ config SPL_DM_MMC
>  	depends on SPL_DM && DM_MMC
>  	default n if ARCH_MVEBU && !MVEBU_SPL_BOOT_DEVICE_MMC
>  	default y
> +	select SPL_BLK
>  	help
>  	  This enables the MultiMediaCard (MMC) uclass which supports MMC and
>  	  Secure Digital I/O (SDIO) cards. Both removable (SD, micro-SD, etc.)


^ permalink raw reply	[flat|nested] 4+ messages in thread

* RE: [PATCH] mmc: spl: select SPL_BLK for SPL_DM_MMC
  2023-10-31  5:03   ` Jaehoon Chung
@ 2023-11-01  5:44     ` Jaehoon Chung
  0 siblings, 0 replies; 4+ messages in thread
From: Jaehoon Chung @ 2023-11-01  5:44 UTC (permalink / raw)
  To: 'Oleksandr Suvorov', u-boot; +Cc: 'Peng Fan'



> -----Original Message-----
> From: U-Boot <u-boot-bounces@lists.denx.de> On Behalf Of Jaehoon Chung
> Sent: Tuesday, October 31, 2023 2:04 PM
> To: Oleksandr Suvorov <oleksandr.suvorov@foundries.io>; u-boot@lists.denx.de
> Cc: Peng Fan <peng.fan@nxp.com>
> Subject: Re: [PATCH] mmc: spl: select SPL_BLK for SPL_DM_MMC
> 
> On 8/24/23 00:45, Oleksandr Suvorov wrote:
> > mmc_bind() in mmc-uclass.c calls blk_create_devicef() which is
> > defined in blk-uclass.c, so SPL_BLK is required by SPL_DM_MMC.
> > Implicitly select SPL_BLK for SPL_DM_MMC.
> >
> > Signed-off-by: Oleksandr Suvorov <oleksandr.suvorov@foundries.io>
> > Reviewed-by: Tom Rini <trini@konsulko.com>
> 
> Reviewed-by: Jaehoon Chung <jh80.chung@samsung.com>

Applied to u-boot-mmc/master. Thanks!

Best Regards,
Jaehoon Chung

> 
> Best Regards,
> Jaehoon Chung
> 
> > ---
> >
> >  drivers/mmc/Kconfig | 1 +
> >  1 file changed, 1 insertion(+)
> >
> > diff --git a/drivers/mmc/Kconfig b/drivers/mmc/Kconfig
> > index de01b9687ba..d24677de076 100644
> > --- a/drivers/mmc/Kconfig
> > +++ b/drivers/mmc/Kconfig
> > @@ -46,6 +46,7 @@ config SPL_DM_MMC
> >  	depends on SPL_DM && DM_MMC
> >  	default n if ARCH_MVEBU && !MVEBU_SPL_BOOT_DEVICE_MMC
> >  	default y
> > +	select SPL_BLK
> >  	help
> >  	  This enables the MultiMediaCard (MMC) uclass which supports MMC and
> >  	  Secure Digital I/O (SDIO) cards. Both removable (SD, micro-SD, etc.)



^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2023-11-01  5:44 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
     [not found] <CGME20231031050352epcas1p49c7f9320c0200242a7851041f6e6ad93@epcas1p4.samsung.com>
2023-08-23 15:45 ` [PATCH] mmc: spl: select SPL_BLK for SPL_DM_MMC Oleksandr Suvorov
2023-08-23 17:50   ` Tom Rini
2023-10-31  5:03   ` Jaehoon Chung
2023-11-01  5:44     ` Jaehoon Chung

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox