From mboxrd@z Thu Jan  1 00:00:00 1970
From: klaus.goger at theobroma-systems.com <klaus.goger@theobroma-systems.com>
Date: Tue, 19 May 2020 20:39:22 +0200
Subject: [PATCH 4/7] rockchip: Remove ARCH= references from documentation
In-Reply-To: <20200519145111.21515-4-trini@konsulko.com>
References: <20200519145111.21515-1-trini@konsulko.com>
 <20200519145111.21515-4-trini@konsulko.com>
Message-ID: <020a9b9c4f2ba7d8a9bdf06a54ba53fa@theobroma-systems.com>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

On 2020-05-19 16:51, Tom Rini wrote:
> When building U-Boot we select the architecture via Kconfig and not 
> ARCH
> being passed in via the environment or make cmdline.
> 
> Cc: Kever Yang <kever.yang@rock-chips.com>
> Cc: Simon Glass <sjg@chromium.org>
> Cc: Philipp Tomsich <philipp.tomsich@theobroma-systems.com>
> Cc: Klaus Goger <klaus.goger@theobroma-systems.com>
> Cc: Jagan Teki <jagan@amarulasolutions.com>
> Signed-off-by: Tom Rini <trini@konsulko.com>
> ---
> As an aside, these files should be converted rST and moved to 
> doc/board/
> and the MAINTAINERS file updated to include the new documentation file
> too.  Thanks!
> ---
>  board/rockchip/evb_rk3229/README           | 1 -
>  board/rockchip/evb_rk3399/README           | 1 -
>  board/theobroma-systems/lion_rk3368/README | 4 ++--
>  board/vamrs/rock960_rk3399/README          | 1 -
>  4 files changed, 2 insertions(+), 5 deletions(-)
> 
> diff --git a/board/rockchip/evb_rk3229/README 
> b/board/rockchip/evb_rk3229/README
> index 93328c75b204..9068225e2721 100644
> --- a/board/rockchip/evb_rk3229/README
> +++ b/board/rockchip/evb_rk3229/README
> @@ -22,7 +22,6 @@ Compile the U-Boot
> 
>    > cd ../u-boot
>    > export CROSS_COMPILE=arm-linux-gnueabihf-
> -  > export ARCH=arm
>    > make evb-rk3229_defconfig
>    > make
>    > make u-boot.itb
> diff --git a/board/rockchip/evb_rk3399/README 
> b/board/rockchip/evb_rk3399/README
> index da7ae89ab1e9..c6f58203ebe9 100644
> --- a/board/rockchip/evb_rk3399/README
> +++ b/board/rockchip/evb_rk3399/README
> @@ -54,7 +54,6 @@ Compile U-Boot
>  ==============
> 
>    > cd ../u-boot
> -  > export ARCH=arm64
>    > export CROSS_COMPILE=aarch64-linux-gnu-
>    > make evb-rk3399_defconfig
>    for firefly-rk3399, use below instead:
> diff --git a/board/theobroma-systems/lion_rk3368/README
> b/board/theobroma-systems/lion_rk3368/README
> index ad3ac93bd44b..7488b18326b9 100644
> --- a/board/theobroma-systems/lion_rk3368/README
> +++ b/board/theobroma-systems/lion_rk3368/README
> @@ -17,12 +17,12 @@ Configure U-Boot
>  Build the TPL/SPL stage
>  =======================
> 
> -  > make CROSS_COMPILE=aarch64-unknown-elf- ARCH=arm
> +  > make CROSS_COMPILE=aarch64-unknown-elf-
> 
>  Build the full U-Boot and a FIT image including the ATF
>  =======================================================
> 
> -  > make CROSS_COMPILE=aarch64-unknown-elf- ARCH=arm u-boot.itb
> +  > make CROSS_COMPILE=aarch64-unknown-elf- u-boot.itb
> 
>  Flash the image
>  ===============
> diff --git a/board/vamrs/rock960_rk3399/README
> b/board/vamrs/rock960_rk3399/README
> index c5c675c4ead1..15df027fbcd4 100644
> --- a/board/vamrs/rock960_rk3399/README
> +++ b/board/vamrs/rock960_rk3399/README
> @@ -57,7 +57,6 @@ Compile the U-Boot
> 
>    > cd ../u-boot
>    > cp ../rkbin/rk33/rk3399_bl31_v1.00.elf ./bl31.elf
> -  > export ARCH=arm64
>    > export CROSS_COMPILE=aarch64-linux-gnu-
>    > make rock960-rk3399_defconfig
>    > make

Reviewed-by: Klaus Goger <klaus.goger@theobroma-systems.com>

Thanks for the hint about converting to rST. Will send patches
for at least the boards that list me as maintainer.

Best,
Klaus