public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: "Jaehoon Chung" <jh80.chung@samsung.com>
To: "'Tom Rini'" <trini@konsulko.com>, <u-boot@lists.denx.de>
Cc: "'Peng Fan'" <peng.fan@nxp.com>
Subject: RE: [PATCH] mmc: Kconfig: Correct dependencies SDHCI ADMA options
Date: Wed, 15 Jan 2025 11:21:48 +0900	[thread overview]
Message-ID: <024301db66f4$3af88320$b0e98960$@samsung.com> (raw)
In-Reply-To: <20250115020737.230558-1-trini@konsulko.com>



> -----Original Message-----
> From: Tom Rini <trini@konsulko.com>
> Sent: Wednesday, January 15, 2025 11:08 AM
>
> The option MMC_SDHCI_ADMA_FORCE_32BIT is only tested or used when
> MMC_SDHCI_ADMA or SPL_MMC_SDHCI_ADMA is enabled. And for
> MMC_SDHCI_ADMA_64BIT the same is true except we also require
> MMC_SDHCI_ADMA_FORCE_32BIT to be disabled.
>
> Signed-off-by: Tom Rini <trini@konsulko.com>

Reviewed-by: Jaehoon Chung <jh80.chung@samsung.com>

Best Regards,
Jaehoon Chung

> ---
> Cc: Peng Fan <peng.fan@nxp.com>
> Cc: Jaehoon Chung <jh80.chung@samsung.com>
> ---
>  drivers/mmc/Kconfig | 2 ++
>  1 file changed, 2 insertions(+)
>
> diff --git a/drivers/mmc/Kconfig b/drivers/mmc/Kconfig
> index f4fdf15242ce..6dc8d3bf9fe2 100644
> --- a/drivers/mmc/Kconfig
> +++ b/drivers/mmc/Kconfig
> @@ -527,6 +527,7 @@ config SPL_MMC_SDHCI_ADMA
>
>  config MMC_SDHCI_ADMA_FORCE_32BIT
>  	bool "Force 32 bit mode for ADMA on 64 bit platforms"
> +	depends on MMC_SDHCI_ADMA || SPL_MMC_SDHCI_ADMA
>  	help
>  	  This forces SDHCI ADMA to be built for 32 bit descriptors, even
>  	  on a 64 bit platform where they would otherwise be assumed to
> @@ -536,6 +537,7 @@ config MMC_SDHCI_ADMA_FORCE_32BIT
>
>  config MMC_SDHCI_ADMA_64BIT
>  	bool "Use SHDCI ADMA with 64 bit descriptors"
> +	depends on MMC_SDHCI_ADMA || SPL_MMC_SDHCI_ADMA
>  	depends on !MMC_SDHCI_ADMA_FORCE_32BIT
>  	default y if DMA_ADDR_T_64BIT
>  	help
> --
> 2.43.0




  parent reply	other threads:[~2025-01-15  2:22 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <CGME20250115020743epcas1p1be3492abc3a2435f603c7b2dd14be15a@epcas1p1.samsung.com>
2025-01-15  2:07 ` [PATCH] mmc: Kconfig: Correct dependencies SDHCI ADMA options Tom Rini
2025-01-15  2:11   ` Peng Fan
2025-01-15  2:21   ` Jaehoon Chung [this message]
2025-04-11  3:54   ` Peng Fan (OSS)
2025-06-11  9:58     ` Heiko Thiery
2025-06-11 14:20       ` Tom Rini

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='024301db66f4$3af88320$b0e98960$@samsung.com' \
    --to=jh80.chung@samsung.com \
    --cc=peng.fan@nxp.com \
    --cc=trini@konsulko.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox