[PATCH 1/8] tools: fdtgrep: Mark util_version() as static

[PATCH 1/8] tools: fdtgrep: Mark util_version() as static

[Ilias Apalodimas]

The function is only used locally. Enabling -Wmissing-prototypes
triggers a warning. Mark it as static.

Signed-off-by: Ilias Apalodimas <ilias.apalodimas@linaro.org>
---
 tools/fdtgrep.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tools/fdtgrep.c b/tools/fdtgrep.c
index 037176bc9ef8..6372defedc2e 100644
--- a/tools/fdtgrep.c
+++ b/tools/fdtgrep.c
@@ -1109,7 +1109,7 @@ void util_usage(const char *errmsg, const char *synopsis,
 	util_usage(errmsg, usage_synopsis, usage_short_opts, \
 		   usage_long_opts, usage_opts_help)
 
-void util_version(void)
+static void util_version(void)
 {
 	printf("Version: %s\n", "(U-Boot)");
 	exit(0);
-- 
2.50.1

[PATCH 2/8] tools: fdtgrep: Mark util_usage() as static

[Ilias Apalodimas]

The function is only used locally. Enabling -Wmissing-prototypes
triggers a warning. Mark it as static.

Signed-off-by: Ilias Apalodimas <ilias.apalodimas@linaro.org>
---
 tools/fdtgrep.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tools/fdtgrep.c b/tools/fdtgrep.c
index 6372defedc2e..b4c041070f56 100644
--- a/tools/fdtgrep.c
+++ b/tools/fdtgrep.c
@@ -1040,7 +1040,7 @@ static const char * const usage_opts_help[] = {
 #define util_getopt_long() getopt_long(argc, argv, usage_short_opts, \
 				       usage_long_opts, NULL)
 
-void util_usage(const char *errmsg, const char *synopsis,
+static void util_usage(const char *errmsg, const char *synopsis,
 		const char *short_opts, struct option const long_opts[],
 		const char * const opts_help[])
 {
-- 
2.50.1

[PATCH 3/8] tools: mkimage: Mark copy_datafile() as static

[Ilias Apalodimas]

The function is only used locally. Enabling -Wmissing-prototypes
triggers a warning. Mark it as static.

Signed-off-by: Ilias Apalodimas <ilias.apalodimas@linaro.org>
---
 tools/mkimage.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tools/mkimage.c b/tools/mkimage.c
index 361711c53b2b..847453970ab5 100644
--- a/tools/mkimage.c
+++ b/tools/mkimage.c
@@ -445,7 +445,7 @@ static void verify_image(const struct image_type_params *tparams)
 	(void)close(ifd);
 }
 
-void copy_datafile(int ifd, char *file)
+static void copy_datafile(int ifd, char *file)
 {
 	if (!file)
 		return;
-- 
2.50.1

[PATCH 4/8] tools: rkcommon: Mark rkcommon_is_header_v2() as static

[Ilias Apalodimas]

The function is only used locally. Enabling -Wmissing-prototypes
triggers a warning. Mark it as static.

Signed-off-by: Ilias Apalodimas <ilias.apalodimas@linaro.org>
---
 tools/rkcommon.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tools/rkcommon.c b/tools/rkcommon.c
index a0caa029cc04..d191ea72c633 100644
--- a/tools/rkcommon.c
+++ b/tools/rkcommon.c
@@ -279,7 +279,7 @@ bool rkcommon_need_rc4_spl(struct image_tool_params *params)
 	return info->spl_rc4;
 }
 
-bool rkcommon_is_header_v2(struct image_tool_params *params)
+static bool rkcommon_is_header_v2(struct image_tool_params *params)
 {
 	struct spl_info *info = rkcommon_get_spl_info(params->imagename);
 
-- 
2.50.1

[PATCH 5/8] tool: fit_info: Mark usage() as static

[Ilias Apalodimas]

The function is only used locally. Enabling -Wmissing-prototypes
triggers a warning. Mark it as static.

Signed-off-by: Ilias Apalodimas <ilias.apalodimas@linaro.org>
---
 tools/fit_info.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tools/fit_info.c b/tools/fit_info.c
index b2642ec5b763..c9e4236d09f5 100644
--- a/tools/fit_info.c
+++ b/tools/fit_info.c
@@ -26,7 +26,7 @@
 #include <image.h>
 #include <u-boot/crc.h>
 
-void usage(char *cmdname)
+static void usage(char *cmdname)
 {
 	fprintf(stderr, "Usage: %s -f fit file -n node -p property\n"
 			 "          -f ==> set fit file which is used'\n"
-- 
2.50.1

[PATCH 6/8] tools: fit_check_sign: Mark usage() as static

[Ilias Apalodimas]

The function is only used locally. Enabling -Wmissing-prototypes
triggers a warning. Mark it as static.

Signed-off-by: Ilias Apalodimas <ilias.apalodimas@linaro.org>
---
 tools/fit_check_sign.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tools/fit_check_sign.c b/tools/fit_check_sign.c
index 32d0fdb88295..ab3266aff204 100644
--- a/tools/fit_check_sign.c
+++ b/tools/fit_check_sign.c
@@ -23,7 +23,7 @@
 #include <image.h>
 #include <u-boot/crc.h>
 
-void usage(char *cmdname)
+static void usage(char *cmdname)
 {
 	fprintf(stderr, "Usage: %s -f fit file -k key file -c config name\n"
 			 "          -f ==> set fit file which should be checked'\n"
-- 
2.50.1

[PATCH 7/8] tools: imx8mimage: Mark build_image() as static

[Ilias Apalodimas]

The function is only used locally. Enabling -Wmissing-prototypes
triggers a warning. Mark it as static.

Signed-off-by: Ilias Apalodimas <ilias.apalodimas@linaro.org>
---
 tools/imx8mimage.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tools/imx8mimage.c b/tools/imx8mimage.c
index 0f24ba75c0fb..fe1aff35b4dd 100644
--- a/tools/imx8mimage.c
+++ b/tools/imx8mimage.c
@@ -475,7 +475,7 @@ static int generate_fspi_header (int ifd)
 }
 #endif
 
-void build_image(int ofd)
+static void build_image(int ofd)
 {
 	int file_off, header_hdmi_off = 0, header_image_off;
 
-- 
2.50.1

[PATCH 8/8] tools: imx8image: Mark imx8mimage_check_params() as static

[Ilias Apalodimas]

The function is only used locally. Enabling -Wmissing-prototypes
triggers a warning. Mark it as static.

Signed-off-by: Ilias Apalodimas <ilias.apalodimas@linaro.org>
---
 tools/imx8mimage.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tools/imx8mimage.c b/tools/imx8mimage.c
index fe1aff35b4dd..3e974923652d 100644
--- a/tools/imx8mimage.c
+++ b/tools/imx8mimage.c
@@ -49,7 +49,7 @@ static uint32_t get_cfg_value(char *token, char *name,  int linenr)
 	return value;
 }
 
-int imx8mimage_check_params(struct image_tool_params *params)
+static int imx8mimage_check_params(struct image_tool_params *params)
 {
 	return 0;
 }
-- 
2.50.1

Re: [PATCH 4/8] tools: rkcommon: Mark rkcommon_is_header_v2() as static

[Quentin Schulz]

Hi Ilias,

On 8/29/25 10:16 AM, Ilias Apalodimas wrote:
> The function is only used locally. Enabling -Wmissing-prototypes
> triggers a warning. Mark it as static.
> 
> Signed-off-by: Ilias Apalodimas <ilias.apalodimas@linaro.org>

Reviewed-by: Quentin Schulz <quentin.schulz@cherry.de>

Thanks!
Quentin