From mboxrd@z Thu Jan 1 00:00:00 1970 From: Joakim Tjernlund Date: Sat, 5 Apr 2008 19:31:33 +0200 Subject: [U-Boot-Users] [PATCH] Change env_get_char from a global function ptr to a function. In-Reply-To: <1206947724.7589.435.camel@gentoo-jocke.transmode.se> References: <20080330223308.A611E248BE@gemini.denx.de> <1206947724.7589.435.camel@gentoo-jocke.transmode.se> Message-ID: <024e01c89742$e48d4b80$ada7e280$@Tjernlund@transmode.se> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Did you try this one or did du skip it this release? Jocke On Mon, 2008-03-31 at 00:33 +0200, Wolfgang Denk wrote: > In message <1206911129.7589.411.camel@gentoo-jocke.transmode.se> you wrote: > > > > Just one step closer to full relocation of u-boot. Global variables > > before relocation to RAM is hard to deal with. Not sure if the code > > got smaller or not. > > Hm...there are some such variables. > > Did you compare sizes? I got the hint, thanks :) size before: text data bss dec hex filename 204117 13520 28716 246353 3c251 u-boot size after: text data bss dec hex filename 203893 13500 28716 246109 3c15d u-boot So it also got smaller by 244 bytes. Updated patch, with signoff and Jean-Christophe comment addressed. Jocke