From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id E484CEB64DD for ; Wed, 26 Jul 2023 01:24:07 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id BE747865B0; Wed, 26 Jul 2023 03:24:04 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=linux.alibaba.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Received: by phobos.denx.de (Postfix, from userid 109) id 435DB8638E; Wed, 26 Jul 2023 03:24:01 +0200 (CEST) Received: from out30-124.freemail.mail.aliyun.com (out30-124.freemail.mail.aliyun.com [115.124.30.124]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id D0ADC85E35 for ; Wed, 26 Jul 2023 03:23:56 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=linux.alibaba.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=hsiangkao@linux.alibaba.com X-Alimail-AntiSpam: AC=PASS; BC=-1|-1; BR=01201311R601e4; CH=green; DM=||false|; DS=||; FP=0|-1|-1|-1|0|-1|-1|-1; HT=ay29a033018046051; MF=hsiangkao@linux.alibaba.com; NM=1; PH=DS; RN=5; SR=0; TI=SMTPD_---0VoEZ.Vk_1690334630; Received: from 172.20.10.3(mailfrom:hsiangkao@linux.alibaba.com fp:SMTPD_---0VoEZ.Vk_1690334630) by smtp.aliyun-inc.com; Wed, 26 Jul 2023 09:23:51 +0800 Message-ID: <0257005d-015c-96f7-eae4-aa19ff999332@linux.alibaba.com> Date: Wed, 26 Jul 2023 09:23:48 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.13.0 Subject: Re: [PATCH] fs/erofs: Introduce new features including ztailpacking, fragments and dedupe To: Sam Edwards , Yifan Zhao , u-boot@lists.denx.de, Tom Rini Cc: jnhuang95@gmail.com References: <20230707155212.159914-1-zhaoyifan@sjtu.edu.cn> <5b20580e-f558-859f-6c63-20b11559a2cd@gmail.com> From: Gao Xiang In-Reply-To: <5b20580e-f558-859f-6c63-20b11559a2cd@gmail.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.8 at phobos.denx.de X-Virus-Status: Clean Hi Sam, On 2023/7/26 05:40, Sam Edwards wrote: > Hi folks, > > On 7/7/23 09:52, Yifan Zhao wrote: >> diff --git a/fs/erofs/internal.h b/fs/erofs/internal.h >> index 4af7c91560..433a3c6c1e 100644 >> --- a/fs/erofs/internal.h >> +++ b/fs/erofs/internal.h >> +/* make sure that any user of the erofs headers has at least 64bit off_t type */ >> +extern int erofs_assert_largefile[sizeof(off_t) - 8]; > > This assertion does not hold true on 32-bit platforms, and as a result this patch prevents building U-Boot on those systems with EROFS support enabled. Did you perhaps mean to use `erofs_off_t` (which is always 64-bit) somewhere that you're using `off_t` instead? > > I have had to revert this patch on my target, pending a solution for 32-bit users. Thanks for your report. I think this line could just be removed since it only impacts LFS APIs ["erofs-utils which uses _FILE_OFFSET_BITS=64"] directly: https://git.kernel.org/pub/scm/linux/kernel/git/xiang/erofs-utils.git/commit/?id=8b88487e20a8fb79942793d2bd8fe9bd2b15ba62 https://lore.kernel.org/all/20221215085842.130804-1-raj.khem@gmail.com/ But EROFS userspace internal implementation doesn't use off_t directly (instead it uses erofs_off_t as you said) nor u-boot interfaces (I think). Yifan, Could you submit a patch to remove this line? Thanks, Gao Xiang > > Thanks, > Sam