U-Boot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Leonard Anderweit <L.Anderweit@phytec.de>
To: "festevam@gmail.com" <festevam@gmail.com>,
	"sjg@chromium.org" <sjg@chromium.org>
Cc: "brian.ruley@gehealthcare.com" <brian.ruley@gehealthcare.com>,
	"marex@denx.de" <marex@denx.de>,
	"trini@konsulko.com" <trini@konsulko.com>,
	"ravi@prevas.dk" <ravi@prevas.dk>,
	"u-boot@lists.denx.de" <u-boot@lists.denx.de>,
	"paul.henrys_ext@softathome.com" <paul.henrys_ext@softathome.com>,
	"tharvey@gateworks.com" <tharvey@gateworks.com>
Subject: Re: [PATCH] binman: Fill in most of the imx8mimage and imx8mcst tests
Date: Mon, 31 Mar 2025 14:43:33 +0000	[thread overview]
Message-ID: <0261fb66f34d30c6fc3ea1995bf23d4a055dfb6b.camel@phytec.de> (raw)
In-Reply-To: <CAOMZO5ARze74UsOqUbMLfsyjfFcpBQ38hgqTZnrP4ZkqNOZiTQ@mail.gmail.com>

Hi,

Am Freitag, dem 28.03.2025 um 10:23 -0300 schrieb Fabio Estevam:
> Hi Simon,
> 
> On Fri, Mar 28, 2025 at 8:42 AM Simon Glass <sjg@chromium.org> wrote:
> 
> > Did you figure it out?
> > 
> > I'm not really sure. It works fine in my tree and I just tested it
> > now. Perhaps there are some other patches missing from Tom's tree?
> 
> Applying this patch causes the following CI error:
> 
> https://source.denx.de/u-boot/custodians/u-boot-imx/-/jobs/1079236
> 
> ======================== Running binman tests
> ========================
> 142..................................................................
> .....................................................................
> .....................................................................
> .............................................................Image
> 'image' has missing bintools and is non-functional: cst
> 143Some images are invalid
> 144......................................Image 'image' has missing
> bintools and is non-functional: cst
> 145Some images are invalid
> 146.........................................E........................
> .....................................................................
> .....................................................................
> ..............................s......................................
> .....
> 147==================================================================
> ====
> 148ERROR: binman.ftest.TestFunctional.testNxpImx8MCSTMkimageMissing
> (subunit.RemotedTestCase)
> 149binman.ftest.TestFunctional.testNxpImx8MCSTMkimageMissing
> 150------------------------------------------------------------------
> ----
> 151testtools.testresult.real._StringException: struct.error: unpack
> requires a buffer of 4 bytes
> 152==================================================================
> ====
> 153SKIP: binman.cbfs_util_test.TestCbfs.test_cbfstool_failure
> (subunit.RemotedTestCase)
> 154binman.cbfs_util_test.TestCbfs.test_cbfstool_failure
> 155------------------------------------------------------------------
> ----
> 156No cbfstool available
> 157------------------------------------------------------------------
> ----
> 158Ran 581 tests in 5.012s
> 159FAILED (errors=1, skipped=1)
> 
> What needs to be done to fix this error?

The error looks like binman is never building the missing tools.
Run something like:
./tools/binman/binman tool -f missing
before the binman tests.

This test setup uses .gitlab-ci.yml, right?

Leonard


  reply	other threads:[~2025-03-31 14:43 UTC|newest]

Thread overview: 31+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-01-05 20:36 [PATCH] binman: Fill in most of the imx8mimage and imx8mcst tests Marek Vasut
2025-01-06 14:38 ` Simon Glass
2025-01-06 20:50   ` Marek Vasut
2025-01-07  3:50     ` Simon Glass
2025-01-07 10:39       ` Marek Vasut
2025-01-09 14:10         ` Simon Glass
2025-01-10 11:02           ` Fabio Estevam
2025-02-05 10:19           ` Marek Vasut
2025-02-06 12:42             ` Simon Glass
2025-02-06 20:40               ` Marek Vasut
2025-02-07  0:49                 ` Simon Glass
2025-02-08 21:19                   ` Marek Vasut
2025-02-15 13:38                     ` Simon Glass
2025-02-15 14:55                       ` Marek Vasut
2025-03-06 23:30                         ` Simon Glass
2025-03-07  0:04                           ` Marek Vasut
2025-03-07  2:18                             ` Simon Glass
2025-03-07  5:42                               ` Marek Vasut
2025-03-12  0:41                                 ` Fabio Estevam
2025-03-19 23:54                                   ` Marek Vasut
2025-03-20  3:40                                     ` Simon Glass
2025-03-20  4:05                                       ` Marek Vasut
2025-03-28 11:42                                         ` Simon Glass
2025-03-28 13:23                                           ` Fabio Estevam
2025-03-31 14:43                                             ` Leonard Anderweit [this message]
2025-03-31 18:18                                               ` Fabio Estevam
2025-03-31 18:31                                                 ` Tom Rini
2025-05-05 12:28                                                   ` Fabio Estevam
2025-05-05 14:46                                                     ` Tom Rini
2025-03-30 22:11                                           ` Marek Vasut
2025-03-31  1:18                                             ` Simon Glass

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=0261fb66f34d30c6fc3ea1995bf23d4a055dfb6b.camel@phytec.de \
    --to=l.anderweit@phytec.de \
    --cc=brian.ruley@gehealthcare.com \
    --cc=festevam@gmail.com \
    --cc=marex@denx.de \
    --cc=paul.henrys_ext@softathome.com \
    --cc=ravi@prevas.dk \
    --cc=sjg@chromium.org \
    --cc=tharvey@gateworks.com \
    --cc=trini@konsulko.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox