From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.2 required=3.0 tests=BAYES_00,DKIM_ADSP_CUSTOM_MED, DKIM_INVALID,DKIM_SIGNED,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BD86AC4338F for ; Thu, 29 Jul 2021 10:40:51 +0000 (UTC) Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 2589960720 for ; Thu, 29 Jul 2021 10:40:51 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 2589960720 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=lists.denx.de Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 5C42C82C8B; Thu, 29 Jul 2021 12:40:49 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="noGATafa"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id A676B82E02; Thu, 29 Jul 2021 12:40:46 +0200 (CEST) Received: from mail-lf1-x12c.google.com (mail-lf1-x12c.google.com [IPv6:2a00:1450:4864:20::12c]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 6179382C8B for ; Thu, 29 Jul 2021 12:40:43 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=panfilov.artyom@gmail.com Received: by mail-lf1-x12c.google.com with SMTP id g13so10063152lfj.12 for ; Thu, 29 Jul 2021 03:40:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-transfer-encoding:content-language; bh=ukhd5xvhyQUt3rgs0hLeVaoFi0wfEZ3lBHTNQalqFwQ=; b=noGATafaAWEXi9hXRqA8ti59flnkBu/Hi1D1VFtHeoeao4MNz00rp0HLJX+GLPSdPn GDsZom/Ts/5Mu6RMJam04O5xM6zcH8nktCRW36B3ft6L+Tx9P3frWu48lP7kF9HDsVT/ 1vCWhTvbxCxQl7G0UWedJ8iiUCrY2i0RzF/uah9FVJT+v1Rsw4G/RWm9Y/YVJCSA3re4 mjm+RfJiyQdLjPMTfTaBZnXG6KyZONuHd+ogoGnQWIMaIezD/O9XsgnuZRqr8XIpyVmm BX+R9wDe3g0GVGkbSe7YH8+hQWNsk9QFo9uKBksOJ/OgBOKuncZTLirH+FkqMosUwBLx rXKA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:subject:to:cc:references:from:message-id :date:user-agent:mime-version:in-reply-to:content-transfer-encoding :content-language; bh=ukhd5xvhyQUt3rgs0hLeVaoFi0wfEZ3lBHTNQalqFwQ=; b=DcKOWJj1Scr8Hmzd6bZpyT96gPHG8JA6ayy6fcL8NLP4nXJOuRchSWJ/w1NVfrL2Ae wO/itQYG4PB+eFOZHj+nWeLfru56N3V4R44C0IQAakAzfmZvMlBkd2bhS2bJcgkzTScO z3H6ad8O+YNFeM8wZpIEXHr1HEjDYiYLUjlvA3tDYLoSgHcNfjokuQGchBId94+sztfO xNCJI5PT4BIrYbHSBhjwTXO6rquSabegkNJcGmAfXc4e6EowmWZ+Dee5WOnB1+bl07MV yn2fseT3Uin8EtDNEETi+YmNkG0MZJf2A2n0jmzvEUaz7FkwBw9/KHgPNp1UsmVs2wml 4vyQ== X-Gm-Message-State: AOAM532/qlxZLzk15SGI8n22e52L4cpKykBifhKdvd/gmJ+i59I7lJrB w0dTWveE6djb3/LFYFfvwKEvecaxzYAGYsbsF//D0g== X-Google-Smtp-Source: ABdhPJx24Xwj/h5Yf2GYK3Dg66iJhrW4wkAUJv6nSWCrhAp4bUGPNDm3+Yj19CHw8fTMkON2viwKyg== X-Received: by 2002:a05:6512:3e02:: with SMTP id i2mr3495986lfv.168.1627555242288; Thu, 29 Jul 2021 03:40:42 -0700 (PDT) Received: from [192.168.1.124] ([31.134.188.128]) by smtp.gmail.com with ESMTPSA id h1sm264842lfk.187.2021.07.29.03.40.41 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 29 Jul 2021 03:40:41 -0700 (PDT) Subject: Re: [PATCH 1/1] lib/ecdsa: Fix LibreSSL before v2.7.0 To: Tom Rini Cc: "Alex G." , "u-boot@lists.denx.de" References: <20210728181023.25067-1-panfilov.artyom@gmail.com> <21fa035a-7ab5-7045-dd47-90670eb8be14@gmail.com> <20210728200701.GY9379@bill-the-cat> <34cdf0ed-c97d-e5ec-31ff-24e4ca085c4d@gmail.com> <20210728225619.GB9379@bill-the-cat> <20210728234351.GI9379@bill-the-cat> From: Artem Panfilov Message-ID: <028916da-5e0f-36d2-29bb-dccf30cfcf91@gmail.com> Date: Thu, 29 Jul 2021 13:40:41 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.11.0 MIME-Version: 1.0 In-Reply-To: <20210728234351.GI9379@bill-the-cat> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 8bit Content-Language: en-US X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.34 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.2 at phobos.denx.de X-Virus-Status: Clean On 29.07.2021 02:43, Tom Rini wrote: > > Yes, true.  And that's two 1-line if/else.  That's a reasonable to me > level of effort to keep supporting older hosts.  Your patch is adding in > 60 lines.  I really do want to dig a bit more here. For me, it doesn't matter how many lines of code were added if I can't build host tools with older OpenSSL versions. So what's the point of keeping OpenSSL backward compatibility? > And honestly, part of my concerns also go around "who is going to > maintain / test this area?".  We don't have these older versions in CI > (or we would have seen the problem before merging).  Are you > volunteering to support the relevant code areas here but on older > openssl/libressl ? We already have a nightly Jenkins CI job that tracks u-boot master and sends internal reports. The best way would be to testing in the upstream azure pipeline. You could add the following steps in your trini/u-boot-gitlab-ci-runner docker image: wget -O - https://www.openssl.org/source/old/1.0.2/openssl-1.0.2k.tar.gz | tar -C /opt -xz && \ cd /opt/openssl-1.0.2k/ && ./config shared && \ make && \ make install In azure pipeline add new job for testing with old OpenSSL: make tools-only_config tools-only NO_SDL=1 \ HOSTLDFLAGS="-ldl -L/usr/local/ssl/lib" \ HOSTCFLAGS="-I/usr/local/ssl/include" --- Artem