From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E2B6DC07E96 for ; Tue, 6 Jul 2021 16:00:51 +0000 (UTC) Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 4A7C661879 for ; Tue, 6 Jul 2021 16:00:51 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 4A7C661879 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=runtimeterror.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 2713E82D92; Tue, 6 Jul 2021 18:00:47 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=runtimeterror.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Received: by phobos.denx.de (Postfix, from userid 109) id 4BE8982D92; Tue, 6 Jul 2021 18:00:45 +0200 (CEST) Received: from server242-5.web-hosting.com (server242-5.web-hosting.com [199.188.200.60]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 8184A82D8E for ; Tue, 6 Jul 2021 18:00:42 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=runtimeterror.com Authentication-Results: phobos.denx.de; spf=none smtp.mailfrom=badsector@runtimeterror.com Received: from ppp089044094226.access.hol.gr ([89.44.94.226]:59214 helo=[192.168.2.2]) by server242.web-hosting.com with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256 (Exim 4.94.2) (envelope-from ) id 1m0nUw-002SGn-Vm; Tue, 06 Jul 2021 12:00:39 -0400 Subject: Re: [RFC PATCH 05/28] cli: lil: Rename some functions to be more like TCL To: Tom Rini , Wolfgang Denk Cc: Sean Anderson , Simon Glass , U-Boot Mailing List , =?UTF-8?Q?Marek_Beh=c3=ban?= , Roland Gaudig , Heinrich Schuchardt References: <20210701061611.957918-1-seanga2@gmail.com> <20210701061611.957918-6-seanga2@gmail.com> <163753.1625507898@gemini.denx.de> <20210705185141.GA9516@bill-the-cat> <192285.1625557976@gemini.denx.de> <20210706153327.GS9516@bill-the-cat> From: Kostas Michalopoulos Message-ID: <02a88596-5442-b91c-b8c0-33b85ad43078@runtimeterror.com> Date: Tue, 6 Jul 2021 19:00:25 +0300 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.11.0 MIME-Version: 1.0 In-Reply-To: <20210706153327.GS9516@bill-the-cat> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-OutGoing-Spam-Status: No, score=-1.0 X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - server242.web-hosting.com X-AntiAbuse: Original Domain - lists.denx.de X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - runtimeterror.com X-Get-Message-Sender-Via: server242.web-hosting.com: authenticated_id: badsector@runtimeterror.com X-Authenticated-Sender: server242.web-hosting.com: badsector@runtimeterror.com X-Source: X-Source-Args: X-Source-Dir: X-From-Rewrite: unmodified, already matched X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.34 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.2 at phobos.denx.de X-Virus-Status: Clean On 7/6/2021 6:33 PM, Tom Rini wrote: >> Mature? And still without consequent error checking? And done, >> i. e. this will never be fixed? > > Intentional design by upstream, and then for the actual problem part > (error checking, test suite), Sean is saying he'll fix it, and has > started on it. To clarify, the intentional design aspect is for the language (e.g. giving garbage to "expr"). The library does need better memory alloc checks (this is the main thing missing because i never had to use LIL on an environment without virtual memory... or where malloc would ever practically fail), though IIRC there aren't any other cases where failure could happen and isn't checked. Similarly i do plan on implementing a proper test suite (currently there is a shell script that runs all the examples in the source code - many examples were made to expose previous bugs - with two different implementations which can be used to find regressions in subsequent releases and differences between implementations, but the examples do not exhaust the code paths the parser could take) at some point - the latter is more likely to happen soon than the former. The same applies with LIL being "done" (well, mostly done) - this is about the language, not the implementation which (as i mentioned in another email) does need improvements, especially around performance (which is also a reason i need to implement better automated tests). Kostas