[PATCH] board: rpi: Change from CONFIG_ARM64 to CONFIG_PHYS_64BIT

[PATCH] board: rpi: Change from CONFIG_ARM64 to CONFIG_PHYS_64BIT

[Jaehoon Chung]

initrd_high is dependent with CONFIG_PHYS_64BIT configuration.
Even though CONFIG_ARM64 is not enabled, CONFIG_PHYS_64BIT can be
enabled.

Signed-off-by: Jaehoon Chung <jh80.chung@samsung.com>
---
 board/raspberrypi/rpi/rpi.env | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/board/raspberrypi/rpi/rpi.env b/board/raspberrypi/rpi/rpi.env
index 30228285edde..47529b0b7a68 100644
--- a/board/raspberrypi/rpi/rpi.env
+++ b/board/raspberrypi/rpi/rpi.env
@@ -61,7 +61,7 @@ dfu_alt_info+=zImage fat 0 1
  * only 64M, the remaining 25M starting at 0x02700000 should allow quite
  * large initrds before they start colliding with U-Boot.
  */
-#ifdef CONFIG_ARM64
+#ifdef CONFIG_PHYS_64BIT
 fdt_high=ffffffffffffffff
 initrd_high=ffffffffffffffff
 #else
-- 
2.25.1

Re: [PATCH] board: rpi: Change from CONFIG_ARM64 to CONFIG_PHYS_64BIT

[Tom Rini]

[-- Attachment #1: Type: text/plain, Size: 1013 bytes --]

On Wed, Nov 06, 2024 at 07:19:36AM +0900, Jaehoon Chung wrote:
> initrd_high is dependent with CONFIG_PHYS_64BIT configuration.
> Even though CONFIG_ARM64 is not enabled, CONFIG_PHYS_64BIT can be
> enabled.
> 
> Signed-off-by: Jaehoon Chung <jh80.chung@samsung.com>
> ---
>  board/raspberrypi/rpi/rpi.env | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/board/raspberrypi/rpi/rpi.env b/board/raspberrypi/rpi/rpi.env
> index 30228285edde..47529b0b7a68 100644
> --- a/board/raspberrypi/rpi/rpi.env
> +++ b/board/raspberrypi/rpi/rpi.env
> @@ -61,7 +61,7 @@ dfu_alt_info+=zImage fat 0 1
>   * only 64M, the remaining 25M starting at 0x02700000 should allow quite
>   * large initrds before they start colliding with U-Boot.
>   */
> -#ifdef CONFIG_ARM64
> +#ifdef CONFIG_PHYS_64BIT
>  fdt_high=ffffffffffffffff
>  initrd_high=ffffffffffffffff
>  #else

We really need to drop both of those _high variables in all cases and
set some reasonable bootm_size

-- 
Tom

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 659 bytes --]

RE: [PATCH] board: rpi: Change from CONFIG_ARM64 to CONFIG_PHYS_64BIT

[Jaehoon Chung]

> -----Original Message-----
> From: Tom Rini <trini@konsulko.com>
> Sent: Wednesday, November 6, 2024 7:39 AM
> To: Jaehoon Chung <jh80.chung@samsung.com>
> Cc: u-boot@lists.denx.de; mbrugger@suse.com; pbrobinson@gmail.com
> Subject: Re: [PATCH] board: rpi: Change from CONFIG_ARM64 to CONFIG_PHYS_64BIT
>
> On Wed, Nov 06, 2024 at 07:19:36AM +0900, Jaehoon Chung wrote:
> > initrd_high is dependent with CONFIG_PHYS_64BIT configuration.
> > Even though CONFIG_ARM64 is not enabled, CONFIG_PHYS_64BIT can be
> > enabled.
> >
> > Signed-off-by: Jaehoon Chung <jh80.chung@samsung.com>
> > ---
> >  board/raspberrypi/rpi/rpi.env | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/board/raspberrypi/rpi/rpi.env b/board/raspberrypi/rpi/rpi.env
> > index 30228285edde..47529b0b7a68 100644
> > --- a/board/raspberrypi/rpi/rpi.env
> > +++ b/board/raspberrypi/rpi/rpi.env
> > @@ -61,7 +61,7 @@ dfu_alt_info+=zImage fat 0 1
> >   * only 64M, the remaining 25M starting at 0x02700000 should allow quite
> >   * large initrds before they start colliding with U-Boot.
> >   */
> > -#ifdef CONFIG_ARM64
> > +#ifdef CONFIG_PHYS_64BIT
> >  fdt_high=ffffffffffffffff
> >  initrd_high=ffffffffffffffff
> >  #else
>
> We really need to drop both of those _high variables in all cases and
> set some reasonable bootm_size

To change some reasonable bootm_size, it needs to know the corresponding reasonable value for each SoC.
I can't change and drop all _high variables in all cases now.
In RPI, I will check reasonable bootm_size and update it.

Best Regards,
Jaehoon Chung

>
> --
> Tom