From: Michal Simek <michal.simek@amd.com>
To: <u-boot@lists.denx.de>, <git@xilinx.com>
Cc: Simon Glass <sjg@chromium.org>
Subject: Re: [PATCH] dm: core: ofnode: Fix error message in ofnode_read_bootscript_address/flash()
Date: Mon, 18 Sep 2023 11:09:23 +0200 [thread overview]
Message-ID: <02fe4f02-0475-44db-901a-1be43de8afcc@amd.com> (raw)
In-Reply-To: <ff62e980237ab271cf05facfbc306e85914a8c6e.1694438999.git.michal.simek@amd.com>
On 9/11/23 15:30, Michal Simek wrote:
> Missing u-boot node shouldn't be visible in bootlog without debug enabled
> that's why change message from printf to debug.
>
> Signed-off-by: Michal Simek <michal.simek@amd.com>
> ---
>
> drivers/core/ofnode.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/core/ofnode.c b/drivers/core/ofnode.c
> index 2d82f38db36d..df2d7fdd535c 100644
> --- a/drivers/core/ofnode.c
> +++ b/drivers/core/ofnode.c
> @@ -1603,7 +1603,7 @@ int ofnode_read_bootscript_address(u64 *bootscr_address, u64 *bootscr_offset)
>
> uboot = ofnode_path("/options/u-boot");
> if (!ofnode_valid(uboot)) {
> - printf("%s: Missing /u-boot node\n", __func__);
> + debug("%s: Missing /u-boot node\n", __func__);
> return -EINVAL;
> }
>
> @@ -1629,7 +1629,7 @@ int ofnode_read_bootscript_flash(u64 *bootscr_flash_offset,
>
> uboot = ofnode_path("/options/u-boot");
> if (!ofnode_valid(uboot)) {
> - printf("%s: Missing /u-boot node\n", __func__);
> + debug("%s: Missing /u-boot node\n", __func__);
> return -EINVAL;
> }
>
It is only called for our platform right that's why I will take it via my tree
where origin patch is.
Applied.
Thanks,
Michal
prev parent reply other threads:[~2023-09-18 9:09 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-11 13:30 [PATCH] dm: core: ofnode: Fix error message in ofnode_read_bootscript_address/flash() Michal Simek
2023-09-18 9:09 ` Michal Simek [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=02fe4f02-0475-44db-901a-1be43de8afcc@amd.com \
--to=michal.simek@amd.com \
--cc=git@xilinx.com \
--cc=sjg@chromium.org \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox