From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id AE324C4332F for ; Wed, 12 Oct 2022 15:21:25 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 459D084DFB; Wed, 12 Oct 2022 17:21:23 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="Nj+lR1vi"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id C633084E44; Wed, 12 Oct 2022 17:21:20 +0200 (CEST) Received: from mail-ed1-x533.google.com (mail-ed1-x533.google.com [IPv6:2a00:1450:4864:20::533]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 5858B84DB6 for ; Wed, 12 Oct 2022 17:21:18 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=ovpanait@gmail.com Received: by mail-ed1-x533.google.com with SMTP id z97so24932143ede.8 for ; Wed, 12 Oct 2022 08:21:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=Gyg30NvBen6TCfXQHf7lzbvnfhijnZybz3Xsrp6yosA=; b=Nj+lR1viMmusW71zYbL9eholv1S4MXPAKOE3gEFMezNwPL8zf7nTERDV2h1gbWb2Xm CP8lM+8pzIiADjq01tn0Vg40mZuk1/0xZHJLRJQd6Yhdjq2bxqqc7R2tef5Opk8oY23/ ZBfZJurxYXmcrJfdn8D7uqGrQMGvn8NiPT+nPnvdhqpV4ugJ2uin2lDZ33WXkxgTFxPq a8Ujog+t1QlzwNJh3prD8KrCmQM5OAaU5cmeFjy4gkVeDw9nDUvf6p/07e2bmNIybCkh 1voaw9ZeAwWQ8sAAMgio3JD9npzPXCMweaTnZPIPJBVN+61246cDFH2BUW6GLh+GKVkP WpqA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=Gyg30NvBen6TCfXQHf7lzbvnfhijnZybz3Xsrp6yosA=; b=FTONpt08uPTEMqMG1mruGwtb3VGe2h6GzFgmQ4o0PQ9guvsnf3l3nOEshhvzc2X7aE cCSp5S1hwCNr7EFX79sSxS99bTsB5zVlVtfsz54I3CRuCfDXwJbl+eY9XeYPDRZ3Wrma wFDwpAcNqMdE52IEn+o005Sp+YUdi/uinN+Eg0SHtoKKxzfR00mC4b4bEHfzDY3kQSlr /MYrq54AtiPfcmC5qJiBKqns51cdhnWypMTVyRWKfESRzXM196zHz+NaMS/EIPUBUIc8 IMLnduEMQIMibeNwOsQlmFBKvO4oSC9ygQglHVZLSDIjbaDWtGTw3leSVacfSuOizbxv sTAQ== X-Gm-Message-State: ACrzQf1fHEvushinqPeB+TQ7J+oT6uEY1nMics47Htq09V34BNFpEvQo Z0iHT/YSF+cQxHKn8FUayqs= X-Google-Smtp-Source: AMsMyM5IbFe0vRvjXq0Hr+ix/WbDKH5YKpFM/aJ37PwbeMiCqGvaiZiezf9cX/DHpzz3/rrTHSEQsA== X-Received: by 2002:a05:6402:847:b0:45b:d50c:b9aa with SMTP id b7-20020a056402084700b0045bd50cb9aamr20181976edz.289.1665588077894; Wed, 12 Oct 2022 08:21:17 -0700 (PDT) Received: from ?IPV6:2a02:2f0e:ca15:2800:c696:dfd3:f393:fcf7? ([2a02:2f0e:ca15:2800:c696:dfd3:f393:fcf7]) by smtp.gmail.com with ESMTPSA id l25-20020a50d6d9000000b0045723aa48ccsm11344403edj.93.2022.10.12.08.21.16 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 12 Oct 2022 08:21:17 -0700 (PDT) Message-ID: <032f6631-fd52-a0ec-03d8-d56d45875bd0@gmail.com> Date: Wed, 12 Oct 2022 18:21:15 +0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.2.2 Subject: Re: [PATCH 2/3] timer-uclass: relocate ops pointers for CONFIG_NEEDS_MANUAL_RELOC Content-Language: en-US To: Simon Glass Cc: u-boot@lists.denx.de, Andy Shevchenko , Patrice Chotard References: <20221012053656.1492457-1-ovpanait@gmail.com> <20221012053656.1492457-2-ovpanait@gmail.com> From: Ovidiu Panait In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.6 at phobos.denx.de X-Virus-Status: Clean Hi Simon, On 10/12/22 15:59, Simon Glass wrote: > On Tue, 11 Oct 2022 at 23:37, Ovidiu Panait wrote: >> Relocate timer_ops pointers when CONFIG_NEEDS_MANUAL_RELOC is enabled. >> >> The (gd->flags & GD_FLG_RELOC) check was added to make sure the reloc_done >> logic works for drivers that use DM_FLAG_PRE_RELOC. >> >> Signed-off-by: Ovidiu Panait >> --- >> >> drivers/timer/timer-uclass.c | 14 ++++++++++++++ >> 1 file changed, 14 insertions(+) > Reviewed-by: Simon Glass > > Which (broken) toolchain are you using? Microblaze and m68k still use CONFIG_NEEDS_MANUAL_RELOC=y by default. I was testing on microblaze. Ovidiu