From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id E1776C6FD19 for ; Mon, 13 Mar 2023 05:41:40 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id B6E9A85BFE; Mon, 13 Mar 2023 06:41:38 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=samsung.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=samsung.com header.i=@samsung.com header.b="BLguJaF8"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id CCD2084460; Mon, 13 Mar 2023 06:41:36 +0100 (CET) Received: from mailout2.samsung.com (mailout2.samsung.com [203.254.224.25]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 4314684460 for ; Mon, 13 Mar 2023 06:41:31 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=samsung.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=jh80.chung@samsung.com Received: from epcas1p4.samsung.com (unknown [182.195.41.48]) by mailout2.samsung.com (KnoxPortal) with ESMTP id 20230313054126epoutp028953ed9773b49cbffda220c276ca1202~L5BoBqfZH2106021060epoutp02G for ; Mon, 13 Mar 2023 05:41:26 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 mailout2.samsung.com 20230313054126epoutp028953ed9773b49cbffda220c276ca1202~L5BoBqfZH2106021060epoutp02G DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=samsung.com; s=mail20170921; t=1678686086; bh=sMeKpJkzemFpDyZX3ziZx1CCgTgZ7dgTTks6fZr2p3c=; h=From:To:Cc:In-Reply-To:Subject:Date:References:From; b=BLguJaF8W7Z91AUopQ4ZoUh31+BLVQgu9GJAehGbhmDouxWE0CvZBR1BiZ0TwJxkl HoHr+1RpPQBZVoZ3dEFdUhOAcHpPXJxm+uaOAbm4/xSfuGjHghTsppCXV/gCLQFvs0 0Sbmt8wwhfG4T3Gsk/RAxojq8eb+Wf4cmJcDsa34= Received: from epsnrtp2.localdomain (unknown [182.195.42.163]) by epcas1p4.samsung.com (KnoxPortal) with ESMTP id 20230313054126epcas1p479c2d3405c41bf980244bb98ce9ec33c~L5Bn2t-hT0891008910epcas1p46; Mon, 13 Mar 2023 05:41:26 +0000 (GMT) Received: from epsmges1p5.samsung.com (unknown [182.195.36.132]) by epsnrtp2.localdomain (Postfix) with ESMTP id 4PZlrj2gj6z4x9Pt; Mon, 13 Mar 2023 05:41:25 +0000 (GMT) Received: from epcas1p3.samsung.com ( [182.195.41.47]) by epsmges1p5.samsung.com (Symantec Messaging Gateway) with SMTP id DD.16.54823.587BE046; Mon, 13 Mar 2023 14:41:25 +0900 (KST) Received: from epsmtrp2.samsung.com (unknown [182.195.40.14]) by epcas1p2.samsung.com (KnoxPortal) with ESMTPA id 20230313054125epcas1p269c59fcede75dfbfc230b74cfe6208d7~L5BmuGcOl1766217662epcas1p2h; Mon, 13 Mar 2023 05:41:25 +0000 (GMT) Received: from epsmgms1p2.samsung.com (unknown [182.195.42.42]) by epsmtrp2.samsung.com (KnoxPortal) with ESMTP id 20230313054125epsmtrp2badc5655738853dc66c86262efdb3b61~L5Bms6N1D1664916649epsmtrp2P; Mon, 13 Mar 2023 05:41:25 +0000 (GMT) X-AuditID: b6c32a39-a97ff7000000d627-19-640eb785a63e Received: from epsmtip1.samsung.com ( [182.195.34.30]) by epsmgms1p2.samsung.com (Symantec Messaging Gateway) with SMTP id A6.2A.31821.487BE046; Mon, 13 Mar 2023 14:41:24 +0900 (KST) Received: from jh80chung01 (unknown [10.113.111.84]) by epsmtip1.samsung.com (KnoxPortal) with ESMTPA id 20230313054124epsmtip13599253e103df3b471478288b7d9f963~L5BmfYFNU2874228742epsmtip1f; Mon, 13 Mar 2023 05:41:24 +0000 (GMT) From: "Jaehoon Chung" To: "'Henrik Grimler'" Cc: , , , , <~postmarketos/upstreaming@lists.sr.ht> In-Reply-To: Subject: RE: [PATCH 1/2] Revert "mmc: s5p_sdhci: unset the SDHCI_QUIRK_BROKEN_R1B" Date: Mon, 13 Mar 2023 14:41:24 +0900 Message-ID: <03cf01d9556e$72f606b0$58e21410$@samsung.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Mailer: Microsoft Outlook 16.0 Thread-Index: AQHkOZh4jCdKDKBJqoWT7EpekMFBTwGRpy3TAld6/k8CeT8ArgHBvapKrqFIatA= Content-Language: ko X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFprNJsWRmVeSWpSXmKPExsWy7bCmvm7rdr4UgwVzhCzeLtnFaPFy5W9W ix+rvrBafNuyjdHi7d5OdovN3/8yOrB5zG64yOLxo/U9m8fRK/dYPc7e2cHo8f/OWnaPje92 MAWwRWXbZKQmpqQWKaTmJeenZOal2yp5B8c7x5uaGRjqGlpamCsp5CXmptoqufgE6Lpl5gDd oaRQlphTChQKSCwuVtK3synKLy1JVcjILy6xVUotSMkpMC3QK07MLS7NS9fLSy2xMjQwMDIF KkzIzpj4YhVrwX+5io55HxgbGGdIdjFyckgImEhMWHeerYuRi0NIYAejxPHpe5ggnE+MEt+f z2eBcD4zSsxtfMAI07Lp5C1miMQuRomrd19BOS8ZJebdu8gGUsUmoCfxf9FCZhBbREBLYuqG D2BFzAINjBKzZmwDWsLBwSmgLrFyjipIjbBAiMTyriZWEJtFQFXi1KnXLCA2r4ClRNun86wQ tqDEyZlPwOLMAvIS29/OYYa4SEHi59NlrBC7/CSuzXzOCFEjIjG7sw1sr4TATA6Jjjv3oBpc JB49Ws4GYQtLvDq+hR3ClpL4/G4vG0RDM6PE0iUHWSGcHkaJfw3XoTqMJfYvnQz2AbOApsT6 XfoQYUWJnb/nQm3mk3j3tYcVpERCgFeio00IokRF4tLrl0wwu+4++c86gVFpFpLfZiH5bRaS H2YhLFvAyLKKUSy1oDg3PbXYsMAUHt/J+bmbGMGpVMtyB+P0tx/0DjEycTAeYpTgYFYS4d3C z5MixJuSWFmVWpQfX1Sak1p8iNEUGNoTmaVEk/OByTyvJN7QxNLAxMzI2MTC0MxQSZxX3PZk spBAemJJanZqakFqEUwfEwenVAMTaxXTCh/Ld4VPVnk/k2ZsuSO6w3AHo9ehd0Yxhqk+1X9C FRtYa+suLjZ4w1zcF9Afk3NA5bSt3z87sUkL+B4KhbxQPrF4l4+T3My+p14JeeuXF7C5dN3z ZJozl+MyTzbfoditB7/f2PNLSu+yR533YgOh/buOJt04asnz2do98gWjrVvUS7vIx+kbX72Y 9JAjtVpJtq58/8S2cyZt6qXRyn/nfH/y2K7x5A+j5Y+P8K6zrVr5M9lbSHzXJv3XL8/tiXbn uCPGvCfFP4G5/JBIwmnDlqKkqkqpvYpBNmFcX/tNPCaeFOyMXHYu3CeYLfzC7Jx0Ppm/ttY2 irVMSx987hJuM5Q1u6y41EBqsRJLcUaioRZzUXEiAITHxDwuBAAA X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFmpkkeLIzCtJLcpLzFFi42LZdlhJTrdlO1+KQd9kS4u3S3YxWrxc+ZvV 4seqL6wW37ZsY7R4u7eT3WLz97+MDmwesxsusnj8aH3P5nH0yj1Wj7N3djB6/L+zlt1j47sd TAFsUVw2Kak5mWWpRfp2CVwZE1+sYi34L1fRMe8DYwPjDMkuRk4OCQETiU0nbzGD2EICOxgl 5j+JhohLSXx+OpWti5EDyBaWOHy4uIuRC6jkOaPE2ZcH2EFq2AT0JP4vWgjWKyKgJTF1wwdm kCJmgTZGiee35zNCdPxhlDhwbwrYJE4BdYmVc1RBGoQFgiQerVvNCGKzCKhKnDr1mgXE5hWw lGj7dJ4VwhaUODnzCQtIKzPQsraNYOXMAvIS29/OYYa4U0Hi59NlrBA3+Elcm/kcqkZEYnZn G/MERuFZSCbNQpg0C8mkWUg6FjCyrGKUTC0ozk3PLTYsMMpLLdcrTswtLs1L10vOz93ECI4l La0djHtWfdA7xMjEwXiIUYKDWUmEdws/T4oQb0piZVVqUX58UWlOavEhRmkOFiVx3gtdJ+OF BNITS1KzU1MLUotgskwcnFINTLHuO+WuXJuucG3WwSunA3UEBU9NeXHJtXOL9PvMkyerCiP+ HRN/NMf518ug6qqOgDI3HvWET6ILPv2aa9QxuU1sT1/kp8hEhvDp3WLdLaLeTHxnBLN09jdN vaBXufzu7Bhbw+ILh4LrO24kl0/S21vdpHfHz+aukG5haZ6D8CZO1fYJ/oLlrF4bT07aFl4V cF9qW1uY0oeKlxsrZnc7++7Lain1aJ5U9PHGufjzqSwX786Q2b5liZd0d1Nn6Nr/+hwfplm3 W8sXqCxOuHf4f7XtjIMn8y6sV0+wi2R7rWZ/eMuJKo8zlsvcwvbWqjmIfZy1JIpdbi6Pj/1B HiuGXpNyKb4e5S3LFJqW1gcrsRRnJBpqMRcVJwIAfAeWNBQDAAA= X-CMS-MailID: 20230313054125epcas1p269c59fcede75dfbfc230b74cfe6208d7 X-Msg-Generator: CA Content-Type: text/plain; charset="utf-8" X-Sendblock-Type: SVC_REQ_APPROVE CMS-TYPE: 101P DLP-Filter: Pass X-CFilter-Loop: Reflected X-CMS-RootMailID: 20230208190520epcas1p371eade560ed81d9e53d51c6f88585e7b References: <20230208190421.62661-1-henrik@grimler.se> <20230208190421.62661-2-henrik@grimler.se> <000901d93ce2$b28c12a0$17a437e0$@samsung.com> X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.8 at phobos.denx.de X-Virus-Status: Clean Hi Henrik, > -----Original Message----- > From: Henrik Grimler > Sent: Saturday, March 11, 2023 7:32 PM > To: Jaehoon Chung > Cc: joost@diskos.nl; peng.fan@nxp.com; andy.wu@sony.com; sjg@chromium.org; u-boot@lists.denx.de; > ~postmarketos/upstreaming@lists.sr.ht > Subject: Re: [PATCH 1/2] Revert "mmc: s5p_sdhci: unset the SDHCI_QUIRK_BROKEN_R1B" > > Hi Jaehoon, > > On Fri, Feb 10, 2023 at 09:00:33AM +0900, Jaehoon Chung wrote: > > Hi, > > > > > -----Original Message----- > > > From: U-Boot On Behalf Of Henrik Grimler > > > Sent: Thursday, February 9, 2023 4:04 AM > > > To: joost@diskos.nl; jh80.chung@gmail.com; andy.wu@sony.com; sjg@chromium.org; > > > m.szyprowski@samsung.com; u-boot@lists.denx.de; ~postmarketos/upstreaming@lists.sr.ht > > > Cc: Henrik Grimler > > > Subject: [PATCH 1/2] Revert "mmc: s5p_sdhci: unset the SDHCI_QUIRK_BROKEN_R1B" > > > > > > This reverts commit a034ec06ff1d558bbe11d5ee05edbb4de3ee2215. > > > > > > Commit 4a3ea75de4c5 ("Revert "mmc: sdhci: set to INT_DATA_END when > > > there are data"") reverted the alternative fix that was added for > > > Exynos 4 devices, causing an error when trying to boot from an sdcard: > > > > > > <...> > > > Loading Environment from MMC... sdhci_send_command: Timeout for status update! > > > mmc fail to send stop cmd > > > <...> > > > > Thanks for sharing issue. > > > > I will check this on Exynos Board. Frankly, I hope not to re-add QUIRK. > > Because it was verified that it was working fine without SDHCI_QUIKR_BROKEN_RIB. > > Just wondering if you have had an opportunity to test this on any of > your devices? You can find v2 here, though this patch had no changes: > https://protect2.fireeye.com/v1/url?k=f02940b0-91a25586-f028cbff-74fe485fffe0- > 524f6754708289dd&q=1&e=39932d75-a824-41c5-a3b2- > d9b467bd34a8&u=https%3A%2F%2Flists.denx.de%2Fpipermail%2Fu-boot%2F2023-February%2F508928.html I have found what you faced. U-Boot 2023.04-rc3-00265-gbcf343146ff3-dirty (Mar 13 2023 - 14:35:43 +0900) CPU: Exynos4412 @ 1 GHz Model: Odroid based on Exynos4412 Type: u3 DRAM: 2 GiB Core: 101 devices, 12 uclasses, devicetree: separate LDO20@VDDQ_EMMC_1.8V: set 1800000 uV; enabling LDO22@VDDQ_EMMC_2.8V: set 2800000 uV; enabling LDO21@TFLASH_2.8V: set 2800000 uV; enabling MMC: SAMSUNG SDHCI: 2, EXYNOS DWMMC: 0 Loading Environment from MMC... sdhci_send_command: Timeout for status update! mmc fail to send stop cmd sdhci_send_command: Timeout for status update! mmc fail to send stop cmd ** fs_devread read error - block sdhci_send_command: Timeout for status update! mmc fail to send stop cmd *** Warning - !read failed, using default environment I'm checking yours on my u3 board. I will reply today. Sorry for too late. Best Regards, Jaehoon Chung > > > Best Regards, > > Jaehoon Chung > > Best regards, > Henrik Grimler > > > > > > > Re-add the quirk to allow booting from sdcards again. > > > > > > Signed-off-by: Henrik Grimler > > > --- > > > drivers/mmc/s5p_sdhci.c | 2 +- > > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > > > diff --git a/drivers/mmc/s5p_sdhci.c b/drivers/mmc/s5p_sdhci.c > > > index dee84263c3fd..3b74feae68c7 100644 > > > --- a/drivers/mmc/s5p_sdhci.c > > > +++ b/drivers/mmc/s5p_sdhci.c > > > @@ -90,7 +90,7 @@ static int s5p_sdhci_core_init(struct sdhci_host *host) > > > host->name = S5P_NAME; > > > > > > host->quirks = SDHCI_QUIRK_NO_HISPD_BIT | SDHCI_QUIRK_BROKEN_VOLTAGE | > > > - SDHCI_QUIRK_32BIT_DMA_ADDR | > > > + SDHCI_QUIRK_BROKEN_R1B | SDHCI_QUIRK_32BIT_DMA_ADDR | > > > SDHCI_QUIRK_WAIT_SEND_CMD | SDHCI_QUIRK_USE_WIDE8; > > > host->max_clk = 52000000; > > > host->voltages = MMC_VDD_32_33 | MMC_VDD_33_34 | MMC_VDD_165_195; > > > -- > > > 2.30.2 > > > >