From: Stephan Linz <linz@mazet.de>
To: u-boot@lists.denx.de
Subject: [U-Boot-Users] Re: [PATCH] Nios: WATCHDOG preparation
Date: Mon, 16 Feb 2004 11:07:32 +0100 [thread overview]
Message-ID: <0402161107320B.00467@pcj86> (raw)
In-Reply-To: <20040216093015.BEFF0C1096@atlas.denx.de>
> --snip--
>
> > @@ -1174,7 +1175,11 @@ static void smc_write_phy_register (byte
> > #ifndef CONFIG_SMC91111_EXT_PHY
> > static void smc_wait_ms(unsigned int ms)
> > {
> > + /* B E W A R N E D :
> > + * DON'T EXCEED YOUR WATCHDOG TIMOUT WITH ARGUMENT 'ms' */
> > + WATCHDOG_RESET ();
> > udelay(ms*1000);
> > + WATCHDOG_RESET ();
>
> This should never be necessary. The udelay() function itself is
> expected to trigger the waitchdog as necessary.
>
> If this is not the case on NIOS, then please fix this first. It might
> make some more of your modifications redundand, too.
Hu, you're right. It isn't the case on NIOS. OK, I'll fix it up and try out
this afternoon. You'll get a new patch tomorrow.
Best regards,
Stephan Linz
next prev parent reply other threads:[~2004-02-16 10:07 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-02-16 9:09 [U-Boot-Users] [PATCH] Nios: WATCHDOG preparation Stephan Linz
2004-02-16 9:30 ` [U-Boot-Users] " Wolfgang Denk
2004-02-16 10:07 ` Stephan Linz [this message]
2004-02-17 17:34 ` [U-Boot-Users] " Stephan Linz
2004-02-23 23:19 ` [U-Boot-Users] " Wolfgang Denk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0402161107320B.00467@pcj86 \
--to=linz@mazet.de \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox