From mboxrd@z Thu Jan  1 00:00:00 1970
From: Stephan Linz <linz@mazet.de>
Date: Mon, 16 Feb 2004 11:07:32 +0100
Subject: [U-Boot-Users] Re: [PATCH] Nios: WATCHDOG preparation
In-Reply-To: <20040216093015.BEFF0C1096@atlas.denx.de>
References: <20040216093015.BEFF0C1096@atlas.denx.de>
Message-ID: <0402161107320B.00467@pcj86>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

> --snip--
>
> > @@ -1174,7 +1175,11 @@ static void smc_write_phy_register (byte
> >  #ifndef CONFIG_SMC91111_EXT_PHY
> >  static void smc_wait_ms(unsigned int ms)
> >  {
> > +	/* B E   W A R N E D :
> > +	 * DON'T EXCEED YOUR WATCHDOG TIMOUT WITH ARGUMENT 'ms' */
> > +	WATCHDOG_RESET ();
> >  	udelay(ms*1000);
> > +	WATCHDOG_RESET ();
>
> This should never be  necessary.  The  udelay()  function  itself  is
> expected to trigger the waitchdog as necessary.
>
> If this is not the case on NIOS, then please fix this first. It might
> make some more of your modifications redundand, too.

Hu, you're right. It isn't the case on NIOS. OK, I'll fix it up and try out 
this afternoon. You'll get a new patch tomorrow.


Best regards,
Stephan Linz