* [U-Boot-Users] [patch] MicroBlaze port of U-Boot
@ 2004-04-06 19:40 Yasushi SHOJI
2004-04-07 7:09 ` Stephan Linz
2004-04-18 21:06 ` Wolfgang Denk
0 siblings, 2 replies; 8+ messages in thread
From: Yasushi SHOJI @ 2004-04-06 19:40 UTC (permalink / raw)
To: u-boot
Hello all,
Here is a patch against the current CVS for microblaze port of
u-boot. I does nothing but boot itself, but this can be a start.
Suggestions, thoughts, and comments are welcome, of course.
best regards,
--
yashi
-------------- next part --------------
A non-text attachment was scrubbed...
Name: u-boot-suzaku.patch.gz
Type: application/octet-stream
Size: 18197 bytes
Desc: not available
Url : http://lists.denx.de/pipermail/u-boot/attachments/20040407/7f4d8b4e/attachment.obj
^ permalink raw reply [flat|nested] 8+ messages in thread* [U-Boot-Users] [patch] MicroBlaze port of U-Boot 2004-04-06 19:40 [U-Boot-Users] [patch] MicroBlaze port of U-Boot Yasushi SHOJI @ 2004-04-07 7:09 ` Stephan Linz 2004-04-07 11:19 ` Yasushi SHOJI 2004-04-18 21:06 ` Wolfgang Denk 1 sibling, 1 reply; 8+ messages in thread From: Stephan Linz @ 2004-04-07 7:09 UTC (permalink / raw) To: u-boot Am Dienstag, 6. April 2004 21:40 schrieb Yasushi SHOJI: > Hello all, > > Here is a patch against the current CVS for microblaze port of > u-boot. I does nothing but boot itself, but this can be a start. > > Suggestions, thoughts, and comments are welcome, of course. > > best regards, > -- > yashi Looks nice - two hints/annotations: 1.) You should avoid the serial_init() & main_loop() calls inside your board_init() function. I think it's an unclean U-Boot coding style. The right place would be in lib_microblaze/board.c functions board_init_[rf]() or board_init() for targets without Flash/RAM abstraction (like Nios). Why do you do so? 2.) As far as I can remember the Microblaze CPU is the Soft CPU by Xilinx like Nios by Altera. So the core will be very very flexible and have to be configurable. Have a look at the differen Nios targets and let you inspire to map your specific CPU configuration into the U-Boot configuration managment. Best regards, Stepha Linz ^ permalink raw reply [flat|nested] 8+ messages in thread
* [U-Boot-Users] [patch] MicroBlaze port of U-Boot 2004-04-07 7:09 ` Stephan Linz @ 2004-04-07 11:19 ` Yasushi SHOJI 2004-04-18 21:25 ` Wolfgang Denk 0 siblings, 1 reply; 8+ messages in thread From: Yasushi SHOJI @ 2004-04-07 11:19 UTC (permalink / raw) To: u-boot Hi Stephan, At Wed, 7 Apr 2004 09:09:05 +0200, Stephan Linz wrote: > > Am Dienstag, 6. April 2004 21:40 schrieb Yasushi SHOJI: > > Here is a patch against the current CVS for microblaze port of > > u-boot. I does nothing but boot itself, but this can be a start. > > > > Suggestions, thoughts, and comments are welcome, of course. [...] > Looks nice - two hints/annotations: > > 1.) You should avoid the serial_init() & main_loop() calls inside your > board_init() function. I think it's an unclean U-Boot coding style. The right > place would be in lib_microblaze/board.c functions board_init_[rf]() or > board_init() for targets without Flash/RAM abstraction (like Nios). > Why do you do so? That's my mistake. Thank you for pointing out. > 2.) As far as I can remember the Microblaze CPU is the Soft CPU by Xilinx > like Nios by Altera. So the core will be very very flexible and have to be > configurable. Have a look at the differen Nios targets and let you inspire to > map your specific CPU configuration into the U-Boot configuration managment. I've had noticed that NIOS support is there but I'm still tring to grasp what is needed and how it works. I'll dig into the list archive and read some more documents. # pointers are always welcome ;) anyway, here is the incremental patch to move board_init() to lib_microblaze/board.c. best regards, -- yashi -------------- next part -------------- A non-text attachment was scrubbed... Name: u-boot-suzaku-board_init-fix.patch Type: application/octet-stream Size: 1465 bytes Desc: not available Url : http://lists.denx.de/pipermail/u-boot/attachments/20040407/c3534abf/attachment.obj ^ permalink raw reply [flat|nested] 8+ messages in thread
* [U-Boot-Users] [patch] MicroBlaze port of U-Boot 2004-04-07 11:19 ` Yasushi SHOJI @ 2004-04-18 21:25 ` Wolfgang Denk 2004-06-26 14:27 ` Yasushi SHOJI 0 siblings, 1 reply; 8+ messages in thread From: Wolfgang Denk @ 2004-04-18 21:25 UTC (permalink / raw) To: u-boot In message <20040407111919.6F2503E624@dns1.atmark-techno.com> you wrote: > > anyway, here is the incremental patch to move board_init() to > lib_microblaze/board.c. Thanks, appied. Please don't forget to provide a CHANGELOG entry for your patches. Best regards, Wolfgang Denk -- Software Engineering: Embedded and Realtime Systems, Embedded Linux Phone: (+49)-8142-4596-87 Fax: (+49)-8142-4596-88 Email: wd at denx.de Of all possible committee reactions to any given agenda item, the reaction that will occur is the one which will liberate the greatest amount of hot air. -- Thomas L. Martin ^ permalink raw reply [flat|nested] 8+ messages in thread
* [U-Boot-Users] [patch] MicroBlaze port of U-Boot 2004-04-18 21:25 ` Wolfgang Denk @ 2004-06-26 14:27 ` Yasushi SHOJI 2004-06-28 17:28 ` Yasushi SHOJI 0 siblings, 1 reply; 8+ messages in thread From: Yasushi SHOJI @ 2004-06-26 14:27 UTC (permalink / raw) To: u-boot Hi Wolfgang, # sorry for the very late reply At Sun, 18 Apr 2004 23:06:20 +0200, Wolfgang Denk wrote: > > Dear Yashi, > > in message <20040406194020.B1B153E624@dns1.atmark-techno.com> you wrote: > > > > Here is a patch against the current CVS for microblaze port of > > u-boot. I does nothing but boot itself, but this can be a start. > > Added, thanks a lot!! > > > Suggestions, thoughts, and comments are welcome, of course. > > I omitted the linux/linkage.h header file as I think this is not > necessary - please check, though. yup, you are right. > Also, please provide an additional patch to add yourself to the > CREDITS and MAINTAINERS files. attached. At Sun, 18 Apr 2004 23:25:43 +0200, Wolfgang Denk wrote: > > In message <20040407111919.6F2503E624@dns1.atmark-techno.com> you wrote: > > > > anyway, here is the incremental patch to move board_init() to > > lib_microblaze/board.c. > > Thanks, appied. > > Please don't forget to provide a CHANGELOG entry for your patches. attached. Also I have modified to include MicroBlaze in README. The reason why it's a big change is that the string "lib_microblaze" is too long to fit old indentation. no contents changed. best regards, -- yashi -------------- next part -------------- A non-text attachment was scrubbed... Name: u-boot.patch Type: application/octet-stream Size: 6324 bytes Desc: not available Url : http://lists.denx.de/pipermail/u-boot/attachments/20040626/e31f395a/attachment.obj ^ permalink raw reply [flat|nested] 8+ messages in thread
* [U-Boot-Users] [patch] MicroBlaze port of U-Boot 2004-06-26 14:27 ` Yasushi SHOJI @ 2004-06-28 17:28 ` Yasushi SHOJI 2004-06-28 18:08 ` Wolfgang Denk 0 siblings, 1 reply; 8+ messages in thread From: Yasushi SHOJI @ 2004-06-28 17:28 UTC (permalink / raw) To: u-boot Hi Wolfgang, please dump this whole thing if you haven't applied. I'll resubmit revised patch soon. thanks, -- yashi At Sat, 26 Jun 2004 23:27:42 +0900, yashi wrote: > > Hi Wolfgang, > > # sorry for the very late reply > > At Sun, 18 Apr 2004 23:06:20 +0200, > Wolfgang Denk wrote: > > > > Dear Yashi, > > > > in message <20040406194020.B1B153E624@dns1.atmark-techno.com> you wrote: > > > > > > Here is a patch against the current CVS for microblaze port of > > > u-boot. I does nothing but boot itself, but this can be a start. > > > > Added, thanks a lot!! > > > > > Suggestions, thoughts, and comments are welcome, of course. > > > > I omitted the linux/linkage.h header file as I think this is not > > necessary - please check, though. > > yup, you are right. > > > Also, please provide an additional patch to add yourself to the > > CREDITS and MAINTAINERS files. > > attached. > > At Sun, 18 Apr 2004 23:25:43 +0200, > Wolfgang Denk wrote: > > > > In message <20040407111919.6F2503E624@dns1.atmark-techno.com> you wrote: > > > > > > anyway, here is the incremental patch to move board_init() to > > > lib_microblaze/board.c. > > > > Thanks, appied. > > > > Please don't forget to provide a CHANGELOG entry for your patches. > > attached. > > Also I have modified to include MicroBlaze in README. The reason why > it's a big change is that the string "lib_microblaze" is too long to > fit old indentation. no contents changed. > > best regards, > -- > yashi ^ permalink raw reply [flat|nested] 8+ messages in thread
* [U-Boot-Users] [patch] MicroBlaze port of U-Boot 2004-06-28 17:28 ` Yasushi SHOJI @ 2004-06-28 18:08 ` Wolfgang Denk 0 siblings, 0 replies; 8+ messages in thread From: Wolfgang Denk @ 2004-06-28 18:08 UTC (permalink / raw) To: u-boot In message <20040628172833.38FAF3E90A@dns1.atmark-techno.com> you wrote: > > please dump this whole thing if you haven't applied. I'll resubmit > revised patch soon. OK, I dropped it. Best regards, Wolfgang Denk -- Software Engineering: Embedded and Realtime Systems, Embedded Linux Phone: (+49)-8142-4596-87 Fax: (+49)-8142-4596-88 Email: wd at denx.de Anything free is worth what you pay for it. ^ permalink raw reply [flat|nested] 8+ messages in thread
* [U-Boot-Users] [patch] MicroBlaze port of U-Boot 2004-04-06 19:40 [U-Boot-Users] [patch] MicroBlaze port of U-Boot Yasushi SHOJI 2004-04-07 7:09 ` Stephan Linz @ 2004-04-18 21:06 ` Wolfgang Denk 1 sibling, 0 replies; 8+ messages in thread From: Wolfgang Denk @ 2004-04-18 21:06 UTC (permalink / raw) To: u-boot Dear Yashi, in message <20040406194020.B1B153E624@dns1.atmark-techno.com> you wrote: > > Here is a patch against the current CVS for microblaze port of > u-boot. I does nothing but boot itself, but this can be a start. Added, thanks a lot!! > Suggestions, thoughts, and comments are welcome, of course. I omitted the linux/linkage.h header file as I think this is not necessary - please check, though. Also, please provide an additional patch to add yourself to the CREDITS and MAINTAINERS files. Best regards, Wolfgang Denk -- Software Engineering: Embedded and Realtime Systems, Embedded Linux Phone: (+49)-8142-4596-87 Fax: (+49)-8142-4596-88 Email: wd at denx.de People have one thing in common: they are all different. ^ permalink raw reply [flat|nested] 8+ messages in thread
end of thread, other threads:[~2004-06-28 18:08 UTC | newest] Thread overview: 8+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2004-04-06 19:40 [U-Boot-Users] [patch] MicroBlaze port of U-Boot Yasushi SHOJI 2004-04-07 7:09 ` Stephan Linz 2004-04-07 11:19 ` Yasushi SHOJI 2004-04-18 21:25 ` Wolfgang Denk 2004-06-26 14:27 ` Yasushi SHOJI 2004-06-28 17:28 ` Yasushi SHOJI 2004-06-28 18:08 ` Wolfgang Denk 2004-04-18 21:06 ` Wolfgang Denk
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox