public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Joakim Tjernlund <Joakim.Tjernlund@transmode.se>
To: u-boot@lists.denx.de
Subject: [U-Boot-Users] [PATCH] ppc: Revert patch 70431e8a that used _start instead of CFG_MONITOR_BASE
Date: Tue, 22 Apr 2008 07:49:57 +0200	[thread overview]
Message-ID: <040601c8a43c$b2c86650$185932f0$@Tjernlund@transmode.se> (raw)
In-Reply-To: <20080421160506.86caca50.kim.phillips@freescale.com>

> -----Original Message-----
> From: Kim Phillips [mailto:kim.phillips at freescale.com]
> Sent: den 21 april 2008 23:05
> To: Kim Phillips
> Cc: Stefan Roese; u-boot-users at lists.sourceforge.net; joakim.tjernlund at transmode.se
> Subject: Re: [U-Boot-Users] [PATCH] ppc: Revert patch 70431e8a that used _start instead of
> CFG_MONITOR_BASE
> 
> On Thu, 10 Apr 2008 19:45:02 -0500
> Kim Phillips <kim.phillips@freescale.com> wrote:
> 
> > On Wed,  9 Apr 2008 12:56:42 +0200
> > Stefan Roese <sr@denx.de> wrote:
> >
> > > The patch 70431e8a7393b6b793f77957f95b999fc9a269b8 (Make MPC83xx one step
> > > closer to full relocation.) doesn't use CFG_MONITOR_BASE anymore. But
> > > on 4xx systems _start currently cannot be used for this calculation.
> > > So revert back to the original version for now.
> > >
> > > Signed-off-by: Stefan Roese <sr@denx.de>
> >
> > Acked-by: Kim Phillips <kim.phillips@freescale.com>
> >
> hmm..I seem to have false-acked this due to a bug in a build script of
> mine.
> 
> Currently WD's top of tree renders 83xx kaput.  When I revert this
> revert plus Joakim's original 70431e8 commit, things are back to
> normal.  I'm not going to pretend I know to fix it up correctly, so
> does anyone have a problem with me sending two revert patches until
> relocation is properly and comprehensively fixed?

Strange, I got a 8321 and it worked for me. Maybe a toolchain issue? Perhaps
I got something extra in my board port, dunno what though.

If you revert it we are probably not going to solve it. I got no clue
though. Are any other 83xx users out there?

 Jocke

  reply	other threads:[~2008-04-22  5:49 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-04-09 10:56 [U-Boot-Users] [PATCH] ppc: Revert patch 70431e8a that used _start instead of CFG_MONITOR_BASE Stefan Roese
2008-04-11  0:45 ` Kim Phillips
2008-04-21 21:05   ` Kim Phillips
2008-04-22  5:49     ` Joakim Tjernlund [this message]
2008-04-22 17:28       ` Kim Phillips
2008-04-23  6:00         ` Joakim Tjernlund

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='040601c8a43c$b2c86650$185932f0$@Tjernlund@transmode.se' \
    --to=joakim.tjernlund@transmode.se \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox