From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id BB475EB64DA for ; Wed, 12 Jul 2023 23:54:05 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id BA352863E4; Thu, 13 Jul 2023 01:54:03 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=samsung.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=samsung.com header.i=@samsung.com header.b="EvwTjb5F"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id E5C1A863EE; Thu, 13 Jul 2023 01:54:02 +0200 (CEST) Received: from mailout3.samsung.com (mailout3.samsung.com [203.254.224.33]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 2CAED86332 for ; Thu, 13 Jul 2023 01:53:58 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=samsung.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=jh80.chung@samsung.com Received: from epcas1p2.samsung.com (unknown [182.195.41.46]) by mailout3.samsung.com (KnoxPortal) with ESMTP id 20230712235356epoutp0378d52997092be8fc35ca7748c6539c32~xQ-CvFAB43132731327epoutp030 for ; Wed, 12 Jul 2023 23:53:56 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 mailout3.samsung.com 20230712235356epoutp0378d52997092be8fc35ca7748c6539c32~xQ-CvFAB43132731327epoutp030 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=samsung.com; s=mail20170921; t=1689206036; bh=IjruJv5Un+79JcYAQ7BxbGPLvLx3UmBe7Pzfvj4gwrU=; h=From:To:Cc:In-Reply-To:Subject:Date:References:From; b=EvwTjb5FjKKaw8IkkNoUI1QyB3WIhc5A/WPqS0HlOMgELXPnL3WD9JDpXPxNTkAKW wiIKCqyTx4WeF2JpyofCuJxnB+YH7nOo4U05r7httfErZFXNb9rpT5seo/pPRg3ksb hpLoFBa4hx9xy0fv0fPruto8pnqkEsK5ugd5wiwI= Received: from epsnrtp1.localdomain (unknown [182.195.42.162]) by epcas1p4.samsung.com (KnoxPortal) with ESMTP id 20230712235355epcas1p49f8d7fdaad78379339c54a5f6e2a9b7d~xQ-Cfsn2X2854728547epcas1p4K; Wed, 12 Jul 2023 23:53:55 +0000 (GMT) Received: from epsmges1p5.samsung.com (unknown [182.195.38.237]) by epsnrtp1.localdomain (Postfix) with ESMTP id 4R1ZMR0S7Zz4x9QK; Wed, 12 Jul 2023 23:53:55 +0000 (GMT) Received: from epcas1p2.samsung.com ( [182.195.41.46]) by epsmges1p5.samsung.com (Symantec Messaging Gateway) with SMTP id 7F.84.22933.21D3FA46; Thu, 13 Jul 2023 08:53:54 +0900 (KST) Received: from epsmtrp1.samsung.com (unknown [182.195.40.13]) by epcas1p1.samsung.com (KnoxPortal) with ESMTPA id 20230712235354epcas1p14435caefd87bcb8251ea27a8075f8a4e~xQ-BUNWPP2724227242epcas1p1I; Wed, 12 Jul 2023 23:53:54 +0000 (GMT) Received: from epsmgms1p2new.samsung.com (unknown [182.195.42.42]) by epsmtrp1.samsung.com (KnoxPortal) with ESMTP id 20230712235354epsmtrp1ebfba1bc476d3c06340829b49c85a72a~xQ-BTjmRZ3273232732epsmtrp1J; Wed, 12 Jul 2023 23:53:54 +0000 (GMT) X-AuditID: b6c32a39-ce7fa70000005995-00-64af3d125c76 Received: from epsmtip2.samsung.com ( [182.195.34.31]) by epsmgms1p2new.samsung.com (Symantec Messaging Gateway) with SMTP id 89.0A.30535.21D3FA46; Thu, 13 Jul 2023 08:53:54 +0900 (KST) Received: from jh80chung01 (unknown [10.113.111.84]) by epsmtip2.samsung.com (KnoxPortal) with ESMTPA id 20230712235354epsmtip2c0ecd2e7319b29503bfe23cf6049eb2b~xQ-BG6EJj2990329903epsmtip21; Wed, 12 Jul 2023 23:53:54 +0000 (GMT) From: "Jaehoon Chung" To: <869470483@qq.com>, Cc: , "'xiefei'" In-Reply-To: Subject: RE: [PATCH] mmc:Remove thr legacy mode clock setting operation Date: Thu, 13 Jul 2023 08:53:54 +0900 Message-ID: <044801d9b51c$1d96bcb0$58c43610$@samsung.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Mailer: Microsoft Outlook 16.0 Thread-Index: AQIsTXATuJfRRRIaonf/QkemtUn3KgDMmjnfrws24VA= Content-Language: ko X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFmplk+LIzCtJLcpLzFFi42LZdlhTT1fIdn2KwZL5VhaTf3SwW/xY9YXV 4u3eTnaLrhV7WB1YPBavmMLqcfbODkaPje92MHnceraWNYAlKtsmIzUxJbVIITUvOT8lMy/d Vsk7ON453tTMwFDX0NLCXEkhLzE31VbJxSdA1y0zB2inkkJZYk4pUCggsbhYSd/Opii/tCRV ISO/uMRWKbUgJafAtECvODG3uDQvXS8vtcTK0MDAyBSoMCE7Y8FNy4LD3BW/+rgaGFdzdjFy ckgImEi0bl/H3MXIxSEksINR4uXEV2wQzidGiVtfrrBAON8YJV5tu8MO09J8bgZU1V5GiZMt c6D6XzJK/O87AVbFJqAn8X/RQmYQWwTIfvZvDVicWcBYYu+5A0wgNqeAk8TRVb9YQGxhAXeJ 5pPrweIsAqoSXydeZwSxeQUsJS6tXs4OYQtKnJz5hAVijrzE9rdzmCEuUpD4+XQZK8QuK4lN l2ewQtSISMzubAM7TkLgL7vEv8vbWSAaXCSuv2higrCFJV4d3wL1mpTEy/42doiGZkaJpUsO skI4PYwS/xqus0FUGUvsXzoZqJsDaIWmxPpd+hBhRYmdv+cyQmzmk3j3tYcVpERCgFeio00I okRF4tLrl0wwu+4++c86gVFpFpLfZiH5bRaSH2YhLFvAyLKKUSy1oDg3PbXYsMAUHtvJ+bmb GMHpUctyB+P0tx/0DjEycTAeYpTgYFYS4VXZti5FiDclsbIqtSg/vqg0J7X4EKMpMLQnMkuJ JucDE3ReSbyhiaWBiZmRsYmFoZmhkjjvube9KUIC6YklqdmpqQWpRTB9TBycUg1M61hWndc/ z/h5o/E5Gx2NlbIhd10Tm/9NS3WctLK22urXX9mgCzOCIpd/q9cuVVz+7PLdV6evTVCPCIk6 7PZraVy169o5IR88rLX0o3q3RXzSLT3q1ST8jZNpW4fQBVHdeZnzJt8LaZt+m/+GnvvtG+vT /tRw32aKvXVPPWbW+XqVzh7elSIVxf9bvHqSdfWdzjsXZyQlHRCu4fy5rkxVYp/4PwfP+TGa /il+sx421mUFHLi9pP49Y0SIkQBHn5RCrblj19ZLzNyrFIs6Cl5LPC1Zm/1XTL7aI/XYiRYt oaQPz38XKt2axyPkHsweNnPHYZOvAhHHl1hW1Bv0TMoOTDh7gMdryvUULuFqWyWW4oxEQy3m ouJEAL9jDEsYBAAA X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFnrNLMWRmVeSWpSXmKPExsWy7bCSvK6Q7foUg5V3VSwm/+hgt/ix6gur xdu9newWXSv2sDqweCxeMYXV4+ydHYweG9/tYPK49WwtawBLFJdNSmpOZllqkb5dAlfGgpuW BYe5K371cTUwrubsYuTkkBAwkWg+N4Oti5GLQ0hgN6PEvMNz2CESUhKfn04FSnAA2cIShw8X Q9Q8Z5TYuqiNCaSGTUBP4v+ihcwgNSICBhIz+6NAwswCphLnD81gh6ifzCix7+Y7sHpOASeJ o6t+sYDYwgLuEs0n14PFWQRUJb5OvM4IYvMKWEpcWr2cHcIWlDg58wkLyHxmoF1tGxkh5stL bH87hxniTAWJn0+XsYLYIgJWEpsuz2CFqBGRmN3ZxjyBUXgWkkmzECbNQjJpFpKOBYwsqxgl UwuKc9Nziw0LjPJSy/WKE3OLS/PS9ZLzczcxguNDS2sH455VH/QOMTJxMB5ilOBgVhLhVdm2 LkWINyWxsiq1KD++qDQntfgQozQHi5I477fXvSlCAumJJanZqakFqUUwWSYOTqkGps649rvz 8/c77QqI5mRdlPr/pc728Ctzb6pN1tRcwuxncOWkzbIZl/9a3711zaKu8GaE7C9vrbajsz1F KxeG3rny6wP/13/RJn3eGxb9mrzSXkdwZXHT14RP81q+VRmxMb5YdzeVedv39Z3Mlg5/z0Us yquTWBP3+sTXoL6mqaICp3Z//MvAtyw7kLeOtWHr6rgdbE8OqJUHLlkxV6jmAeN+B8XKgM8h e282GacKl/cuNXtSrh3zfL92hejWI40eRhL6a7RzAi3mZi70e6Z9oHBByp6POq/NtEovLnKf mnh+17qT+ZXH7gZNmlY6iTEz/4T/5WncLUvbEiczCC3+x/9md6Fh8Yu2n5/+MJQkFSqxFGck GmoxFxUnAgAxXhIb/gIAAA== X-CMS-MailID: 20230712235354epcas1p14435caefd87bcb8251ea27a8075f8a4e X-Msg-Generator: CA Content-Type: text/plain; charset="utf-8" X-Sendblock-Type: SVC_REQ_APPROVE CMS-TYPE: 101P DLP-Filter: Pass X-CFilter-Loop: Reflected X-CMS-RootMailID: 20230712071843epcas1p2b1e71a0e850643ce77dad94d8b3a70d5 References: X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.8 at phobos.denx.de X-Virus-Status: Clean Hi, > -----Original Message----- > From: 869470483@qq.com <869470483@qq.com> > Sent: Wednesday, July 12, 2023 4:19 PM > To: u-boot@lists.denx.de > Cc: peng.fan@nxp.com; jh80.chung@samsung.com; xiefei > Subject: [PATCH] mmc:Remove thr legacy mode clock setting operation > > From: xiefei > > Due to the need to read the register value before > switching to hs mode, the standard protocol does > not explicitly specify that the setting before > switching to hs mode is in legacy mode. Therefore, > the code at this point may cause communication > abnormalities between the host and card Thanks for resend patch after updated. Which board and driver does it occur the issue? Best Regards, Jaehoon Chung > > Signed-off-by: xiefei > --- > drivers/mmc/mmc.c | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/drivers/mmc/mmc.c b/drivers/mmc/mmc.c > index 1af6af82e6..96cc7e7332 100644 > --- a/drivers/mmc/mmc.c > +++ b/drivers/mmc/mmc.c > @@ -2136,9 +2136,7 @@ static int mmc_select_mode_and_width(struct mmc *mmc, uint card_caps) > mmc->selected_mode == MMC_HS_400 || > mmc->selected_mode == MMC_HS_400_ES) > mmc_set_card_speed(mmc, MMC_HS, true); > - else > #endif > - mmc_set_clock(mmc, mmc->legacy_speed, MMC_CLK_ENABLE); > > for_each_mmc_mode_by_pref(card_caps, mwt) { > for_each_supported_width(card_caps & mwt->widths, > -- > 2.17.1