From mboxrd@z Thu Jan  1 00:00:00 1970
From: Giuseppe CONDORELLI <giuseppe.condorelli@st.com>
Date: Tue, 21 Jul 2009 10:06:39 +0200
Subject: [U-Boot] [PATCH] zlib: updated to v.1.2.3
In-Reply-To: <20090720215343.66F8C832E416@gemini.denx.de>
Message-ID: <045901ca09da$2dc869f0$c08182a4@st.com>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

Hi Wolfgang,

I fixed patch and sent it to the mailing list.
It is now waiting for moderation due to its size.

Many thanks and regards,
Giuseppe

-----Original Message-----
From: Wolfgang Denk [mailto:wd at denx.de] 
Sent: Monday, July 20, 2009 11:54 PM
To: Giuseppe CONDORELLI
Cc: u-boot at lists.denx.de
Subject: Re: [U-Boot] [PATCH] zlib: updated to v.1.2.3

Dear Giuseppe CONDORELLI,

In message <20090720213352.186E3832E416@gemini.denx.de> I wrote:
> Dear Giuseppe CONDORELLI,
> 
> In message <1246273458-19028-1-git-send-email-giuseppe.condorelli@st.com>
you wrote:
> > This patch updates zlib to the latest stable version.
> > Only relevant zlib parts were ported to u-boot tree, as already did for
the
> > current zlib (0.95). New zlib guarantees a faster inflate performances
> > other then others improvements as explained at www.zlib.net
> > 
> > Signed-off-by: Giuseppe Condorelli <giuseppe.condorelli@st.com>
> > ---
> >  include/u-boot/zlib.h |  718 ++++++---
> >  lib_generic/zlib.c    | 3930
+++++++++++++++++++++++++------------------------
> >  2 files changed, 2463 insertions(+), 2185 deletions(-)
> 
> Applied, thanks.

Stope. I backed out your patch as it is causing compile problems. It
seems you did not do basic testing like running MAKEALL:

...
Configuring for netstar board...
/home/wd/git/u-boot/work/lib_generic/crc32.c:157: error: conflicting types
for 'crc32'
/home/wd/git/u-boot/work/include/u-boot/zlib.h:667: error: previous
declaration of 'crc32' was here
make[1]: *** [crc32.o] Error 1


Please fix and resubmit.

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
Man is the best computer we can put aboard a spacecraft ...  and  the
only one that can be mass produced with unskilled labor.
                                                 -- Wernher von Braun