public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Stefan Roese <sr@denx.de>
To: u-boot@lists.denx.de
Subject: [PATCH v5 05/12] arm: mvebu: clearfog: Add option for 2.5 Gbps SFP
Date: Mon, 23 Mar 2020 10:46:41 +0100	[thread overview]
Message-ID: <047e78af-e25d-b692-ebf6-c799d5a2ae09@denx.de> (raw)
In-Reply-To: <874kufh0uc.fsf@tarshish>



On 23.03.20 10:33, Baruch Siach wrote:
> Hi Stefan,
> 
> On Mon, Mar 23 2020, Stefan Roese wrote:
> 
>> On 27.01.20 21:01, Joel Johnson wrote:
>>> While newer Linux kernels provide autoconfiguration of SFP, provide
>>> an option for setting in U-Boot Kconfig for use prior to booting.
>>>
>>> Signed-off-by: Joel Johnson <mrjoel@lixil.net>
>>>
>>> ---
>>>
>>> v2 changes:
>>>     - fixed help indentation
>>> v3 changes:
>>>     - none
>>> v4 changes:
>>>     - adjust static SerDes configuration at runtime instead of #ifdef
>>> v5 changes:
>>>     - make independent of runtime detection
>>>
>>> ---
>>>    board/solidrun/clearfog/Kconfig    | 7 +++++++
>>>    board/solidrun/clearfog/clearfog.c | 5 +++++
>>>    2 files changed, 12 insertions(+)
>>>
>>> diff --git a/board/solidrun/clearfog/Kconfig b/board/solidrun/clearfog/Kconfig
>>> index 936d5918f8..c910e17093 100644
>>> --- a/board/solidrun/clearfog/Kconfig
>>> +++ b/board/solidrun/clearfog/Kconfig
>>> @@ -15,4 +15,11 @@ config TARGET_CLEARFOG_BASE
>>>    	  detection via additional EEPROM hardware. This option enables selecting
>>>    	  the Base variant for older hardware revisions.
>>>    +config CLEARFOG_SFP_25GB
>>> +	bool "Enable 2.5 Gbps mode for SFP"
>>> +	help
>>> +	  Set the SFP module connection to support 2.5 Gbps transfer speed for the
>>> +	  SGMII connection (requires a supporting SFP). By default, transfer speed
>>> +	  of 1.25 Gbps is used, suitable for a more common 1 Gbps SFP module.
>>> +
>>>    endmenu
>>> diff --git a/board/solidrun/clearfog/clearfog.c b/board/solidrun/clearfog/clearfog.c
>>> index c873d00905..064ce4e520 100644
>>> --- a/board/solidrun/clearfog/clearfog.c
>>> +++ b/board/solidrun/clearfog/clearfog.c
>>> @@ -63,6 +63,11 @@ int hws_board_topology_load(struct serdes_map **serdes_map_array, u8 *count)
>>>    {
>>>    	cf_read_tlv_data();
>>>    +	/* Apply build configuration options before runtime configuration */
>>> +	if (IS_ENABLED(CONFIG_CLEARFOG_SFP_25GB))
>>> +		board_serdes_map[5].serdes_speed = SERDES_SPEED_3_125_GBPS;
>>
>> Just checking: Your option is for 2.5 gbps and you configure here to
>> 3.125 gpbs. Is this intended?
> 
> This is intended. Serdes encoding is 8b/10b. So for 2.5Gbps you need
> serdes rate of 3.125Gbps. For 1Gbps we already set 1.25Gpbs serdes rate
> (SERDES_SPEED_1_25_GBPS) in board_serdes_map[].

Makes sense. Thanks.

Reviewed-by: Stefan Roese <sr@denx.de>

Thanks,
Stefan

  reply	other threads:[~2020-03-23  9:46 UTC|newest]

Thread overview: 35+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-01-27 20:01 [PATCH v5 00/12] ClearFog Base static variant support Joel Johnson
2020-01-27 20:01 ` [PATCH v5 01/12] arm: mvebu: fix SerDes table alignment Joel Johnson
2020-03-23  9:04   ` Stefan Roese
2020-01-27 20:01 ` [PATCH v5 02/12] arm: mvebu: solidrun: remove hardcoded DTS MAC address Joel Johnson
2020-03-23  9:05   ` Stefan Roese
2020-01-27 20:01 ` [PATCH v5 03/12] arm: mvebu: clearfog: use Pro name by default Joel Johnson
2020-03-23  9:07   ` Stefan Roese
2020-01-27 20:01 ` [PATCH v5 04/12] arm: mvebu: clearfog: initial ClearFog Base variant Joel Johnson
2020-03-23  9:11   ` Stefan Roese
2020-03-23 15:27     ` Joel Johnson
2020-01-27 20:01 ` [PATCH v5 05/12] arm: mvebu: clearfog: Add option for 2.5 Gbps SFP Joel Johnson
2020-03-23  9:14   ` Stefan Roese
2020-03-23  9:33     ` Baruch Siach
2020-03-23  9:46       ` Stefan Roese [this message]
2020-01-27 20:01 ` [PATCH v5 06/12] arm: mvebu: clearfog: Add SATA mode flags Joel Johnson
2020-01-28  6:06   ` Baruch Siach
2020-01-28  6:34     ` Joel Johnson
2020-03-23  9:18   ` Stefan Roese
2020-01-27 20:01 ` [PATCH v5 07/12] arm: mvebu: clearfog: Unify DT selection paths Joel Johnson
2020-03-23  9:19   ` Stefan Roese
2020-01-27 20:01 ` [PATCH v5 08/12] arm: mvebu: clearfog: add SPI offsets Joel Johnson
2020-03-23  9:21   ` Stefan Roese
2020-01-27 20:01 ` [PATCH v5 09/12] arm: mvebu: enable working default boot support Joel Johnson
2020-03-23  9:22   ` Stefan Roese
2020-01-27 20:01 ` [PATCH v5 10/12] arm: mvebu: clearfog: move ENV params to Kconfig Joel Johnson
2020-03-23  9:23   ` Stefan Roese
2020-01-27 20:01 ` [PATCH v5 11/12] arm: mvebu: clearfog: don't always use SPL MMC Joel Johnson
2020-03-23  9:23   ` Stefan Roese
2020-01-27 20:01 ` [PATCH v5 12/12] arm: mvebu: clearfog: Use Pro DT by default Joel Johnson
2020-01-28  6:17   ` Baruch Siach
2020-01-28  6:49     ` Joel Johnson
2020-03-23  9:26   ` Stefan Roese
2020-03-22 18:46 ` [PATCH v5 00/12] ClearFog Base static variant support Joel Johnson
2020-03-23  9:03   ` Stefan Roese
2020-03-23 16:59     ` Baruch Siach

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=047e78af-e25d-b692-ebf6-c799d5a2ae09@denx.de \
    --to=sr@denx.de \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox