Re: [PATCH v5] misc: fs-loader: Use fw_storage_interface instead of storage_interface

[Sean Anderson <seanga2@gmail.com>]

Hi Danish,

On 2/27/24 05:26, MD Danish Anwar wrote:
> On 09/02/24 3:38 pm, MD Danish Anwar wrote:
>> The fs-loader driver reads env storage_interface and uses it to load
>> firmware file into memory using the medium set by env. Update the driver
>> to use env fw_storage_interface as this variable is only used to load
>> firmwares. This is to keep all variables used by fs-loader driver with
>> 'fw_' prefix. All other variables have 'fw_' prefix except for
>> storage_interface.
>>
>> The env storage_interface will act as fallback so that the
>> existing implementations do not break.
>>
>> Also update the FS Loader documentation accordingly.
>>
>> Signed-off-by: MD Danish Anwar <danishanwar@ti.com>
>> ---
> 
> Hi Tom / Sean, can you please pick this patch if there is no pending
> comments to address.
> 

Sorry, I forgot to respond to this earlier.

To be honest, I'm not really convinced. We have plenty of environmental
variables which are inconsistent (e.g. ethaddr, eth2addr, eth3addr) and it
doesn't cause any issues. While fixing code has no cost, the environment
is an ABI which we can't break. So we'd have to support both of these
variables forever. I'm not really a fan of doing that without good reason,
and I think aesthetics of the variable name isn't really compelling.

--Sean