Re: [PATCH v2 12/25] binman: Change how faked blobs are created

Simon Glass
2022-03-14T22:21:26Z

Hi Alper,

On Mon, 14 Mar 2022 at 15:31, Alper Nebi Yasak <alpernebiyasak@gmail.com> wrote:
>
> On 12/03/2022 08:02, Simon Glass wrote:
> > On Thu, 10 Mar 2022 at 12:36, Alper Nebi Yasak <alpernebiyasak@gmail.com> wrote:
> >> On 06/03/2022 06:08, Simon Glass wrote:
> >>> On Thu, 3 Mar 2022 at 14:16, Alper Nebi Yasak <alpernebiyasak@gmail.com> wrote:
> >>>> Do we need to create actual files, or is it a convenience thing for blob
> >>>> entry types (because they already read their contents from files)?
> >>>
> >>> We need the files for mkimage.
> >>
> >> But the mkimage etype creates its own files to pass to mkimage anyway,
> >> using entry.GetData() in collect_contents_to_file() without reaching
> >> into subentries' files.
> >>
> >> More specifically, what I'm thinking of is removing check_fake_fname()
> >> entirely, instead of managing/removing the files it creates. At a
> >> cursory glance, only blob and blob-ext-list seem to use that directly.
> >
> > OK, but if the files don't get created, then mkimage will fail, right?
>
> I don't think it will, but maybe it's better that I try removing it to
> see if anything breaks.

Yes, the reason for adding faked blobs was needing to run mkimage
which expects files (in the .its or elsewhere) to be present.

Regards,
Simon