From: Christoph Stoidner <C.Stoidner@phytec.de>
To: PHYTEC Upstream <upstream@lists.phytec.de>,
"u-boot@lists.denx.de" <u-boot@lists.denx.de>,
"wahrenst@gmx.net" <wahrenst@gmx.net>
Cc: Yannic Moog <Y.Moog@phytec.de>, Wadim Egorov <W.Egorov@phytec.de>,
"trini@konsulko.com" <trini@konsulko.com>,
"festevam@gmail.com" <festevam@gmail.com>,
Andrej Picej <andrej.picej@norik.com>,
"sbabic@denx.de" <sbabic@denx.de>,
"uboot-imx@nxp.com" <uboot-imx@nxp.com>,
Primoz Fiser <primoz.fiser@norik.com>,
"m.othacehe@gmail.com" <m.othacehe@gmail.com>
Subject: Re: [PATCH v4 2/3] board: phytec: imx93: Add eeprom-based hardware introspection
Date: Mon, 25 Nov 2024 08:28:47 +0000 [thread overview]
Message-ID: <05db2b94c4eb28aefc33a13c6fb2fa324eb62ee7.camel@phytec.de> (raw)
In-Reply-To: <371c6302-438b-45b6-944b-d513f74f38a5@gmx.net>
Hi Stefan,
On Do, 2024-11-21 at 11:12 +0100, Stefan Wahren wrote:
> Hi Christoph,
>
> Am 20.11.24 um 17:31 schrieb Christoph Stoidner:
>
[...]
> >
> > diff --git a/arch/arm/dts/imx93-phyboard-segin-u-boot.dtsi
> > b/arch/arm/dts/imx93-phyboard-segin-u-boot.dtsi
> > index 6897c91f4d..702d86f4e0 100644
> > --- a/arch/arm/dts/imx93-phyboard-segin-u-boot.dtsi
> > +++ b/arch/arm/dts/imx93-phyboard-segin-u-boot.dtsi
> > @@ -139,6 +139,13 @@
> > &usdhc1 {
> > bootph-pre-ram;
> > bootph-some-ram;
> > + /*
> > + * Remove pinctrl assignments once they are added to imx93-
> > phycore-som.dtsi
> > + */
> > + pinctrl-names = "default", "state_100mhz", "state_200mhz";
> > + pinctrl-0 = <&pinctrl_usdhc1>;
> > + pinctrl-1 = <&pinctrl_usdhc1_100mhz>;
> > + pinctrl-2 = <&pinctrl_usdhc1_200mhz>;
> > };
> >
> > &usdhc2 {
> > @@ -215,6 +222,48 @@
> > MX93_PAD_ENET2_RD3__GPIO4_IO27
> > 0x31e
> > >;
> > };
> > +
> > + /*
> > + * Remove pinctrl_usdhc1_100mhz and pinctrl_usdhc1_200mhz
> > once they
> > + * are added to imx93-phycore-som.dtsi
> > + */
> > + /* need to config the SION for data and cmd pad, refer to
> > ERR052021 */
> > + pinctrl_usdhc1_100mhz: usdhc1-100mhzgrp {
> > + bootph-pre-ram;
> > + bootph-some-ram;
> > + fsl,pins = <
> > + MX93_PAD_SD1_CLK__USDHC1_CLK 0x1
> > 7be
> > + MX93_PAD_SD1_CMD__USDHC1_CMD 0x4
> > 000139e
> > + MX93_PAD_SD1_DATA0__USDHC1_DATA0 0x4
> > 000138e
> > + MX93_PAD_SD1_DATA1__USDHC1_DATA1 0x4
> > 000139e
> > + MX93_PAD_SD1_DATA2__USDHC1_DATA2 0x4
> > 00013be
> Could you please explain why the pin configuration for 100 MHz of
> DATA0
> & DATA2 is different from the other data pins?
The difference in the values is due to different drive-strength
settings per pin. The values are the result of measurements we
did for the eMMC interface. There, we adjusted each pin's
drive-strength to get it's best signal quality.
Regards,
Christoph
> > + MX93_PAD_SD1_DATA3__USDHC1_DATA3 0x4
> > 000139e
> > + MX93_PAD_SD1_DATA4__USDHC1_DATA4 0x4
> > 000139e
> > + MX93_PAD_SD1_DATA5__USDHC1_DATA5 0x4
> > 000139e
> > + MX93_PAD_SD1_DATA6__USDHC1_DATA6 0x4
> > 000139e
> > + MX93_PAD_SD1_DATA7__USDHC1_DATA7 0x4
> > 000139e
> > + MX93_PAD_SD1_STROBE__USDHC1_STROBE 0x1
> > 79e
> > + >;
> > + };
> > +
> > + /* need to config the SION for data and cmd pad, refer to
> > ERR052021 */
> > + pinctrl_usdhc1_200mhz: usdhc1-200mhzgrp {
> > + bootph-pre-ram;
> > + bootph-some-ram;
> > + fsl,pins = <
> > + MX93_PAD_SD1_CLK__USDHC1_CLK 0x1
> > 7be
> > + MX93_PAD_SD1_CMD__USDHC1_CMD 0x4
> > 000139e
> > + MX93_PAD_SD1_DATA0__USDHC1_DATA0 0x4
> > 000139e
> > + MX93_PAD_SD1_DATA1__USDHC1_DATA1 0x4
> > 00013be
> > + MX93_PAD_SD1_DATA2__USDHC1_DATA2 0x4
> > 00013be
> > + MX93_PAD_SD1_DATA3__USDHC1_DATA3 0x4
> > 00013be
> > + MX93_PAD_SD1_DATA4__USDHC1_DATA4 0x4
> > 00013be
> > + MX93_PAD_SD1_DATA5__USDHC1_DATA5 0x4
> > 00013be
> > + MX93_PAD_SD1_DATA6__USDHC1_DATA6 0x4
> > 00013be
> > + MX93_PAD_SD1_DATA7__USDHC1_DATA7 0x4
> > 00013be
> > + MX93_PAD_SD1_STROBE__USDHC1_STROBE 0x1
> > 79e
> > + >;
> > + };
> > };
> >
next prev parent reply other threads:[~2024-11-25 8:29 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-20 16:31 [PATCH v4 0/3] Add support for all variants of the phyCORE-i.MX93 SOM Christoph Stoidner
2024-11-20 16:31 ` [PATCH v4 1/3] board: phytec: phycore-imx93: Add 2GB LPDDR4X RAM timings Christoph Stoidner
2024-11-20 16:31 ` [PATCH v4 2/3] board: phytec: imx93: Add eeprom-based hardware introspection Christoph Stoidner
2024-11-21 7:24 ` Primoz Fiser
2024-11-21 10:12 ` Stefan Wahren
2024-11-25 8:28 ` Christoph Stoidner [this message]
2024-11-25 9:39 ` Stefan Wahren
2024-11-25 10:03 ` Christoph Stoidner
2024-11-25 10:45 ` Stefan Wahren
2024-11-20 16:31 ` [PATCH v4 3/3] board: phytec: imx93: Add phyCORE-i.MX 93 support for all SOM variants Christoph Stoidner
2024-11-26 11:59 ` [PATCH v4 0/3] Add support for all variants of the phyCORE-i.MX93 SOM Fabio Estevam
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=05db2b94c4eb28aefc33a13c6fb2fa324eb62ee7.camel@phytec.de \
--to=c.stoidner@phytec.de \
--cc=W.Egorov@phytec.de \
--cc=Y.Moog@phytec.de \
--cc=andrej.picej@norik.com \
--cc=festevam@gmail.com \
--cc=m.othacehe@gmail.com \
--cc=primoz.fiser@norik.com \
--cc=sbabic@denx.de \
--cc=trini@konsulko.com \
--cc=u-boot@lists.denx.de \
--cc=uboot-imx@nxp.com \
--cc=upstream@lists.phytec.de \
--cc=wahrenst@gmx.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox