From: Fabio Estevam <festevam@denx.de>
To: Philip Oberfichtner <pro@denx.de>
Cc: u-boot@lists.denx.de,
Christoph Niedermaier <cniedermaier@dh-electronics.com>,
Stefano Babic <sbabic@denx.de>, Peng Fan <peng.fan@nxp.com>,
Andreas Geisreiter <ageisreiter@dh-electronics.de>,
Tom Rini <trini@konsulko.com>,
u-boot@dh-electronics.com
Subject: Re: [PATCH 8/8] ARM: imx6: Adapt device tree selection in DH board file
Date: Thu, 19 May 2022 09:48:11 -0300 [thread overview]
Message-ID: <064f55c763ae1056c70d6c6f044d730e@denx.de> (raw)
In-Reply-To: <20220519110837.245488-9-pro@denx.de>
On 19/05/2022 08:08, Philip Oberfichtner wrote:
return 0;
> - }
> + /* Determine carrier board at compile time and SoM at runtime */
> + const size_t size = 32;
> + char *car, *som, dt[size];
> +
> + car = strchr(CONFIG_DEFAULT_DEVICE_TREE, '-'); /* i.e. -dhcom-drc02
> */
> +
> + som = is_mx6dq() ? "imx6q" :
> + is_mx6dl() ? "imx6dl" :
> + is_mx6solo() ? "imx6s" : NULL;
> +
> + if (!(car && som))
> + return -1;
Nit: can you return -EINVAL instead of -1?
next prev parent reply other threads:[~2022-05-19 12:48 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-19 11:08 [PATCH 0/8] ARM: imx: Add support for iMX6QDL DHCOM DRC02 and DH picoITX Philip Oberfichtner
2022-05-19 11:08 ` [PATCH 1/8] ARM: imx6: Fix broken DT path in DH board file Philip Oberfichtner
2022-05-19 12:39 ` Marek Vasut
2022-05-19 11:08 ` [PATCH 2/8] ARM: dts: imx: Migrate iMX6QDL DRC02 DTs from Linux Philip Oberfichtner
2022-05-19 11:08 ` [PATCH 3/8] ARM: dts: imx: Migrate iMX6QDL picoITX " Philip Oberfichtner
2022-05-19 11:08 ` [PATCH 4/8] ARM: imx6: Remove CONFIG_FEC_MXC_PHYADDR from DH header Philip Oberfichtner
2022-05-19 11:08 ` [PATCH 5/8] ARM: dts: imx: Simplify fec node for iMX6QDL DHCOM boards Philip Oberfichtner
2022-05-19 12:40 ` Marek Vasut
2022-05-19 11:08 ` [PATCH 6/8] ARM: dts: imx: Configure FEC for iMX6QDL picoITX Philip Oberfichtner
2022-05-19 12:41 ` Marek Vasut
2022-05-19 11:08 ` [PATCH 7/8] ARM: dts: imx: Configure FEC for iMX6QDL DRC02 Philip Oberfichtner
2022-05-19 12:42 ` Marek Vasut
2022-05-19 11:08 ` [PATCH 8/8] ARM: imx6: Adapt device tree selection in DH board file Philip Oberfichtner
2022-05-19 12:48 ` Fabio Estevam [this message]
2022-05-19 12:57 ` Marek Vasut
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=064f55c763ae1056c70d6c6f044d730e@denx.de \
--to=festevam@denx.de \
--cc=ageisreiter@dh-electronics.de \
--cc=cniedermaier@dh-electronics.com \
--cc=peng.fan@nxp.com \
--cc=pro@denx.de \
--cc=sbabic@denx.de \
--cc=trini@konsulko.com \
--cc=u-boot@dh-electronics.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox