From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 8C57FC433FE for ; Wed, 26 Oct 2022 09:19:11 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 8EAE684F91; Wed, 26 Oct 2022 11:19:09 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=samsung.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=samsung.com header.i=@samsung.com header.b="QKcU4QIK"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 617B984FA9; Wed, 26 Oct 2022 11:19:07 +0200 (CEST) Received: from mailout4.samsung.com (mailout4.samsung.com [203.254.224.34]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id BBA1984F46 for ; Wed, 26 Oct 2022 11:18:45 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=samsung.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=jh80.chung@samsung.com Received: from epcas1p4.samsung.com (unknown [182.195.41.48]) by mailout4.samsung.com (KnoxPortal) with ESMTP id 20221026091836epoutp04d3f6d8f73d731ad804a5294767773c0b~hk91kPTfo2495824958epoutp04U for ; Wed, 26 Oct 2022 09:18:36 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 mailout4.samsung.com 20221026091836epoutp04d3f6d8f73d731ad804a5294767773c0b~hk91kPTfo2495824958epoutp04U DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=samsung.com; s=mail20170921; t=1666775916; bh=tDUNWGxTAbRDkdBg2Z1eG/xzZEH+XvQZTOHtH6sFuiM=; h=From:To:Cc:In-Reply-To:Subject:Date:References:From; b=QKcU4QIKPLHXbb5i13jvplN7VWod7wSyIhDBVJBNlN+XX3AyRj8lra6qSedfIFV/m hrZVF3pQ2pDKAk9lDkNfmdFM35FoPniF9xIswBKG6qihI5+sya2i+aeegqb1Mw6+KP 394uYtWPjmyZYWwjdv2rGvnNr3+YeHAkMcj1EerI= Received: from epsnrtp4.localdomain (unknown [182.195.42.165]) by epcas1p3.samsung.com (KnoxPortal) with ESMTP id 20221026091836epcas1p3c351af15f039dfde15bcfcf990f76e67~hk91Zr0_m2490624906epcas1p3r; Wed, 26 Oct 2022 09:18:36 +0000 (GMT) Received: from epsmges1p2.samsung.com (unknown [182.195.38.234]) by epsnrtp4.localdomain (Postfix) with ESMTP id 4My3Bz0VVgz4x9Q7; Wed, 26 Oct 2022 09:18:35 +0000 (GMT) Received: from epcas1p1.samsung.com ( [182.195.41.45]) by epsmges1p2.samsung.com (Symantec Messaging Gateway) with SMTP id F6.1D.51827.A6BF8536; Wed, 26 Oct 2022 18:18:35 +0900 (KST) Received: from epsmtrp1.samsung.com (unknown [182.195.40.13]) by epcas1p3.samsung.com (KnoxPortal) with ESMTPA id 20221026091834epcas1p313709207fc5e33f6c7d1fc2e047c52b6~hk90FxWRH2400024000epcas1p37; Wed, 26 Oct 2022 09:18:34 +0000 (GMT) Received: from epsmgms1p1new.samsung.com (unknown [182.195.42.41]) by epsmtrp1.samsung.com (KnoxPortal) with ESMTP id 20221026091834epsmtrp140ea6741939ff2d2699b0c2f0edddd72~hk90E6ekM0582905829epsmtrp1Q; Wed, 26 Oct 2022 09:18:34 +0000 (GMT) X-AuditID: b6c32a36-17bfa7000000ca73-d5-6358fb6ac497 Received: from epsmtip2.samsung.com ( [182.195.34.31]) by epsmgms1p1new.samsung.com (Symantec Messaging Gateway) with SMTP id B8.54.14392.A6BF8536; Wed, 26 Oct 2022 18:18:34 +0900 (KST) Received: from jh80chung01 (unknown [10.113.111.84]) by epsmtip2.samsung.com (KnoxPortal) with ESMTPA id 20221026091834epsmtip2cfcfb01273719456eac43d523f9f1fb2~hk9z7jD9s1326613266epsmtip2W; Wed, 26 Oct 2022 09:18:34 +0000 (GMT) From: "Jaehoon Chung" To: "'qianfan'" , Cc: "'Peng Fan'" In-Reply-To: <8b72a530-9391-8168-1798-75133384bc2c@163.com> Subject: RE: [PATCH] drivers: mmc: Reset watchdog when accessing mmc device Date: Wed, 26 Oct 2022 18:18:34 +0900 Message-ID: <06c601d8e91b$ec3402d0$c49c0870$@samsung.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Mailer: Microsoft Outlook 15.0 Thread-Index: AQEwwwy0SkqMQ1aiUf23Q2EAGOYZlAJy8+joAabdtzwChnB54q87rvdA Content-Language: ko X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFvrNKsWRmVeSWpSXmKPExsWy7bCmrm7274hkgzm3GS1+rPrCanHnzjdW i7d7O9kdmD0Wr5jC6nH2zg5Gj43vdjAFMEdl22SkJqakFimk5iXnp2TmpdsqeQfHO8ebmhkY 6hpaWpgrKeQl5qbaKrn4BOi6ZeYAbVJSKEvMKQUKBSQWFyvp29kU5ZeWpCpk5BeX2CqlFqTk FJgW6BUn5haX5qXr5aWWWBkaGBiZAhUmZGds+jqDqeC0dMXU20vZGxj3SXUxcnJICJhI7P8x i7mLkYtDSGAHo8SETd9ZIZxPjBJ7Xm+Acr4xSrya+JIJpmVz2weoxF5GiWMzlzFBOC8ZJRrv LGIEqWIT0JP4v2gh0GAODhEBe4n+M6kgYWYBZYkDf26zg9icAtYSNxYtZAGxhQW8Jb41zmID KWcRUJW4+80GJMwrYCkx/fc3RghbUOLkzCcsEGO0JZYtfM0McY+CxO5PR1lBbBEBN4nbJ7aw QdSISMzubAN7TULgEbvE4tOHoBpcJBZvXgH1jLDEq+Nb2CFsKYmX/W3sEA3NjBJLlxxkhXB6 GCX+NVxng6gylti/dDITyKXMApoS63fpQ4QVJXb+nssIsZlP4t3XHlaQEgkBXomONiGIEhWJ S69hgSglcffJf9YJjEqzkPw2C8lvs5D8MAth2QJGllWMYqkFxbnpqcWGBUbw2E7Oz93ECE6F WmY7GCe9/aB3iJGJg/EQowQHs5II79kb4clCvCmJlVWpRfnxRaU5qcWHGE2BgT2RWUo0OR+Y jPNK4g1NLA1MzIyMTSwMzQyVxHkbZmglCwmkJ5akZqemFqQWwfQxcXBKNTD5n9lgePunVAWj 29/PC74YdWp2i/j+F5dlO7+32VPMs+z9njLF8O7Df/1CzbgrPrxs9JnJzRqjeLjtq4uQZ2QJ v/duNmatVX8mvevdWi/jo+DvW5rNyrAl++NL/jX/hbUmW255da/M0mazWNjjrSoO+rseyIuU +0yfVvmweM3zGy0MMUmhHsppJ3JPO025INW/dbKFRLLSVU071ikrjkUaKpUd+uX7t3belZuf SrgurJ8dM/Ns/qdwlVQR780CTxlPJPlzbhBaqvnIZPJ040OrSla6vA2s/K2wds+FJmNjj0Un TlgdM3lcFF2/vl7v1jGZdb73C2ysdHav9DXYef2SW1t9gVXdq3klDOLfdiuxFGckGmoxFxUn AgD3MFpzDgQAAA== X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFnrKLMWRmVeSWpSXmKPExsWy7bCSvG7W74hkgwcHFCx+rPrCanHnzjdW i7d7O9kdmD0Wr5jC6nH2zg5Gj43vdjAFMEdx2aSk5mSWpRbp2yVwZey7co214KNQxZN929ka GG/xdTFyckgImEhsbvvA2sXIxSEksJtRYsu5hywQCSmJz0+nsnUxcgDZwhKHDxdD1DxnlGi9 8p8ZpIZNQE/i/6KFYLaIgKPEpQtHwXqZBZQlDvy5zQ7R8I5RYsXWm2BFnALWEjcWLQQrEhbw lvjWOAtsAYuAqsTdbzYgYV4BS4npv78xQtiCEidnPoGaqS3x9OZTOHvZwtfMEHcqSOz+dJQV 4gY3idsntrBB1IhIzO5sY57AKDwLyahZSEbNQjJqFpKWBYwsqxglUwuKc9Nziw0LDPNSy/WK E3OLS/PS9ZLzczcxgmNCS3MH4/ZVH/QOMTJxMB5ilOBgVhLhPXsjPFmINyWxsiq1KD++qDQn tfgQozQHi5I474Wuk/FCAumJJanZqakFqUUwWSYOTqkGpgZrE2H/3KaFHyZvLXlWutje6pyZ Z9txs/C0fZO+3s4qT3Y1jAx6EcbIl1P7qWTWptTHoa4BexMK9807s3GzZ5aN7rLr6u0SB5yO T2L03u2ypXL3Aus7Wy+1y5bunL3K5fOixKmFdjdLb6/1TfSy+7T7zwlmgStO26ZmXzLxDIzm 2sEfy958lGF7f2/zfGf3NVmHL1qr7jlwIWmxvGiR7OHY+dde/gtlschX8Dp74pRmzRRH4eDn 85L/rUr678FqKf/iY6VU96zJDaZSZyw6X/ZGaocUfpNU8++TZFc3C32QofQ613KbX71pqcYS A+Nt/xvFnl8M2OXypeDlJF0bLdNd15f0he+ZLnWjdc8vJZbijERDLeai4kQA95T47/gCAAA= X-CMS-MailID: 20221026091834epcas1p313709207fc5e33f6c7d1fc2e047c52b6 X-Msg-Generator: CA Content-Type: text/plain; charset="utf-8" X-Sendblock-Type: SVC_REQ_APPROVE CMS-TYPE: 101P DLP-Filter: Pass X-CFilter-Loop: Reflected X-CMS-RootMailID: 20220726083134epcas1p1da8e13a4364d556e820f3d45b1686b8a References: <20220713073221.26183-1-qianfanguijin@163.com> <90f75b3f-e770-8ea4-d865-e69e110d2bdb@samsung.com> <8b72a530-9391-8168-1798-75133384bc2c@163.com> X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.6 at phobos.denx.de X-Virus-Status: Clean Hi, > -----Original Message----- > From: qianfan =5Bmailto:qianfanguijin=40163.com=5D > Sent: Tuesday, August 30, 2022 12:43 PM > To: Jaehoon Chung ; u-boot=40lists.denx.de > Cc: Peng Fan > Subject: Re: =5BPATCH=5D drivers: mmc: Reset watchdog when accessing mmc = device >=20 >=20 >=20 > =E5=9C=A8=202022/7/26=2016:31,=20Jaehoon=20Chung=20=E5=86=99=E9=81=93:=0D= =0A>=20>=20On=207/13/22=2016:32,=20qianfanguijin=40163.com=20wrote:=0D=0A>= =20>>=20From:=20qianfan=20Zhao=20=0D=0A>=20>>=0D= =0A>=20>>=20watchdog=20will=20reset=20when=20'mmc=20read'=20or=20'ext4load'= =20a=20large=20file=20from=0D=0A>=20>>=20mmc=20device.=20Reset=20watchdog= =20when=20accessing=20mmc=20device.=0D=0A>=20>=20I=20don't=20know=20why=20t= his=20patch=20is=20need.=0D=0A>=20Hi:=0D=0A>=20=0D=0A>=20maybe=20your's=20b= oard=20doesn't=20have=20a=20hardware=20watchdog.=0D=0A>=20on=20my=20board= =20there=20has=20a=20gpio=20watchdog=20and=20we=20should=20trigger=20it=20n= o=20more=20than=201.2=20second.=0D=0A>=20otherwise=20it=20will=20reset=20CP= U.=0D=0A>=20=0D=0A>=20But=20'mmc=20read'=20command=20doesn't=20trigger=20wa= tchdog,=20it's=20ok=20if=20we=20load=20a=20smaller=20imges,=20but=20if=20we= =0D=0A>=20load=20a=20very=20bigger=20image=20which=20more=20than=20100MiB,= =20the=20watchdog=20will=20dead=20and=20trigger=20a=20system=20reset.=0D=0A= =0D=0ASorry=20for=20too=20late.=20I=20had=20missed=20your=20email.=0D=0AIs= =20there=20a=20case=20to=20load=20more=20bigger=20image=20than=20100MiB?=0D= =0A=0D=0ABest=20Regards,=0D=0AJaehoon=20Chung=0D=0A=0D=0A=0D=0A>=20=0D=0A>= =20So=20I=20make=20this=20patch=20to=20make=20sure=20we=20can=20trigger=20w= atchdog=20while=20loading=20mmc.=0D=0A>=20>=0D=0A>=20>=20Best=20Regards,=0D= =0A>=20>=20Jaehoon=20Chung=0D=0A>=20>=0D=0A>=20>>=20Signed-off-by:=20qianfa= n=20Zhao=20=0D=0A>=20>>=20---=0D=0A>=20>>=20=20=20= drivers/mmc/mmc.c=20=7C=204=20++++=0D=0A>=20>>=20=20=201=20file=20changed,= =204=20insertions(+)=0D=0A>=20>>=0D=0A>=20>>=20diff=20--git=20a/drivers/mmc= /mmc.c=20b/drivers/mmc/mmc.c=20index=0D=0A>=20>>=204d9871d69f..27ffdb7fa7= =20100644=0D=0A>=20>>=20---=20a/drivers/mmc/mmc.c=0D=0A>=20>>=20+++=20b/dri= vers/mmc/mmc.c=0D=0A>=20>>=20=40=40=20-24,6=20+24,7=20=40=40=0D=0A>=20>>=20= =20=20=23include=20=0D=0A>=20>>=20=20=20=23include=20=0D=0A>=20>>=20=20=20=23include=20=0D=0A>=20>>=20+=23include= =20=0D=0A>=20>>=20=20=20=23include=20=22mmc_private.h=22=0D=0A>= =20>>=0D=0A>=20>>=20=20=20=23define=20DEFAULT_CMD6_TIMEOUT_MS=20=20500=20= =40=40=20-297,6=20+298,7=20=40=40=20int=0D=0A>=20>>=20mmc_poll_for_busy(str= uct=20mmc=20*mmc,=20int=20timeout_ms)=0D=0A>=20>>=20=20=20=09=09if=20(timeo= ut_ms--=20<=3D=200)=0D=0A>=20>>=20=20=20=09=09=09break;=0D=0A>=20>>=0D=0A>= =20>>=20+=09=09WATCHDOG_RESET();=0D=0A>=20>>=20=20=20=09=09udelay(1000);=0D= =0A>=20>>=20=20=20=09=7D=0D=0A>=20>>=0D=0A>=20>>=20=40=40=20-500,6=20+502,8= =20=40=40=20ulong=20mmc_bread(struct=20blk_desc=20*block_dev,=20lbaint_t=20= start,=20lbaint_t=20blkcnt,=0D=0A>=20>>=20=20=20=09=09blocks_todo=20-=3D=20= cur;=0D=0A>=20>>=20=20=20=09=09start=20+=3D=20cur;=0D=0A>=20>>=20=20=20=09= =09dst=20+=3D=20cur=20*=20mmc->read_bl_len;=0D=0A>=20>>=20+=0D=0A>=20>>=20+= =09=09WATCHDOG_RESET();=0D=0A>=20>>=20=20=20=09=7D=20while=20(blocks_todo= =20>=200);=0D=0A>=20>>=0D=0A>=20>>=20=20=20=09return=20blkcnt;=0D=0A=0D=0A= =0D=0A