From: Reinhard Meyer <r.meyer@emk-elektronik.de>
To: u-boot@lists.denx.de
Subject: [U-Boot-Users] RTC for MPC5200
Date: Thu, 15 Jan 2004 11:22:53 +0100 [thread overview]
Message-ID: <06cc01c3db51$e2f496e0$6d4ba8c0@alb.sub.de> (raw)
In-Reply-To: 20040115091811.811FFC10AF@atlas.denx.de
Dear Wolfgang,
> In message <033d01c3d6ec$decf7670$6d4ba8c0@alb.sub.de> you wrote:
> >
> > attached find mpc5200.c to support the MPC5200 RTC
> Added (as rtc/5xxx.c).
I do not understand the logic behind this filename. Are all 5xxx having this
type of RTC?
MGT5100 ? MPC5200 ? MCF5xxx (Coldfire) ??? MPC5500-Series ?
I sincerely doubt that.
So at least a filename like mpc5xxx.c would be better... Currently it
supports only the MPC5200 and nothing else
The RTC support for mpc8xx, for example, is in a file named (correctly)
mpc8xx.c
> > add mpd5200.o to the Makefile in this folder:
> No. This is not acceptable. Will you please submit a proper patch
> including all these modifications next time? Thanks.
1. these instructions were meant for Victor Wren, who had asked for MPC5200
RTC support
2. the patch for Makefile would not have worked when you rename the file
3. can a patch produce a new file in CVS? If yes, how?
Best regards
Reinhard
next prev parent reply other threads:[~2004-01-15 10:22 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-01-08 21:05 [U-Boot-Users] RTC for MPC5200 Victor Wren
2004-01-08 22:56 ` Wolfgang Denk
2004-01-09 0:23 ` Victor Wren
2004-01-09 6:46 ` Wolfgang Denk
2004-01-09 16:51 ` Reinhard Meyer
2004-01-09 20:11 ` Reinhard Meyer
2004-01-15 9:18 ` Wolfgang Denk
2004-01-15 10:22 ` Reinhard Meyer [this message]
2004-01-15 11:00 ` Wolfgang Denk
2004-01-15 12:58 ` Reinhard Meyer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='06cc01c3db51$e2f496e0$6d4ba8c0@alb.sub.de' \
--to=r.meyer@emk-elektronik.de \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox