From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 00DBFC4332F for ; Mon, 26 Dec 2022 23:55:33 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 30E1D849CD; Tue, 27 Dec 2022 00:55:31 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=samsung.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=samsung.com header.i=@samsung.com header.b="TBswY6Dt"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 4EB8082163; Tue, 27 Dec 2022 00:55:29 +0100 (CET) Received: from mailout4.samsung.com (mailout4.samsung.com [203.254.224.34]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 43386854F5 for ; Tue, 27 Dec 2022 00:55:25 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=samsung.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=jh80.chung@samsung.com Received: from epcas1p4.samsung.com (unknown [182.195.41.48]) by mailout4.samsung.com (KnoxPortal) with ESMTP id 20221226235522epoutp04c329330c65c4c068e8c9eee2bc89ec7b~0fRxM0LQK0863608636epoutp04y for ; Mon, 26 Dec 2022 23:55:22 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 mailout4.samsung.com 20221226235522epoutp04c329330c65c4c068e8c9eee2bc89ec7b~0fRxM0LQK0863608636epoutp04y DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=samsung.com; s=mail20170921; t=1672098922; bh=4OcaDkjIcFkf9BdvBLDTt3srMDgtrFRxSSCNcQV/2mg=; h=From:To:Cc:In-Reply-To:Subject:Date:References:From; b=TBswY6DtIw0xet+3XRwW/Flv/NVeX6hQrM1uzZLde4ftJwEpMc4Sm6lO3bBcpaDnF pENmjC8g9XHqfjnF4G3DJUDpFx5630gqJXYiFISTzaUpwjbJ0YElCgZeLUlCiTA2/L mIyvHZzMn7LdUx7R8VldKwpXeoiHXQVVqABq8+8w= Received: from epsnrtp1.localdomain (unknown [182.195.42.162]) by epcas1p2.samsung.com (KnoxPortal) with ESMTP id 20221226235521epcas1p2be2ed91acc4085d606236b5b50ba8274~0fRxCDQ143143131431epcas1p2c; Mon, 26 Dec 2022 23:55:21 +0000 (GMT) Received: from epsmges1p2.samsung.com (unknown [182.195.36.136]) by epsnrtp1.localdomain (Postfix) with ESMTP id 4NgvmS4MGjz4x9QC; Mon, 26 Dec 2022 23:55:20 +0000 (GMT) Received: from epcas1p2.samsung.com ( [182.195.41.46]) by epsmges1p2.samsung.com (Symantec Messaging Gateway) with SMTP id 0C.6F.38305.8643AA36; Tue, 27 Dec 2022 08:55:20 +0900 (KST) Received: from epsmtrp2.samsung.com (unknown [182.195.40.14]) by epcas1p3.samsung.com (KnoxPortal) with ESMTPA id 20221226235519epcas1p33b579183ccee63d71878319b6c8fecb3~0fRvJnaQB2841428414epcas1p3F; Mon, 26 Dec 2022 23:55:19 +0000 (GMT) Received: from epsmgms1p1new.samsung.com (unknown [182.195.42.41]) by epsmtrp2.samsung.com (KnoxPortal) with ESMTP id 20221226235519epsmtrp2b620f3a68036084e35c57c078fcd5bf7~0fRvI6ioQ2799527995epsmtrp2M; Mon, 26 Dec 2022 23:55:19 +0000 (GMT) X-AuditID: b6c32a36-46ffd700000095a1-90-63aa3468c6ac Received: from epsmtip1.samsung.com ( [182.195.34.30]) by epsmgms1p1new.samsung.com (Symantec Messaging Gateway) with SMTP id 5B.8C.02211.7643AA36; Tue, 27 Dec 2022 08:55:19 +0900 (KST) Received: from jh80chung01 (unknown [10.113.111.84]) by epsmtip1.samsung.com (KnoxPortal) with ESMTPA id 20221226235519epsmtip192803ba288c9e3979fceaa4eb8d35208~0fRu6VsWe3019830198epsmtip1_; Mon, 26 Dec 2022 23:55:19 +0000 (GMT) From: "Jaehoon Chung" To: "'Marek Vasut'" , Cc: "'Peng Fan'" In-Reply-To: <20221222051041.1276885-1-marex@denx.de> Subject: RE: [PATCH] cmd: mmc: Expand bkops handling Date: Tue, 27 Dec 2022 08:55:19 +0900 Message-ID: <06d801d91985$8296b580$87c42080$@samsung.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Mailer: Microsoft Outlook 16.0 Thread-Index: AQJGJkZq6BAU66VysFT265uNF6AlIAJ0n3rirZMYYTA= Content-Language: ko X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFvrNKsWRmVeSWpSXmKPExsWy7bCmnm6Gyapkg54d3BZv2hoZLX6s+sJq 8XZvJ7sDs8e8WSdYPM7e2cHosfHdDqYA5qhsm4zUxJTUIoXUvOT8lMy8dFsl7+B453hTMwND XUNLC3MlhbzE3FRbJRefAF23zBygTUoKZYk5pUChgMTiYiV9O5ui/NKSVIWM/OISW6XUgpSc AtMCveLE3OLSvHS9vNQSK0MDAyNToMKE7Iz+29PZCmZoVRx9sYu9gXGHYhcjJ4eEgInE1d4v zF2MXBxCAjsYJbpe7mWCcD4xSkxcfI0VpEpI4BujxJxl1TAdXRNhivYySjycfoodwnnJKNHU 8YYZpIpNQE/i/6KFYLaIgLXE9A2XwGxmAWWJA39us4PYnAKmEnf2NLOA2MJAU4+03gOrYRFQ lXj6fQojiM0rYCkxbe0PFghbUOLkzCcsEHPkJba/ncMMcZGCxM+ny1ghdllJHFm9nw2iRkRi dmcb2G8SAm/ZJXq2TQBq5gByXCRedtlD9ApLvDq+hR3ClpL4/G4vG0R9M6PE0iUHWSGcHkaJ fw3X2SCqjCX2L53MBDKIWUBTYv0ufYiwosTO33MZIRbzSbz72sMKsYtXoqNNCKJEReLS65dM MLvuPvnPOoFRaRaS12YheW0WkhdmISxbwMiyilEstaA4Nz212LDACB7byfm5mxjBqVDLbAfj pLcf9A4xMnEwHmKU4GBWEuHNvbE8WYg3JbGyKrUoP76oNCe1+BCjKTCwJzJLiSbnA5NxXkm8 oYmlgYmZkbGJhaGZoZI4b/7+RclCAumJJanZqakFqUUwfUwcnFINTCYlLbk7RRfvMtsjc9Dp gNuuG/EGp4wtW/kyNM1+zLo/IW7qrQ4BtryZHB+iAuW2LOYTDrI9tndLbwGT1xcFky4Z14mT xdiui7Sdbvvo5yC76lih/eLk21f4YuSnJ38R91TdurZBRi5If37qXWnXsg1d/kudi6+bn/rh d+nLfWFm6d+e3+LeNsz3e9WoaZedeDdZu95zj4b5mzCldPWPdt9U/2Y3lszoc31dyXpc63Hh IeHiWXvc/C9yMLr/emvOlL8g8F7X08PK3U9PBbWKS8orv84MqRN1mLTxcMJupQkca7lKsqJ6 3fdzycSvmCHJvkvuyartF9KLZs9UT/gQ9NdlDfuWKZmWmyOU3tsrsRRnJBpqMRcVJwIAh+wu wQ4EAAA= X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFnrCLMWRmVeSWpSXmKPExsWy7bCSnG66yapkgxvTDC3etDUyWvxY9YXV 4u3eTnYHZo95s06weJy9s4PRY+O7HUwBzFFcNimpOZllqUX6dglcGf23p7MVzNCqOPpiF3sD 4w7FLkZODgkBE4muiXuZuhi5OIQEdjNKHN+0jAkiISXx+elUti5GDiBbWOLw4WKImueMEivm TWEBqWET0JP4v2ghM4gtImArMf/bBrBeZgFliQN/brNDNLQxSmybtx2siFPAVOLOnmawZmGg zUda74HFWQRUJZ5+n8IIYvMKWEpMW/uDBcIWlDg58wkLyBHMQMvaNjJCzJeX2P52DjPEnQoS P58uY4W4wUriyOr9bBA1IhKzO9uYJzAKz0IyaRbCpFlIJs1C0rGAkWUVo2RqQXFuem6xYYFh Xmq5XnFibnFpXrpecn7uJkZwRGhp7mDcvuqD3iFGJg7GQ4wSHMxKIry5N5YnC/GmJFZWpRbl xxeV5qQWH2KU5mBREue90HUyXkggPbEkNTs1tSC1CCbLxMEp1cDE5C8yIZ5vsdC9LTaTBM/t 1tF4rG8d/vdnidbN7Sk+hg0dJj2+RZ8jH3nP2jtXdnHHkjd2h6/8LtY0crmqtDPvyOLbxVpT nrCctxKN2BNj4SCqfdj29ofjh9kn3xKpDysK0JpiuGSlw5LwoIJG5w3/LAruJk6+e+h7Tso5 y0bu5XWrox5936j304DBhU/v9r3yGx5bJ8VIlT792PVmv9vspI7lxbzph9dUyl7ZN5/jAp/7 qdOPfQQefKt8PtHu6Sn5wFBl5bl/lWWrrly361SbK6S1WUnPOzf15/T5Agwee09FmmW79J/+ c+R9nmQe83SHMpvMzDIt77quKf96dtXmPDtekrjt2QHZtjWsb3uUWIozEg21mIuKEwHgaArh 9wIAAA== X-CMS-MailID: 20221226235519epcas1p33b579183ccee63d71878319b6c8fecb3 X-Msg-Generator: CA Content-Type: text/plain; charset="utf-8" X-Sendblock-Type: SVC_REQ_APPROVE CMS-TYPE: 101P DLP-Filter: Pass X-CFilter-Loop: Reflected X-CMS-RootMailID: 20221222051100epcas1p3abf869f8bccb2fb68e5c8b20178e1f59 References: <20221222051041.1276885-1-marex@denx.de> X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.6 at phobos.denx.de X-Virus-Status: Clean Hi, > -----Original Message----- > From: Marek Vasut > Sent: Thursday, December 22, 2022 2:11 PM > To: u-boot@lists.denx.de > Cc: Marek Vasut ; Jaehoon Chung ; Peng Fan > Subject: [PATCH] cmd: mmc: Expand bkops handling > > Add more capable "bkops" command which allows enabling and disabling both > manual and automatic bkops. The existing 'mmc bkops-enable' subcommand is > poorly named to cover all the possibilities, hence the new-ish subcommand. > Note that both commands are wrappers around the same common code. > > Signed-off-by: Marek Vasut > --- > Cc: Jaehoon Chung > Cc: Peng Fan > --- > cmd/mmc.c | 49 +++++++++++++++++++++++++++++++++++++++-------- > drivers/mmc/mmc.c | 14 +++++++++----- > include/mmc.h | 2 +- > 3 files changed, 51 insertions(+), 14 deletions(-) > > diff --git a/cmd/mmc.c b/cmd/mmc.c > index c79d9407986..94deb9a1686 100644 > --- a/cmd/mmc.c > +++ b/cmd/mmc.c > @@ -1020,16 +1020,12 @@ static int do_mmc_setdsr(struct cmd_tbl *cmdtp, int flag, > } > > #ifdef CONFIG_CMD_BKOPS_ENABLE > -static int do_mmc_bkops_enable(struct cmd_tbl *cmdtp, int flag, > - int argc, char *const argv[]) > +static int mmc_bkops_common(char *device, bool autobkops, bool enable) > { > - int dev; > struct mmc *mmc; > + int dev; > > - if (argc != 2) > - return CMD_RET_USAGE; > - > - dev = dectoul(argv[1], NULL); > + dev = dectoul(device, NULL); > > mmc = init_mmc_device(dev, false); > if (!mmc) > @@ -1040,7 +1036,41 @@ static int do_mmc_bkops_enable(struct cmd_tbl *cmdtp, int flag, > return CMD_RET_FAILURE; > } > > - return mmc_set_bkops_enable(mmc); > + return mmc_set_bkops_enable(mmc, autobkops, enable); > +} > + > +static int do_mmc_bkops(struct cmd_tbl *cmdtp, int flag, > + int argc, char * const argv[]) > +{ > + bool autobkops, enable; > + > + if (argc != 4) > + return CMD_RET_USAGE; > + > + if (!strcmp(argv[2], "manual")) > + autobkops = false; > + else if (!strcmp(argv[2], "auto")) > + autobkops = true; > + else > + return CMD_RET_FAILURE; > + > + if (!strcmp(argv[3], "disable")) > + enable = false; AFAIK, "manual" enable is one time programmable. It can't disable again after enabled, isn't it? Best Regards, Jaehoon Chung > + else if (!strcmp(argv[3], "enable")) > + enable = true; > + else > + return CMD_RET_FAILURE; > + > + return mmc_bkops_common(argv[1], autobkops, enable); > +} > + > +static int do_mmc_bkops_enable(struct cmd_tbl *cmdtp, int flag, > + int argc, char * const argv[]) > +{ > + if (argc != 2) > + return CMD_RET_USAGE; > + > + return mmc_bkops_common(argv[1], false, true); > } > #endif > > @@ -1102,6 +1132,7 @@ static struct cmd_tbl cmd_mmc[] = { > U_BOOT_CMD_MKENT(setdsr, 2, 0, do_mmc_setdsr, "", ""), > #ifdef CONFIG_CMD_BKOPS_ENABLE > U_BOOT_CMD_MKENT(bkops-enable, 2, 0, do_mmc_bkops_enable, "", ""), > + U_BOOT_CMD_MKENT(bkops, 4, 0, do_mmc_bkops, "", ""), > #endif > }; > > @@ -1188,6 +1219,8 @@ U_BOOT_CMD( > #ifdef CONFIG_CMD_BKOPS_ENABLE > "mmc bkops-enable - enable background operations handshake on device\n" > " WARNING: This is a write-once setting.\n" > + "mmc bkops [auto|manual] [enable|disable]\n" > + " - configure background operations handshake on device\n" > #endif > ); > > diff --git a/drivers/mmc/mmc.c b/drivers/mmc/mmc.c > index 210703ea46b..afbc497b12c 100644 > --- a/drivers/mmc/mmc.c > +++ b/drivers/mmc/mmc.c > @@ -3127,9 +3127,10 @@ int mmc_init_device(int num) > #endif > > #ifdef CONFIG_CMD_BKOPS_ENABLE > -int mmc_set_bkops_enable(struct mmc *mmc) > +int mmc_set_bkops_enable(struct mmc *mmc, bool autobkops, bool enable) > { > int err; > + u32 bit = autobkops ? BIT(1) : BIT(0); > ALLOC_CACHE_ALIGN_BUFFER(u8, ext_csd, MMC_MAX_BLOCK_LEN); > > err = mmc_send_ext_csd(mmc, ext_csd); > @@ -3143,18 +3144,21 @@ int mmc_set_bkops_enable(struct mmc *mmc) > return -EMEDIUMTYPE; > } > > - if (ext_csd[EXT_CSD_BKOPS_EN] & 0x1) { > + if (enable && (ext_csd[EXT_CSD_BKOPS_EN] & bit)) { > puts("Background operations already enabled\n"); > return 0; > } > > - err = mmc_switch(mmc, EXT_CSD_CMD_SET_NORMAL, EXT_CSD_BKOPS_EN, 1); > + err = mmc_switch(mmc, EXT_CSD_CMD_SET_NORMAL, EXT_CSD_BKOPS_EN, > + enable ? bit : 0); > if (err) { > - puts("Failed to enable manual background operations\n"); > + printf("Failed to %sable manual background operations\n", > + enable ? "en" : "dis"); > return err; > } > > - puts("Enabled manual background operations\n"); > + printf("%sabled %s background operations\n", > + enable ? "En" : "Dis", autobkops ? "auto" : "manual"); > > return 0; > } > diff --git a/include/mmc.h b/include/mmc.h > index 571fa625d02..e116e78f343 100644 > --- a/include/mmc.h > +++ b/include/mmc.h > @@ -893,7 +893,7 @@ int mmc_rpmb_route_frames(struct mmc *mmc, void *req, unsigned long reqlen, > void *rsp, unsigned long rsplen); > > #ifdef CONFIG_CMD_BKOPS_ENABLE > -int mmc_set_bkops_enable(struct mmc *mmc); > +int mmc_set_bkops_enable(struct mmc *mmc, bool autobkops, bool enable); > #endif > > /** > -- > 2.35.1