From: Marek Vasut <marex@denx.de>
To: "Abbarapu, Venkatesh" <venkatesh.abbarapu@amd.com>,
"u-boot@lists.denx.de" <u-boot@lists.denx.de>
Cc: "Simek, Michal" <michal.simek@amd.com>,
"fabrice.gasnier@foss.st.com" <fabrice.gasnier@foss.st.com>,
"git (AMD-Xilinx)" <git@amd.com>
Subject: Re: [PATCH v5 1/7] usb: onboard-hub: Add reset-gpio support
Date: Mon, 7 Oct 2024 17:40:48 +0200 [thread overview]
Message-ID: <06ff501e-ebf2-402a-a058-5bbffd00f545@denx.de> (raw)
In-Reply-To: <SA1PR12MB8697CE2214E5DD0A5A764833987D2@SA1PR12MB8697.namprd12.prod.outlook.com>
On 10/7/24 5:03 PM, Abbarapu, Venkatesh wrote:
[...]
>>> static int usb_onboard_hub_probe(struct udevice *dev)
>>> {
>>> struct onboard_hub *hub = dev_get_priv(dev); @@ -30,7 +67,11 @@
>>> static int usb_onboard_hub_probe(struct udevice *dev)
>>> if (ret)
>>> dev_err(dev, "can't enable vdd-supply: %d\n", ret);
>>>
>>> - return ret;
>>> + ret = usb_onboard_hub_reset(dev);
>>
>> return usb_onboard_hub_reset(dev);
> <Venkatesh> By adding the "return usb_onboard_hub_reset(dev);" we miss the code which does i2c initialization sequence which is part of [PATCH v4 4/7] usb: onboard-hub: Add i2c initialization for usb5744 hub of the series.
Surely this can be solved in 4/7 ?
next prev parent reply other threads:[~2024-10-07 16:06 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-07 4:45 [PATCH v5 0/7] Add the USB5744 hub driver as per new DT binding Venkatesh Yadav Abbarapu
2024-10-07 4:45 ` [PATCH v5 1/7] usb: onboard-hub: Add reset-gpio support Venkatesh Yadav Abbarapu
2024-10-07 12:08 ` Marek Vasut
2024-10-07 15:03 ` Abbarapu, Venkatesh
2024-10-07 15:40 ` Marek Vasut [this message]
2024-10-07 4:45 ` [PATCH v5 2/7] usb: onboard-hub: Fix the return values of regulator APIs Venkatesh Yadav Abbarapu
2024-10-07 12:09 ` Marek Vasut
2024-10-07 4:45 ` [PATCH v5 3/7] usb: onboard-hub: add support for Microchip USB5744 Venkatesh Yadav Abbarapu
2024-10-07 12:09 ` Marek Vasut
2024-10-07 4:45 ` [PATCH v5 4/7] usb: onboard-hub: Add i2c initialization for usb5744 hub Venkatesh Yadav Abbarapu
2024-10-07 12:10 ` Marek Vasut
2024-10-07 4:45 ` [PATCH v5 5/7] usb: onboard-hub: Bail out if peer hub is already probed Venkatesh Yadav Abbarapu
2024-10-07 12:10 ` Marek Vasut
2024-10-07 4:45 ` [PATCH v5 6/7] configs: zynqmp_kria: Enable the USB onboard hub Venkatesh Yadav Abbarapu
2024-10-07 4:45 ` [PATCH v5 7/7] arm64: zynqmp: Update the usb5744 hub node as per binding Venkatesh Yadav Abbarapu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=06ff501e-ebf2-402a-a058-5bbffd00f545@denx.de \
--to=marex@denx.de \
--cc=fabrice.gasnier@foss.st.com \
--cc=git@amd.com \
--cc=michal.simek@amd.com \
--cc=u-boot@lists.denx.de \
--cc=venkatesh.abbarapu@amd.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox