From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.5 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B4042C4338F for ; Wed, 28 Jul 2021 16:23:08 +0000 (UTC) Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id CF0E861019 for ; Wed, 28 Jul 2021 16:23:07 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org CF0E861019 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=arcturusnetworks.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=lists.denx.de Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id E2E3582D1C; Wed, 28 Jul 2021 18:23:04 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=arcturusnetworks.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Received: by phobos.denx.de (Postfix, from userid 109) id 1D1B682D50; Wed, 28 Jul 2021 18:23:03 +0200 (CEST) Received: from mail.arcturusgroup.com (mx92.arcturusgroup.com [68.179.103.92]) by phobos.denx.de (Postfix) with ESMTP id 7CDCA82D1B; Wed, 28 Jul 2021 18:22:58 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=arcturusnetworks.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=oleks@arcturusnetworks.com Received: from localhost (localhost [127.0.0.1]) by mail.arcturusgroup.com (Postfix) with ESMTP id 19D527F5733; Wed, 28 Jul 2021 12:22:58 -0400 (EDT) Received: from mail.arcturusgroup.com ([127.0.0.1]) by localhost (mail.arcturusgroup.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id g649CVChWsNG; Wed, 28 Jul 2021 12:22:57 -0400 (EDT) Received: from Oleks.local (gw.arcturusgroup.net [66.11.68.6]) by mail.arcturusgroup.com (Postfix) with ESMTPSA id 4325F7F5726; Wed, 28 Jul 2021 12:22:57 -0400 (EDT) Subject: Re: U-Boot Digest, Vol 158, Issue 63 To: sjg@chromium.org, trini@konsulko.com References: From: Oleksandr G Zhadan Cc: u-boot-request@lists.denx.de, u-boot@lists.denx.de, "arcsupport@ArcturusNetworks.com" Message-ID: <0735982b-277d-9f3d-3ed3-5fc0368c2cac@arcturusnetworks.com> Date: Wed, 28 Jul 2021 12:22:57 -0400 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.12.0 MIME-Version: 1.0 In-Reply-To: Content-Language: en-US Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit X-Content-Filtered-By: Mailman/MimeDel 2.1.34 X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.34 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.2 at phobos.denx.de X-Virus-Status: Clean Hello, Please see inline. On 7/26/21 9:40 AM, u-boot-request@lists.denx.de wrote: > Message: 13 > Date: Mon, 26 Jul 2021 07:34:06 -0600 > From: Simon Glass > To: U-Boot Mailing List > Cc: Tom Rini, Simon Glass, > Albert Aribaud, Andy Fleming > , Joe Hershberger, Marek > Vasut, Mario Six, Oleksandr > Zhadan and Michael Durrant, Pavel > Herrmann, Priyanka Jain > , Rob Herring, Stefan > Roese, Stefano Babic, Wolfgang Denk > > Subject: [PATCH 00/33] pci: Drop all pre-driver model code > Message-ID:<20210726133440.634682-1-sjg@chromium.org> > > The hard work to actually enable DM_PCI everywhere was done recently. This > series attempts to drop most of the code that it no-longer needed now that > PCI has been converted to driver model. > It also drops the UCP1020 board since it has various unique build issues. What issues are we talking about?Please name it. Today's u-boot clone builds and runs fine in our module without any warnings except: > git clone https://source.denx.de/u-boot/u-boot.git u-boot-20210728 > cd u-boot-20210728 > make UCP1020_defconfig > CROSS_COMPILE=powerpc-linux- make 2>222  > cat 222 ===================== WARNING ====================== This board does not use CONFIG_DM. CONFIG_DM will be compulsory starting with the v2020.01 release. Failure to update may result in board removal. See doc/driver-model/migration.rst for more info. ==================================================== ===================== WARNING ====================== This board does not use CONFIG_DM_ETH (Driver Model for Ethernet drivers). Please update the board to use CONFIG_DM_ETH before the v2020.07 release. Failure to update by the deadline may result in board removal. See doc/driver-model/migration.rst for more info. =================================================== > It doesn't even support driver model so it seems reasonable to just remove > it. 1. Sure it's my fault that I didn't notice the warnings that CONFIG_DM is the only choice to build and run u-boot. 2. Why is CONFIG_DM still present in `make menuconfig` options? 3. We only use u-boot as the first stage bootloader to start the kernel. We need minimal device controllers support. We don't need anything like PCI, USB, etc. 4. At least you need to add doc/driver-model/migration.rst to the source tree from https://source.denx.de/u-boot/u-boot.git if you point to it in your warnings. And 5. I have seen NO reason to remove ANY support board without REAL reasons to do so. SUMMARY: 1. UCP1020_defconfig does not have any compiler warnings on build (at least 2021.07.28 clone). 2. If now the only choice is CONFIG_DM, then it should be removed as an option from "make menuconfig", and we will definitely fix the related warnings/errors. 3. IMPO board support can be removed if it breaks when built and/or breaks any other builds. Thank you, Oleks > > The DM_PCI option disappears and only PCI is left. -- Oleksandr Zhadan oleks@arcturusnetworks.com 416.621.0125 x.235 }|{/\|)/\|-|