From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id B1C1BC433F5 for ; Fri, 8 Apr 2022 13:09:52 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id F0C4C83C35; Fri, 8 Apr 2022 15:09:49 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="Ek/fyI1I"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id B912A80FF0; Fri, 8 Apr 2022 15:09:47 +0200 (CEST) Received: from mail-qv1-xf2a.google.com (mail-qv1-xf2a.google.com [IPv6:2607:f8b0:4864:20::f2a]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 17BBD80FF0 for ; Fri, 8 Apr 2022 15:09:45 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=seanga2@gmail.com Received: by mail-qv1-xf2a.google.com with SMTP id kd21so7410056qvb.6 for ; Fri, 08 Apr 2022 06:09:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=eTBTbrZf/jBpoBv+0HVuF/2w4GISUJAm0OGiuWWgJi8=; b=Ek/fyI1ItpzdVhfySUjqCA+URqRbmAzmIj76EDaMdNrj2Mkx+oRnRxqYBo9EzOXCH9 ONrhtRWxJfbUhF9vEE667ZrrLM//csnPcixW8wyx1cLYouBKgtelJKXa94jZsCP08BFp LlB8Rv7g8R1KVl6TgE4oU2Zi+8Q7IQ9F/GiWKnOr5eu+QZggg7OQPmQPn7P9LoQz1lw3 yRZRct6eNOK6v/Zycx7vnXPg0oii0YpFQUal1dc545u1jLt1hHk1Rbyw768ii1nPMMPj sA8CvBcutdyuTbr7kHRJHZ4d5izbS+wHsd/NRwgqceApNY67vsCm7ytkbo6zTEHCSJOb Q2jQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=eTBTbrZf/jBpoBv+0HVuF/2w4GISUJAm0OGiuWWgJi8=; b=bsDF872ka79cEhSDCObU0zdmjrV34wP2bBhoIAY4QgRmtISCshzieNXlv9TY9ZqSJR JOrXuhgMw6wP+nprjpRA6xyvb91jlW/nk3Dar17ShG+hXwF31s1m3PUm+2GYoQKLSTNF 8ia/wBIDNqgmvRRTeIz2Ez2Ee8p8XTTScYZcrXFS3Na8a5mj4NKLwSdseu8Y8D9KYThe hv+JDCow++Lu0J+By7RmztxJ4RMzN7FlIMTlPpgST0/earml+G+RojfVkLF9UgfDLlZH 0+Jg/xOws3u7GQlHKwlKsnZLk31VM0/7kHjhOvz71kdgycY01ciwwmrvaPRuq4bDQg8t F+Zw== X-Gm-Message-State: AOAM532cVXq0H0t7Nov5X2EAFOiuBMhd/6Pso33c52lMgkyAXhQfB0cB tsTH+Tdtf5D5pWZekZGWtaM= X-Google-Smtp-Source: ABdhPJxO0h0Pr4TB2rhNlWXAMycdY/5WGhafqW53T7QdW4BiO6Hb1o8CIPrRuGoNM4TIdO2OqYYK+Q== X-Received: by 2002:ad4:5d48:0:b0:440:ef43:3667 with SMTP id jk8-20020ad45d48000000b00440ef433667mr15872431qvb.110.1649423383668; Fri, 08 Apr 2022 06:09:43 -0700 (PDT) Received: from [192.168.1.201] (pool-108-18-137-133.washdc.fios.verizon.net. [108.18.137.133]) by smtp.googlemail.com with ESMTPSA id s15-20020a05620a29cf00b00680ca4b3755sm15015497qkp.119.2022.04.08.06.09.42 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 08 Apr 2022 06:09:43 -0700 (PDT) Subject: Re: [PATCH v2 1/2] env: setenv add resolve value option To: Tom Rini , Artem Lapkin Cc: sjg@chromium.org, marek.behun@nic.cz, narmstrong@baylibre.com, twarren@nvidia.com, andre.przywara@arm.com, u-boot@lists.denx.de, u-boot-amlogic@groups.io, christianshewitt@gmail.com, art@khadas.com, nick@khadas.com, gouwa@khadas.com References: <20211119043647.1251416-1-art@khadas.com> <20211119043647.1251416-2-art@khadas.com> <20220407180526.GA885897@bill-the-cat> From: Sean Anderson Message-ID: <075374b2-7149-455e-9e36-acd71e607197@gmail.com> Date: Fri, 8 Apr 2022 09:09:41 -0400 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.12.0 MIME-Version: 1.0 In-Reply-To: <20220407180526.GA885897@bill-the-cat> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.5 at phobos.denx.de X-Virus-Status: Clean On 4/7/22 2:05 PM, Tom Rini wrote: > On Fri, Nov 19, 2021 at 12:36:46PM +0800, Artem Lapkin wrote: >> Add possibility setup env variable with additional resolving vars inside > >> value. >> >> Usage examples: >> >> => setenv a hello; setenv b world; setenv c '${a} ${b}' >> => setenv -r d '${c}! ${a}...' >> => printenv d >> d=hello world! hello... >> >> /* internal usage example */ >> env_resolve("d", "${c}! ${a}..."); >> /* d="hello world! hello..." */ >> >> Signed-off-by: Artem Lapkin >> Reviewed-by: Simon Glass > > This break building on a number of platforms such as am335x_evm. > Should this even be applied in the first place? I agree with Wolfgang's objections. This should be done by the shell (if anything). --Sean