Re: [PATCH v3 1/2] imx8mm-evk: Generate a single bootable flash.bin again

[Marcel Ziswiler <marcel.ziswiler@toradex.com>]

Hi Fabio

On Mon, 2021-08-23 at 08:27 -0300, Fabio Estevam wrote:
> Hi Heiko Thiery and Marcel,
> 
> On 19/08/2021 16:28, Fabio Estevam wrote:
> 
> > diff --git a/arch/arm/dts/imx8mm-evk-u-boot.dtsi
> > b/arch/arm/dts/imx8mm-evk-u-boot.dtsi
> > index f200afac9f..75cd59e545 100644
> > --- a/arch/arm/dts/imx8mm-evk-u-boot.dtsi
> > +++ b/arch/arm/dts/imx8mm-evk-u-boot.dtsi
> > @@ -150,7 +150,7 @@
> >         };
> > 
> > 
> > -       flash {
> > +       spl {
> >                 mkimage {
> >                         args = "-n spl/u-boot-spl.cfgout -T imx8mimage -e 0x7e1000";
> > 
> > @@ -217,4 +217,19 @@
> >                         };
> >                 };
> >         };
> > +
> > +       imx-boot {
> > +               filename = "flash.bin";
> > +               pad-byte = <0x00>;
> > +
> > +               spl: blob-ext@1 {
> > +                       offset = <0x0>;
> > +                       filename = "spl.bin";
> > +               };
> > +
> > +               uboot: blob-ext@2 {
> > +                       offset = <0x57c00>;
> > +                       filename = "u-boot.itb";
> > +               };
> > +       };
> >  };
> 
> Do we have a consensus on the binman format to generate a monolithic 
> flash.bin?

Yes, I would say so. Remember, I did include this already in our latest verdin-imx8mm specific patch set
together with its migration to using binman [1].

> I understand that patch 2/2 still needs to be improved, but what about 
> this one?

Yes, I agree.

Reviewed-by: Marcel Ziswiler <marcel.ziswiler@toradex.com>

[1] https://marc.info/?l=u-boot&m=162949278629882

> Thanks,
> 
> Fabio Estevam

Cheers

Marcel