U-Boot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Marek Vasut <marex@nabladev.com>
To: Fabio Estevam <festevam@gmail.com>
Cc: u-boot@lists.denx.de, "NXP i.MX U-Boot Team" <uboot-imx@nxp.com>,
	Adam Ford <aford173@gmail.com>, Alexander Koch <akoch@initse.com>,
	Peng Fan <peng.fan@nxp.com>, Simon Glass <sjg@chromium.org>,
	Tom Rini <trini@konsulko.com>
Subject: Re: [PATCH v2 1/3] binman: imx8mimage: Handle nxp,boot-from = "fspi"
Date: Fri, 29 May 2026 12:53:29 +0200	[thread overview]
Message-ID: <0777b89b-86af-4f4a-ade0-d2ffc66bfa4e@nabladev.com> (raw)
In-Reply-To: <CAOMZO5DN7DD5rNAbL0WxVoCHxqikjS9aVdg1q-SVXxEhOLrQCg@mail.gmail.com>

On 5/28/26 2:43 PM, Fabio Estevam wrote:
> Hi Marek,
> 
> On Mon, May 25, 2026 at 8:52 PM Marek Vasut <marex@nabladev.com> wrote:
>>
>> Boot from FSPI requires additional 448 Byte long header, with U-Boot SPL
>> starting at offset 0x1000. Currently, both i.MX8MM and i.MX8MN attempt
>> to generate this header using fspi_conf_block with filename pointing at
>> CONFIG_FSPI_CONF_FILE file. This does not work, for two reasons.
>>
>> First, the CONFIG_FSPI_CONF_FILE is generated by mkimage -T imx8mimage
>> and may not be available yet when the fspi_conf_block is evaluated. That
>> leads to a race condition where highly parallel builds fail to find the
>> CONFIG_FSPI_CONF_FILE, which is usually called fspi_header.bin, on first
>> build attempt.
>>
>> Second, binman gets confused and patches incorrect offset of DDR PHY
>> firmware blobs into U-Boot SPL, the offset is incremented by exactly
>> 0x1000 which is the size of fspi_conf_block.
>>
>> Fix both problems at once, make imx8mimage handle the generated FSPI
>> header and prepend it in front of the imx8mimage processed data. This
>> way, the race condition is solved, because the data generated by the
>> imx8mimage are surely combined only after mkimage -T imx8mimage ran.
>> The binman offset calculation is also solved, because there is no
>> fspi_conf_block node in the DT anymore.
>>
>> Signed-off-by: Marek Vasut <marex@nabladev.com>
> 
> Is this series 2026.07 material, or can it wait until 2026.10?
> 
> Alexander, if possible, please test this series and reply with your
> Tested-by tag.
This should have been 2024.07 material, but I had no hardware to debug 
this on, so 2026.07 will do.

  reply	other threads:[~2026-05-29 10:53 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-05-25 23:51 [PATCH v2 1/3] binman: imx8mimage: Handle nxp,boot-from = "fspi" Marek Vasut
2026-05-25 23:51 ` [PATCH v2 2/3] arm64: dts: imx8mm: Generate FSPI header using binman imx8mimage Marek Vasut
2026-06-03 16:45   ` Simon Glass
2026-05-25 23:51 ` [PATCH v2 3/3] arm64: dts: imx8mn: " Marek Vasut
2026-06-03 16:45   ` Simon Glass
2026-05-28 12:43 ` [PATCH v2 1/3] binman: imx8mimage: Handle nxp,boot-from = "fspi" Fabio Estevam
2026-05-29 10:53   ` Marek Vasut [this message]
2026-05-29 22:03 ` Simon Glass
2026-05-30 17:12   ` Marek Vasut

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=0777b89b-86af-4f4a-ade0-d2ffc66bfa4e@nabladev.com \
    --to=marex@nabladev.com \
    --cc=aford173@gmail.com \
    --cc=akoch@initse.com \
    --cc=festevam@gmail.com \
    --cc=peng.fan@nxp.com \
    --cc=sjg@chromium.org \
    --cc=trini@konsulko.com \
    --cc=u-boot@lists.denx.de \
    --cc=uboot-imx@nxp.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox