From: Neil Armstrong <narmstrong@baylibre.com>
To: Artem Lapkin <email2tema@gmail.com>
Cc: u-boot@lists.denx.de, u-boot-amlogic@groups.io,
khilman@baylibre.com, christianshewitt@gmail.com,
martin.blumenstingl@googlemail.com, art@khadas.com,
nick@khadas.com, gouwa@khadas.com
Subject: Re: [PATCH] dts: khadas vim series: Use devicetree for SMBIOS settings
Date: Mon, 26 Jul 2021 09:37:04 +0200 [thread overview]
Message-ID: <080543bf-e2ed-5706-70ed-1bd1dbd4fa96@baylibre.com> (raw)
In-Reply-To: <20210715050026.2940786-1-art@khadas.com>
Hi,
Subject should be: "[PATCH] ARM: dts: meson: Use devicetree for SMBIOS settings for Khadas VIM boards"
with that:
Reviewed-by: Neil Armstrong <narmstrong@baylibre.com>
On 15/07/2021 07:00, Artem Lapkin wrote:
> Khadas vim series: Use devicetree for SMBIOS settings
> Add settings and enable the default sysinfo driver so that these can come
> from the device tree.
>
> Signed-off-by: Artem Lapkin <art@khadas.com>
> ---
> .../meson-g12b-a311d-khadas-vim3-u-boot.dtsi | 23 +++++++++++++++++++
> .../meson-gxl-s905x-khadas-vim-u-boot.dtsi | 23 +++++++++++++++++++
> .../arm/dts/meson-gxm-khadas-vim2-u-boot.dtsi | 21 +++++++++++++++++
> .../dts/meson-sm1-khadas-vim3l-u-boot.dtsi | 23 +++++++++++++++++++
> 4 files changed, 90 insertions(+)
>
> diff --git a/arch/arm/dts/meson-g12b-a311d-khadas-vim3-u-boot.dtsi b/arch/arm/dts/meson-g12b-a311d-khadas-vim3-u-boot.dtsi
> index 489efa15..fcd6f053 100644
> --- a/arch/arm/dts/meson-g12b-a311d-khadas-vim3-u-boot.dtsi
> +++ b/arch/arm/dts/meson-g12b-a311d-khadas-vim3-u-boot.dtsi
> @@ -6,3 +6,26 @@
>
> #include "meson-g12-common-u-boot.dtsi"
> #include "meson-khadas-vim3-u-boot.dtsi"
> +
> +/ {
> + smbios {
> + compatible = "u-boot,sysinfo-smbios";
> +
> + smbios {
> + system {
> + manufacturer = "khadas";
> + product = "VIM3";
> + };
> +
> + baseboard {
> + manufacturer = "khadas";
> + product = "VIM3";
> + };
> +
> + chassis {
> + manufacturer = "khadas";
> + product = "VIM3";
> + };
> + };
> + };
> +};
> diff --git a/arch/arm/dts/meson-gxl-s905x-khadas-vim-u-boot.dtsi b/arch/arm/dts/meson-gxl-s905x-khadas-vim-u-boot.dtsi
> index 39270ea7..20e36d1b 100644
> --- a/arch/arm/dts/meson-gxl-s905x-khadas-vim-u-boot.dtsi
> +++ b/arch/arm/dts/meson-gxl-s905x-khadas-vim-u-boot.dtsi
> @@ -5,3 +5,26 @@
> */
>
> #include "meson-gxl-u-boot.dtsi"
> +
> +/ {
> + smbios {
> + compatible = "u-boot,sysinfo-smbios";
> +
> + smbios {
> + system {
> + manufacturer = "khadas";
> + product = "VIM";
> + };
> +
> + baseboard {
> + manufacturer = "khadas";
> + product = "VIM";
> + };
> +
> + chassis {
> + manufacturer = "khadas";
> + product = "VIM";
> + };
> + };
> + };
> +};
> diff --git a/arch/arm/dts/meson-gxm-khadas-vim2-u-boot.dtsi b/arch/arm/dts/meson-gxm-khadas-vim2-u-boot.dtsi
> index c1763336..41480c9a 100644
> --- a/arch/arm/dts/meson-gxm-khadas-vim2-u-boot.dtsi
> +++ b/arch/arm/dts/meson-gxm-khadas-vim2-u-boot.dtsi
> @@ -10,6 +10,27 @@
> aliases {
> spi0 = &spifc;
> };
> +
> + smbios {
> + compatible = "u-boot,sysinfo-smbios";
> +
> + smbios {
> + system {
> + manufacturer = "khadas";
> + product = "VIM2";
> + };
> +
> + baseboard {
> + manufacturer = "khadas";
> + product = "VIM2";
> + };
> +
> + chassis {
> + manufacturer = "khadas";
> + product = "VIM2";
> + };
> + };
> + };
> };
>
> &sd_emmc_c {
> diff --git a/arch/arm/dts/meson-sm1-khadas-vim3l-u-boot.dtsi b/arch/arm/dts/meson-sm1-khadas-vim3l-u-boot.dtsi
> index a591c0c9..06b81f23 100644
> --- a/arch/arm/dts/meson-sm1-khadas-vim3l-u-boot.dtsi
> +++ b/arch/arm/dts/meson-sm1-khadas-vim3l-u-boot.dtsi
> @@ -6,3 +6,26 @@
>
> #include "meson-sm1-u-boot.dtsi"
> #include "meson-khadas-vim3-u-boot.dtsi"
> +
> +/ {
> + smbios {
> + compatible = "u-boot,sysinfo-smbios";
> +
> + smbios {
> + system {
> + manufacturer = "khadas";
> + product = "VIM3L";
> + };
> +
> + baseboard {
> + manufacturer = "khadas";
> + product = "VIM3L";
> + };
> +
> + chassis {
> + manufacturer = "khadas";
> + product = "VIM3L";
> + };
> + };
> + };
> +};
>
next prev parent reply other threads:[~2021-07-26 7:37 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-15 5:00 [PATCH] dts: khadas vim series: Use devicetree for SMBIOS settings Artem Lapkin
2021-07-15 5:00 ` [PATCH] configs: khadas-vim*: Enable SMBIOS Artem Lapkin
2021-07-26 7:37 ` Neil Armstrong
2021-07-27 1:28 ` Art Nikpal
2021-07-26 7:37 ` Neil Armstrong [this message]
2021-07-27 1:28 ` [PATCH] dts: khadas vim series: Use devicetree for SMBIOS settings Art Nikpal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=080543bf-e2ed-5706-70ed-1bd1dbd4fa96@baylibre.com \
--to=narmstrong@baylibre.com \
--cc=art@khadas.com \
--cc=christianshewitt@gmail.com \
--cc=email2tema@gmail.com \
--cc=gouwa@khadas.com \
--cc=khilman@baylibre.com \
--cc=martin.blumenstingl@googlemail.com \
--cc=nick@khadas.com \
--cc=u-boot-amlogic@groups.io \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox