Re: [PATCH 3/6] arm: mvebu: Use CONFIG_TIMER on all MVEBU & KIRKWOOD platforms

Stefan Roese
2022-08-30T12:11:31Z

On 30.08.22 14:04, Michael Walle wrote:
> Am 2022-08-30 13:53, schrieb Stefan Roese:
>> Now that the new timer support is available for these platforms, let's
>> select this IF for all these platforms. This way it's not necessary
>> that each board changes it's config header.
>>
>> Signed-off-by: Stefan Roese <sr@denx.de>
>> ---
>>  arch/arm/Kconfig                          | 4 ++++
>>  arch/arm/mach-mvebu/include/mach/config.h | 5 -----
>>  2 files changed, 4 insertions(+), 5 deletions(-)
>>
>> diff --git a/arch/arm/Kconfig b/arch/arm/Kconfig
>> index 0b72e4f6503e..60f524a2d118 100644
>> --- a/arch/arm/Kconfig
>> +++ b/arch/arm/Kconfig
>> @@ -618,6 +618,7 @@ config ARCH_KIRKWOOD
>>      select BOARD_EARLY_INIT_F
>>      select CPU_ARM926EJS
>>      select GPIO_EXTRA_HEADER
>> +    select TIMER
>
> If selected by the arch now (and the timer driver defaulting to
> y on this arch), could you clean the lschvl2 and lsxhl_defconfigs up
> and remove the two symbols there?

Sure. I can add another patch for this in the next patchset version.
Please complain, if I forget to do this. ;)

Thanks,
Stefan

>>
>>  config ARCH_MVEBU
>>      bool "Marvell MVEBU family (Armada XP/375/38x/3700/7K/8K)"
>> @@ -629,6 +630,8 @@ config ARCH_MVEBU
>>      select GPIO_EXTRA_HEADER
>>      select SPL_DM_SPI if SPL
>>      select SPL_DM_SPI_FLASH if SPL
>> +    select SPL_TIMER if SPL
>> +    select TIMER
>>      select OF_CONTROL
>>      select OF_SEPARATE
>>      select SPI
>> @@ -639,6 +642,7 @@ config ARCH_ORION5X
>>      select CPU_ARM926EJS
>>      select GPIO_EXTRA_HEADER
>>      select SPL_SEPARATE_BSS if SPL
>> +    select TIMER
>>
>>  config TARGET_STV0991
>>      bool "Support stv0991"
>> diff --git a/arch/arm/mach-mvebu/include/mach/config.h
>> b/arch/arm/mach-mvebu/include/mach/config.h
>> index 4add0d9e1030..9b5036c31dd3 100644
>> --- a/arch/arm/mach-mvebu/include/mach/config.h
>> +++ b/arch/arm/mach-mvebu/include/mach/config.h
>> @@ -41,9 +41,4 @@
>>  #endif
>>  #endif
>>
>> -/* Use common timer */
>> -#define CONFIG_SYS_TIMER_COUNTS_DOWN
>> -#define CONFIG_SYS_TIMER_COUNTER    (MVEBU_TIMER_BASE + 0x14)
>> -#define CONFIG_SYS_TIMER_RATE        25000000
>> -
>>  #endif /* __MVEBU_CONFIG_H */

Viele Grüße,
Stefan Roese

--
DENX Software Engineering GmbH, Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-51 Fax: (+49)-8142-66989-80 Email: sr@denx.de