From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 4CB51C46467 for ; Wed, 11 Jan 2023 08:17:47 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 32E8A856D6; Wed, 11 Jan 2023 09:17:45 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=quarantine dis=none) header.from=amd.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=amd.com header.i=@amd.com header.b="qD6uPqak"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 2B367856DD; Wed, 11 Jan 2023 09:17:43 +0100 (CET) Received: from NAM02-DM3-obe.outbound.protection.outlook.com (mail-dm3nam02on2085.outbound.protection.outlook.com [40.107.95.85]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 9604E856C9 for ; Wed, 11 Jan 2023 09:17:40 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=quarantine dis=none) header.from=amd.com Authentication-Results: phobos.denx.de; spf=fail smtp.mailfrom=michal.simek@amd.com ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=fnf7Q10lF27bD6Vm8OrvJ13QQgWu0brqCKr7PstXO/qjXUgL0DdRAx8DVWZvoF2EMaozHIYZXp8DsDM8JWspg1+fhIXfU4PqkQ+mXZps/KD9QjopjwEPuu+j7f1PRgz8XBrEICQ02UQx6yzOnoDJdTzmTfGhZZGET7xi4D7aZGE3qOXrzjbK6Msn95/Q4XCcfz92IfQhUYScL3u2YM+3F5q8rsy/4djOHhdtX/2fWft0eNNNp/CcTbvAnNOMBBGQTZ2cDW+LnPZjhy1frn/eq6zGJNVnabUQcE9azmKtzjZyy1p6reO+WZuMpdMEADtLNb7X7YtBIXKJlaLgQnw4Cw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=6A88myDnwTnFIi4ZX+69lWOuTAKlu90ods7MHSxtEvU=; b=UIaPCmFJOMdX05MGKVIaUZ2gUgDYmlHZ4zB2bx6NKp89nGidPfEx0UEwzo5H2Us3GXtwS2nPCei6UGg8bQrFOeJsJbIPMDckdzQ48eocmu47MmEinm1Wv60WQKU7LAdDfI+KpnRLI1wjCM+HzTxtco3rXJx6pPah/xrw7fzt4bq/myuw4OPc152Fomv9NgxBZA0RVvO1s7vQSB7UMrsZaMzaa1WnDGkQVU5bilpN7BvkUO1ZkzVqq3pQrS+fWqMPFqZnGJ6VIMyNCnSsGDzV9Z/u0jnpJ6wpBD1WOYmUPA2x7elFA6DlexFrtX8FmDz90Gherzu0497eAsfJvJbHuA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=konsulko.com smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=6A88myDnwTnFIi4ZX+69lWOuTAKlu90ods7MHSxtEvU=; b=qD6uPqakcbl825rGiq4cTgRJ9By3TnbD8Qf1Zi+PpaWcoO9mYIJ71PfhpuhUcrXLfv+DjBr5Mh8eIsprhEpqzLFAP4kbKvFkhttbJfAy/4Qf8w8Tijd6OASYAjPdZpnXRwNuLQuEyuaZQ8QR+L7nHL76xNv20nBZegrfoKi6pxk= Received: from BN8PR15CA0001.namprd15.prod.outlook.com (2603:10b6:408:c0::14) by DM4PR12MB6183.namprd12.prod.outlook.com (2603:10b6:8:a7::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5986.18; Wed, 11 Jan 2023 08:17:37 +0000 Received: from BN8NAM11FT070.eop-nam11.prod.protection.outlook.com (2603:10b6:408:c0:cafe::fb) by BN8PR15CA0001.outlook.office365.com (2603:10b6:408:c0::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6002.13 via Frontend Transport; Wed, 11 Jan 2023 08:17:37 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB04.amd.com; pr=C Received: from SATLEXMB04.amd.com (165.204.84.17) by BN8NAM11FT070.mail.protection.outlook.com (10.13.177.50) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.6002.13 via Frontend Transport; Wed, 11 Jan 2023 08:17:37 +0000 Received: from [10.254.241.50] (10.180.168.240) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.34; Wed, 11 Jan 2023 02:17:34 -0600 Message-ID: <09faffe9-3e1d-0831-4130-2f49ea8b4111@amd.com> Date: Wed, 11 Jan 2023 09:17:25 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.6.1 Subject: Re: [PATCH 10/19] fpga: Migrate CONFIG_MAX_FPGA_DEVICES to Kconfig Content-Language: en-US To: Tom Rini , References: <20230110161946.3816866-1-trini@konsulko.com> <20230110161946.3816866-10-trini@konsulko.com> From: Michal Simek In-Reply-To: <20230110161946.3816866-10-trini@konsulko.com> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [10.180.168.240] X-ClientProxiedBy: SATLEXMB03.amd.com (10.181.40.144) To SATLEXMB04.amd.com (10.181.40.145) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BN8NAM11FT070:EE_|DM4PR12MB6183:EE_ X-MS-Office365-Filtering-Correlation-Id: 8c94d063-2b5e-4e76-a8d6-08daf3ac4ca6 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: CxN8QcyElfdi5hjEGJiPR1GJPhk2C9CaHKk6FvsoPjwfi3/LDIXYkaxfCB8nOy50irbiM8kEYYyX1fa1W40IFuR6ZEpkkR71e+KmGvJDaYLkzudftbr8SWHyF/Jp5wZi+XRk3NzLZQ2TDupOGjD7ezADX2JjYUjQRQDwwdnwX9zqOKO/dPRuiGsEy9sjJChzwBomqT8V7e1nFoifz2YZ+MW03mkl/txa4qiv7RUCzGzk8e3j2N5P2RJJYBgBbIN6xvFpPm7odYPn/UCucEPOgwdZ4j1qWxE7LhQzneOchjXBAT0oYjcync5jsn0gjm64ewyKxIVxm+NSRBlAagV0Pn75/PahTw2Rc828vpqmOWWeaUk91QvqYwV5yOhTo3M4ZUsYe3uq2LtDxPSV+9v2EfmtH/oZVOUj1tCBK4BTzHWrRzZMxPCSrTA1QW0J+aW2xNK5faUucEFtdnPnOcLyCIvVOq4z5VVmrSrh7o2AdKKS16F328RSsGa3Pd5hKKoM8r3/W5jpI/rcogG7aRAoraZU2PLoqDux69i2lD/MzWZ8tTp+rdj+YWzg/f2TCxldWT/UKOS74BvUls65jnp6MPZ+U2rWDPULvRN8K/bOR5fGDczqo5wBY+8nLiqTD/7RxWPfXFDZ2E8KDq8QAgbRG5uyYDGlcOwFuJvIetFisNpiZ/Z8b3qW5TwbPkUMwyx5dg0tiNalj+MNqLFtrKc1dU8QhUL0MmAuhSQh8dHr2WI9gjV0KnTTML4nzHVbRHMspVi4Pxe74djtSxo+/mAwXw== X-Forefront-Antispam-Report: CIP:165.204.84.17; CTRY:US; LANG:en; SCL:1; SRV:; IPV:CAL; SFV:NSPM; H:SATLEXMB04.amd.com; PTR:InfoDomainNonexistent; CAT:NONE; SFS:(13230022)(4636009)(136003)(39860400002)(396003)(376002)(346002)(451199015)(36840700001)(46966006)(40470700004)(53546011)(2906002)(478600001)(16526019)(26005)(186003)(6666004)(31686004)(70206006)(2616005)(336012)(70586007)(426003)(36756003)(40480700001)(8676002)(316002)(16576012)(47076005)(40460700003)(41300700001)(110136005)(82310400005)(5660300002)(44832011)(82740400003)(83380400001)(8936002)(36860700001)(86362001)(31696002)(81166007)(356005)(43740500002)(36900700001); DIR:OUT; SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Jan 2023 08:17:37.1949 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 8c94d063-2b5e-4e76-a8d6-08daf3ac4ca6 X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d; Ip=[165.204.84.17]; Helo=[SATLEXMB04.amd.com] X-MS-Exchange-CrossTenant-AuthSource: BN8NAM11FT070.eop-nam11.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR12MB6183 X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.6 at phobos.denx.de X-Virus-Status: Clean On 1/10/23 17:19, Tom Rini wrote: > This is always defined to 5, so use that as the default. > > Cc: Michal Simek > Signed-off-by: Tom Rini > --- > drivers/fpga/Kconfig | 5 +++++ > drivers/fpga/fpga.c | 5 ----- > include/fpga.h | 4 ---- > 3 files changed, 5 insertions(+), 9 deletions(-) > > diff --git a/drivers/fpga/Kconfig b/drivers/fpga/Kconfig > index 11b742eeebfe..4113de230cd9 100644 > --- a/drivers/fpga/Kconfig > +++ b/drivers/fpga/Kconfig > @@ -153,4 +153,9 @@ config SANDBOX_FPGA > This is a driver model based FPGA driver for sandbox. > Currently it is a stub only, as there are no usable uclass methods yet. > > +config MAX_FPGA_DEVICES > + int "Maximum number of FPGA devices" > + depends on FPGA > + default 5 > + > endmenu > diff --git a/drivers/fpga/fpga.c b/drivers/fpga/fpga.c > index 4db5c0a91e98..7f6b6bc73a1f 100644 > --- a/drivers/fpga/fpga.c > +++ b/drivers/fpga/fpga.c > @@ -13,11 +13,6 @@ > #include > #include > > -/* Local definitions */ > -#ifndef CONFIG_MAX_FPGA_DEVICES > -#define CONFIG_MAX_FPGA_DEVICES 5 > -#endif > - > /* Local static data */ > static int next_desc = FPGA_INVALID_DEVICE; > static fpga_desc desc_table[CONFIG_MAX_FPGA_DEVICES]; > diff --git a/include/fpga.h b/include/fpga.h > index a4e16401da72..ed688cc0fa3b 100644 > --- a/include/fpga.h > +++ b/include/fpga.h > @@ -9,10 +9,6 @@ > #ifndef _FPGA_H_ > #define _FPGA_H_ > > -#ifndef CONFIG_MAX_FPGA_DEVICES > -#define CONFIG_MAX_FPGA_DEVICES 5 > -#endif > - > /* fpga_xxxx function return value definitions */ > #define FPGA_SUCCESS 0 > #define FPGA_FAIL 1 Reviewed-by: Michal Simek Thanks, Michal