From mboxrd@z Thu Jan 1 00:00:00 1970 From: Michal Simek Date: Sun, 5 Aug 2007 18:34:59 +0200 Subject: [U-Boot-Users] Microblaze: PULL request References: <000b01c7d765$de175bd0$0500a8c0@monstrone> <09ef01c7d773$283ff700$0500a8c0@monstrone> Message-ID: <0a6b01c7d77e$905d8e50$0500a8c0@monstrone> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Grant, >> I thought please pull these changes to u-boot testing branch not to >> mainline. > > Even patches pulled into testing need to be reviewed. Wolfgang does > merge testing into mainline periodically after all. > >> > I don't think I've seen any of these changes posted on the list for >> > review. They need to be reviewed before being merged into mainline. >> > Especially considering that some of the changes touch common code (not >> > just microblaze). >> >> These files were send in ROMFS patch 23.June 07 >> >> common/cmd_jffs2.c | 52 ++++-- >> >> fs/Makefile | 2 +- >> >> fs/romfs/Makefile | 49 +++++ >> >> fs/romfs/romfs.c | 270 ++++++++++++++++++++++++++ > > Heh, I even posted on that thread. :) Okay, I went back and took a > look at this patch. Mostly looks good, but I had a few comments. > Take a read through and let me know what you think. I know. > >> >> New files for supporting EMAC and EMACLITE interface. Old support files >> are >> in repository too. >> I want to remove xilinx large files from U-Boot source tree. Emac driver >> use >> PPC405 core too (ml300 board). >> I tested it for Microblaze CPU and you can test it for PPC405 and give me >> a >> respond. > > These patches I'm especially interested in. I would like to review > them before they are committed. I know many developers needs these driver. For Microblaze I created configuration file. You can download it at www.monstr.eu Emac is supported without DMA support. I plan to add support for simple and scatter gather DMA too. I will wait for your review. >> We were talking about at the end of March. >> >> Makefile | 9 +- >> >> drivers/net/Makefile | 45 +++++ >> >> drivers/net/xilinx_emac.c | 372 >> >> ++++++++++++++++++++++++++++++++++++ >> >> drivers/net/xilinx_emac.h | 128 +++++++++++++ >> >> drivers/net/xilinx_emaclite.c | 378 >> >> +++++++++++++++++++++++++++++++++++++ >> >> Little name changes - because xuartlite serial interface isn't only one >> which can be use with Microblaze CPU. >> I think that can be helpful for PPC405 embedded core too that can use >> uartlite serial interface. >> >> drivers/serial_xuartlite.c | 2 +- > > Fair enough, but you should still post. > >> cmd_mfsl consist of only Microblaze dependent commands. >> >> common/cmd_mfsl.c | 11 +- > > ditto > >> >> Microblaze dependent files >> >> cpu/microblaze/cache.c | 2 +- >> >> cpu/microblaze/start.S | 6 +- >> >> cpu/microblaze/timer.c | 7 + >> >> lib_microblaze/time.c | 8 + >> >> board/xilinx/xupv2p/Makefile | 21 +-- >> >> board/xilinx/xupv2p/config.mk | 6 +- >> >> board/xilinx/xupv2p/xparameters.h | 27 ++-- >> >> include/configs/ml401.h | 1 + >> >> include/configs/suzaku.h | 3 + >> >> include/configs/xupv2p.h | 58 +++++- > > Again, this stuff should hit the list before merging. If there are no > comments, then as microblaze custodian, you have discretion to add > them to the microblaze tree and get them merged, but they should still > hit the list *first* in case there are comments. OK. I will be good guy. If you want I will send all changes to mailing list. Microblaze changes are really cosmetic. Michal Simek