From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.5 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DB270C2B9F4 for ; Sat, 19 Jun 2021 19:33:43 +0000 (UTC) Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 8E27360E08 for ; Sat, 19 Jun 2021 19:33:42 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 8E27360E08 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 8A63C80F47; Sat, 19 Jun 2021 21:33:39 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="PeeSJ8kh"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 452A880F47; Sat, 19 Jun 2021 21:33:37 +0200 (CEST) Received: from mail-ed1-x536.google.com (mail-ed1-x536.google.com [IPv6:2a00:1450:4864:20::536]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 3C6C481FD5 for ; Sat, 19 Jun 2021 21:33:33 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=ivo.g.dimitrov.75@gmail.com Received: by mail-ed1-x536.google.com with SMTP id z12so13311698edc.1 for ; Sat, 19 Jun 2021 12:33:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=TWxOSePMDJsTDgMHV2BHNKIzmUcKy+eQdmC5jUUlyCg=; b=PeeSJ8khn0fby7hexFndLs/OVzVAd8ixTXgVFnUetI9jfFGUhJYI0ho1P+2DBefQd6 oguy+91Mtb382VvBy7FDSOjESoB547SWaEVl9PQ+vKjdO8VAkHpEQ1pr0AaYYDVh4zla nOw1jkAeq0GYjFTZFeJ6oetdPg+ZPHMdb5eY/de+vBaWIRvML8VHIldN9KYlb1UQiv8H 7+/ge18hou5cxCjeZ/GnLoK0tRe/gfP0ePSTCjJME3ZU9rRaPzMcYKmJOD6C6fwUnidh mm88G/NFNrHzlnmFdtdTiWaIU7kQS9kKr5pB4DYtHwYGDDDSxmMOW+eo/Q/SA1WzeKlS irVA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=TWxOSePMDJsTDgMHV2BHNKIzmUcKy+eQdmC5jUUlyCg=; b=CVPC9vqt9TYRth0P5GCMC7B7NK+hz6J/C7UEEDFXKY9DJpIhlTNdmEXAsrmrAP2/lf 4/N4zvvoclC0ZPwmAWcpioLWJJ8tcnWe5cpMYGu7D41R7J5WHqfa4mPZ2vBSTQnLaudJ wQvG0EZng2DyGHcfjB017K7DZgtv93CkSVBFcBdgi6XljxhaQTKMjc2Mie+ciMb/Ts+N ygSJMyYidNnTA6ASWrBQPBpY24LiA1LQ1lmCshYv+4vEcoZzQlsUCMV/XhsBEeqbPMk5 qlye6LPpaO12H64VdEroAXCZLwm+HuVcRQ3o2VvLmBnygVxypJTchq0BnJQxasiowFjD y73A== X-Gm-Message-State: AOAM533U4QPc1+kVs/KiVvok4/lBLsjRtLz6SbGeVLFniAwLwSElcXFh KZaI7lmSXAw+GYyiAsqPzKs= X-Google-Smtp-Source: ABdhPJxrWqHgvM3EmE1Wt430Htc5W/lKFau0likBWiCVcCOYmRgc5HWvskhnO97iKirscv6y9iog8A== X-Received: by 2002:a05:6402:1103:: with SMTP id u3mr12229154edv.342.1624131212866; Sat, 19 Jun 2021 12:33:32 -0700 (PDT) Received: from [192.168.1.10] ([46.249.74.23]) by smtp.googlemail.com with ESMTPSA id n2sm8277659edi.32.2021.06.19.12.33.31 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Sat, 19 Jun 2021 12:33:32 -0700 (PDT) Subject: Re: [PATCH 1/2] DM_USB: allow building without OF_CONTROL To: Marek Vasut Cc: Tom Rini , =?UTF-8?Q?Pali_Roh=c3=a1r?= , Lokesh Vutla , Simon Glass , Merlijn Wajer , maemo-leste@lists.dyne.org, u-boot@lists.denx.de, Pavel Machek References: <20210618145724.2558-1-pali@kernel.org> <20210618163812.GR9516@bill-the-cat> <3c44a3cf-b9ad-1b31-d0a4-54c896222d78@gmail.com> From: Ivaylo Dimitrov Message-ID: <0a8a9dab-ee44-fab7-d712-d66cb121c170@gmail.com> Date: Sat, 19 Jun 2021 22:33:23 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Firefox/60.0 Thunderbird/60.6.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-GB Content-Transfer-Encoding: 8bit X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.34 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.2 at phobos.denx.de X-Virus-Status: Clean Hi, On 19.06.21 г. 21:17 ч., Marek Vasut wrote: > On 6/19/21 8:14 AM, Ivaylo Dimitrov wrote: >> Hi Marek, > > Hi, > > [...] > >>>>> Currently DM_USB requires OF_CONTROL to be enabled, otherwise link >>>>> errors >>>>> occur. On the other hand OF_CONTROL requires board code to be >>>>> migrated to >>>>> DT, which is not always possible or required. >>>>> >>>>> Fix that by conditionally compiling OF_CONTROL specific sections in >>>>> USB >>>>> related drivers code in the same way like it is done in the other >>>>> drivers. >>>>> Also, auto select OF_LIBFDT if DM_USB is selected but OF_CONTROL is >>>>> not. >>>>> Introduce a new Kconfig option OF_NODE used to compile of_node.c in >>>>> case >>>>> OF_CONTROL is not enabled. Fix deprecation warning condition as well. >>> >>> So, what is the use case of this? Why not just enable DM_USB and >>> OF_CONTROL ? >> >> OF_CONTROL requires migration to device-tree. > > That's where the supported platforms are heading anyway. Or is there > some issue with switching the platform you use over to DT ? OK, let me elaborate: It is about enabling DM_USB on N900 (Nokia rx-51 board). For various reasons I am not going to discuss (1), migration to DM was delayed to the point where we saw "[PATCH] arm: Remove nokia_rx51 board" with a commit message "This board has not been converted to CONFIG_DM_USB by the deadline. Remove it." posted. The missing pieces were WDT (a patch is already merged in -next) and DM_USB. The board itself does not support host mode, but USB TTY is very useful for debugging purposes. The particular task I am after is USB DM migration and the $subject patch allows this to be achieved with relatively little effort (a couple of defconfig changes), incomparable with the effort needed for migration to DT. As we are already past the DM migration deadline I think it makes sense to fulfil its requirements before undertaking such a big task like migration to DT. Regards, Ivo (1) https://www.mail-archive.com/u-boot@lists.denx.de/msg409064.html