From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 802F5C3DA7D for ; Tue, 3 Jan 2023 16:04:07 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id E067F854AE; Tue, 3 Jan 2023 17:04:04 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=denx.de Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=denx.de; s=phobos-20191101; t=1672761845; bh=sYAw83gZuqxs7g9wjXmsngjJN/A6FCGwfdcQ6JOWLnQ=; h=Date:Subject:To:Cc:References:From:In-Reply-To:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=iOsRP4aWi7p79Zs1bNKhDUh/SIwThdRfupwzBXlocQKzSgyRPhEOWmSpEmeaWnrMp oD16aShiP4QJNjNJMflMVqe++Wggs4qTjrXNRcjCgTlGYdL6RQo7RLZ7IyKGC2UKJ6 OcHtxug/jKzyPBEcUOpGLtOEeVmdGm1BYTRQV6nM/ULl9wRMTj+Ks98t47LQqEfn6B QlZr+ZOVqlgrub5EwXh0Hc0N8lJJPgQcUXryjXIqpGgAXkdfYqT0n8HRAw0domYsD1 LuFmi+SC/S0QSegdUmsTiqMiKijFWp/+cJRbnH7vW525QJz6KWEEFpQnXIIwDz25IK dNVQO6boZJr8w== Received: from [127.0.0.1] (p578adb1c.dip0.t-ipconnect.de [87.138.219.28]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) (Authenticated sender: marex@denx.de) by phobos.denx.de (Postfix) with ESMTPSA id 4E9F1853BF; Tue, 3 Jan 2023 17:04:01 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=denx.de; s=phobos-20191101; t=1672761841; bh=sYAw83gZuqxs7g9wjXmsngjJN/A6FCGwfdcQ6JOWLnQ=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=xwvRhN7nQSXWN0lLYMCGJcInob88rAcFf/nQT090VnTwJU1CT2pU6X9RCw1HTNZp5 xE5UPloaoU0yJOjRvu3PpXPr3P2iyz3dk5fmciYmi9iUeb5D+WjAxqm8frNOrsJwWk LTE0U9o7OdoP0QolCC0Pf6xKtLTXOCPg1aWrPVPsALlFZYis2tUzlyhGWBT63AzXw9 U5FsGgJ/h+XddoCK+h/TrnSpSkdRTCUsYykfKLh2TyijO5BX1GXy+NjZ89g4L39UHx rZuy1c+z50o/wuoyapazRKCiAJ6sHt47qmNBsVEAT0U6cb7TFZnpHH7If8nv7iB7ZW RnSKu/gNq/VBg== Message-ID: <0b00a463-304f-1606-0826-e1de4f77767d@denx.de> Date: Tue, 3 Jan 2023 17:04:00 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.6.0 Subject: Re: [PATCH 2/4] usb: ohci-at91: Enable OHCI functionality and register into DM Content-Language: en-US To: Sergiu.Moga@microchip.com, michal.simek@amd.com, jim.t90615@gmail.com, sumit.garg@linaro.org, weijie.gao@mediatek.com, sjg@chromium.org, Eugen.Hristev@microchip.com, Cristian.Birsan@microchip.com Cc: u-boot@lists.denx.de References: <20221223123454.362757-1-sergiu.moga@microchip.com> <20221223123454.362757-3-sergiu.moga@microchip.com> <83364386-7f6f-af67-7108-4d04fcd096d9@denx.de> <0c5b3222-4df4-eea1-8568-5cd6ccea3962@denx.de> <36beada3-02ff-f33f-dc4e-517ccbc8cdf3@denx.de> <566c908f-faad-716b-1534-eb7c8f43c52e@microchip.com> From: Marek Vasut In-Reply-To: <566c908f-faad-716b-1534-eb7c8f43c52e@microchip.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.6 at phobos.denx.de X-Virus-Status: Clean On 1/3/23 17:01, Sergiu.Moga@microchip.com wrote: > On 03.01.2023 17:57, Marek Vasut wrote: >> On 1/3/23 16:49, Sergiu.Moga@microchip.com wrote: >>> On 03.01.2023 16:34, Marek Vasut wrote: >>>> On 1/3/23 13:11, Sergiu.Moga@microchip.com wrote: >>>>> On 03.01.2023 01:26, Marek Vasut wrote: >>>>>> On 12/23/22 13:34, Sergiu Moga wrote: >>>>>> >>>>>> [...] >>>>>> >>>>>>> diff --git a/drivers/usb/host/ohci-at91.c >>>>>>> b/drivers/usb/host/ohci-at91.c >>>>>>> index 9b955c1bd6..9ae55c6e5d 100644 >>>>>>> --- a/drivers/usb/host/ohci-at91.c >>>>>>> +++ b/drivers/usb/host/ohci-at91.c >>>>>>> @@ -5,6 +5,9 @@ >>>>>>>      */ >>>>>>> >>>>>>>     #include >>>>>>> + >>>>>>> +#if !(CONFIG_IS_ENABLED(DM_USB)) >>>>>>> + >>>>>>>     #include >>>>>>> >>>>>>>     int usb_cpu_init(void) >>>>>>> @@ -62,3 +65,183 @@ int usb_cpu_init_fail(void) >>>>>>>     { >>>>>>>         return usb_cpu_stop(); >>>>>>>     } >>>>>> >>>>>> Would it be possible to just remove the non-DM functionality ? >>>>>> >>>>> >>>>> Unfortunately, the other older boards would not build and work anymore >>>>> if I were to remove this. >>>> >>>> Any chance they can be converted to DM ? >>>> >>> >>> Not at the moment, no. >> >> Why ? > > My apologies, but I do not have these boards at my disposal to test them > and they are not the focus of this patch series. The reason I kept the > non-DM part is that so the build on the other boards does not break. > Perhaps in the future there will be plans to convert these as well but > at the moment I can not say for sure. No need to apologize. Can you add a comment into the commit message, explaining this ?