[PATCH] fs/erofs: Remove an unnecessary assertion

[PATCH] fs/erofs: Remove an unnecessary assertion

[Yifan Zhao]

In [1] Sam points out an assertion does not hold true for 32-bit
platforms, which only impacts Large File Support (LFS) API usage
in erofs-utils according to Xiang [2]. We don't think these APIs
are used in u-boot and this restriction could be safely removed.

[1] https://lists.denx.de/pipermail/u-boot/2023-July/524679.html
[2] https://lists.denx.de/pipermail/u-boot/2023-July/524727.html

Fixes: 3a21e92fc255 ("fs/erofs: Introduce new features including ztailpacking, fragments and dedupe")
Signed-off-by: Yifan Zhao <zhaoyifan@sjtu.edu.cn>
---
 fs/erofs/internal.h | 3 ---
 1 file changed, 3 deletions(-)

diff --git a/fs/erofs/internal.h b/fs/erofs/internal.h
index 433a3c6c1e..1875f37fcd 100644
--- a/fs/erofs/internal.h
+++ b/fs/erofs/internal.h
@@ -105,9 +105,6 @@ struct erofs_sb_info {
 	u8 xattr_prefix_count;
 };
 
-/* make sure that any user of the erofs headers has at least 64bit off_t type */
-extern int erofs_assert_largefile[sizeof(off_t) - 8];
-
 static inline erofs_off_t iloc(erofs_nid_t nid)
 {
 	return erofs_pos(sbi.meta_blkaddr) + (nid << sbi.islotbits);
-- 
2.41.0

Re: [PATCH] fs/erofs: Remove an unnecessary assertion

[Gao Xiang]

On 2023/7/26 12:56, Yifan Zhao wrote:
> In [1] Sam points out an assertion does not hold true for 32-bit
> platforms, which only impacts Large File Support (LFS) API usage
> in erofs-utils according to Xiang [2]. We don't think these APIs
> are used in u-boot and this restriction could be safely removed.
> 
> [1] https://lists.denx.de/pipermail/u-boot/2023-July/524679.html
> [2] https://lists.denx.de/pipermail/u-boot/2023-July/524727.html
> 
> Fixes: 3a21e92fc255 ("fs/erofs: Introduce new features including ztailpacking, fragments and dedupe")
> Signed-off-by: Yifan Zhao <zhaoyifan@sjtu.edu.cn>
Acked-by: Gao Xiang <hsingkao@linux.alibaba.com>

Thanks,
Gao Xiang

Re: [PATCH] fs/erofs: Remove an unnecessary assertion

[Sam Edwards]

Thanks greatly for the speedy turnaround on this patch!

On 7/25/23 22:56, Yifan Zhao wrote:
> Fixes: 3a21e92fc255 ("fs/erofs: Introduce new features including ztailpacking, fragments and dedupe")
> Signed-off-by: Yifan Zhao <zhaoyifan@sjtu.edu.cn>
Tested-by: Sam Edwards <CFSworks@gmail.com>

Re: [PATCH] fs/erofs: Remove an unnecessary assertion

[Tom Rini]

[-- Attachment #1: Type: text/plain, Size: 733 bytes --]

On Wed, Jul 26, 2023 at 12:56:04PM +0800, Yifan Zhao wrote:

> In [1] Sam points out an assertion does not hold true for 32-bit
> platforms, which only impacts Large File Support (LFS) API usage
> in erofs-utils according to Xiang [2]. We don't think these APIs
> are used in u-boot and this restriction could be safely removed.
> 
> [1] https://lists.denx.de/pipermail/u-boot/2023-July/524679.html
> [2] https://lists.denx.de/pipermail/u-boot/2023-July/524727.html
> 
> Fixes: 3a21e92fc255 ("fs/erofs: Introduce new features including ztailpacking, fragments and dedupe")
> Signed-off-by: Yifan Zhao <zhaoyifan@sjtu.edu.cn>
> Tested-by: Sam Edwards <CFSworks@gmail.com>

Applied to u-boot/master, thanks!

-- 
Tom

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 659 bytes --]