From: Sean Anderson <sean.anderson@linux.dev>
To: David Lechner <dlechner@baylibre.com>,
Rayagonda Kokatanur <rayagonda.kokatanur@broadcom.com>,
Tom Rini <trini@konsulko.com>,
Sughosh Ganu <sughosh.ganu@linaro.org>,
Ilias Apalodimas <ilias.apalodimas@linaro.org>
Cc: Julien Stephan <jstephan@baylibre.com>, u-boot@lists.denx.de
Subject: Re: [PATCH] scripts/Makefile.autoconf: use abs_srctree for out-of-tree symlink
Date: Tue, 6 Jan 2026 15:39:48 -0500 [thread overview]
Message-ID: <0d0bd91a-506d-4bc9-ae84-364cb98b2b71@linux.dev> (raw)
In-Reply-To: <20260105-mtk-fix-build-after-kconfig-change-v1-1-7185a081f7c0@baylibre.com>
On 1/5/26 15:35, David Lechner wrote:
> Replace usage of $(srctree) with $(abs_srctree) when creating a symlink
> to include/asm/arch in out of tree builds.
>
> When building_out_of_srctree is true, $(srctree) is just "..", so the
> created symlink was broken, for example:
>
> build-mt8365_evk/include/asm/arch -> ../arch/arm/include/asm/arch-mediatek
>
> Which would resolve to a non-existent path:
>
> build-mt8365_evk/include/asm/arch/arm/include/asm/arch-mediatek
>
> To fix, we need to use the absolute path to the source tree since we
> don't know where the build tree is located relative to the source tree.
>
> Fixes: bd3f9ee679b4 ("kbuild: Bump the build system to 6.1")
> Signed-off-by: David Lechner <dlechner@baylibre.com>
> ---
> scripts/Makefile.autoconf | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/scripts/Makefile.autoconf b/scripts/Makefile.autoconf
> index e3c88badb52..47c49a018bf 100644
> --- a/scripts/Makefile.autoconf
> +++ b/scripts/Makefile.autoconf
> @@ -138,7 +138,7 @@ ifdef building_out_of_srctree
> else \
> dest=arch/$(ARCH)/include/asm/arch-$(if $(SOC),$(SOC),$(CPU)); \
> fi; \
> - ln -fsn $(srctree)/$$dest include/asm/arch
> + ln -fsn $(abs_srctree)/$$dest include/asm/arch
> else
> $(Q)if [ -d arch/$(ARCH)/mach-$(SOC)/include/mach ]; then \
> dest=../../mach-$(SOC)/include/mach; \
>
> ---
> base-commit: 6cdd7597a2fbfc1572c1b0af23d3daf1cefa2de7
> change-id: 20260105-mtk-fix-build-after-kconfig-change-922538479a96
>
> Best regards,
Tested-by: Sean Anderson <sean.anderson@linux.dev>
next prev parent reply other threads:[~2026-01-06 20:39 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-01-05 20:35 [PATCH] scripts/Makefile.autoconf: use abs_srctree for out-of-tree symlink David Lechner
2026-01-06 20:39 ` Sean Anderson [this message]
2026-01-06 23:17 ` Tom Rini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0d0bd91a-506d-4bc9-ae84-364cb98b2b71@linux.dev \
--to=sean.anderson@linux.dev \
--cc=dlechner@baylibre.com \
--cc=ilias.apalodimas@linaro.org \
--cc=jstephan@baylibre.com \
--cc=rayagonda.kokatanur@broadcom.com \
--cc=sughosh.ganu@linaro.org \
--cc=trini@konsulko.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox