* [PATCH] scripts/Makefile.autoconf: use abs_srctree for out-of-tree symlink
@ 2026-01-05 20:35 David Lechner
2026-01-06 20:39 ` Sean Anderson
2026-01-06 23:17 ` Tom Rini
0 siblings, 2 replies; 3+ messages in thread
From: David Lechner @ 2026-01-05 20:35 UTC (permalink / raw)
To: Rayagonda Kokatanur, Tom Rini, Sughosh Ganu, Ilias Apalodimas
Cc: Julien Stephan, u-boot, David Lechner
Replace usage of $(srctree) with $(abs_srctree) when creating a symlink
to include/asm/arch in out of tree builds.
When building_out_of_srctree is true, $(srctree) is just "..", so the
created symlink was broken, for example:
build-mt8365_evk/include/asm/arch -> ../arch/arm/include/asm/arch-mediatek
Which would resolve to a non-existent path:
build-mt8365_evk/include/asm/arch/arm/include/asm/arch-mediatek
To fix, we need to use the absolute path to the source tree since we
don't know where the build tree is located relative to the source tree.
Fixes: bd3f9ee679b4 ("kbuild: Bump the build system to 6.1")
Signed-off-by: David Lechner <dlechner@baylibre.com>
---
scripts/Makefile.autoconf | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/scripts/Makefile.autoconf b/scripts/Makefile.autoconf
index e3c88badb52..47c49a018bf 100644
--- a/scripts/Makefile.autoconf
+++ b/scripts/Makefile.autoconf
@@ -138,7 +138,7 @@ ifdef building_out_of_srctree
else \
dest=arch/$(ARCH)/include/asm/arch-$(if $(SOC),$(SOC),$(CPU)); \
fi; \
- ln -fsn $(srctree)/$$dest include/asm/arch
+ ln -fsn $(abs_srctree)/$$dest include/asm/arch
else
$(Q)if [ -d arch/$(ARCH)/mach-$(SOC)/include/mach ]; then \
dest=../../mach-$(SOC)/include/mach; \
---
base-commit: 6cdd7597a2fbfc1572c1b0af23d3daf1cefa2de7
change-id: 20260105-mtk-fix-build-after-kconfig-change-922538479a96
Best regards,
--
David Lechner <dlechner@baylibre.com>
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] scripts/Makefile.autoconf: use abs_srctree for out-of-tree symlink
2026-01-05 20:35 [PATCH] scripts/Makefile.autoconf: use abs_srctree for out-of-tree symlink David Lechner
@ 2026-01-06 20:39 ` Sean Anderson
2026-01-06 23:17 ` Tom Rini
1 sibling, 0 replies; 3+ messages in thread
From: Sean Anderson @ 2026-01-06 20:39 UTC (permalink / raw)
To: David Lechner, Rayagonda Kokatanur, Tom Rini, Sughosh Ganu,
Ilias Apalodimas
Cc: Julien Stephan, u-boot
On 1/5/26 15:35, David Lechner wrote:
> Replace usage of $(srctree) with $(abs_srctree) when creating a symlink
> to include/asm/arch in out of tree builds.
>
> When building_out_of_srctree is true, $(srctree) is just "..", so the
> created symlink was broken, for example:
>
> build-mt8365_evk/include/asm/arch -> ../arch/arm/include/asm/arch-mediatek
>
> Which would resolve to a non-existent path:
>
> build-mt8365_evk/include/asm/arch/arm/include/asm/arch-mediatek
>
> To fix, we need to use the absolute path to the source tree since we
> don't know where the build tree is located relative to the source tree.
>
> Fixes: bd3f9ee679b4 ("kbuild: Bump the build system to 6.1")
> Signed-off-by: David Lechner <dlechner@baylibre.com>
> ---
> scripts/Makefile.autoconf | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/scripts/Makefile.autoconf b/scripts/Makefile.autoconf
> index e3c88badb52..47c49a018bf 100644
> --- a/scripts/Makefile.autoconf
> +++ b/scripts/Makefile.autoconf
> @@ -138,7 +138,7 @@ ifdef building_out_of_srctree
> else \
> dest=arch/$(ARCH)/include/asm/arch-$(if $(SOC),$(SOC),$(CPU)); \
> fi; \
> - ln -fsn $(srctree)/$$dest include/asm/arch
> + ln -fsn $(abs_srctree)/$$dest include/asm/arch
> else
> $(Q)if [ -d arch/$(ARCH)/mach-$(SOC)/include/mach ]; then \
> dest=../../mach-$(SOC)/include/mach; \
>
> ---
> base-commit: 6cdd7597a2fbfc1572c1b0af23d3daf1cefa2de7
> change-id: 20260105-mtk-fix-build-after-kconfig-change-922538479a96
>
> Best regards,
Tested-by: Sean Anderson <sean.anderson@linux.dev>
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] scripts/Makefile.autoconf: use abs_srctree for out-of-tree symlink
2026-01-05 20:35 [PATCH] scripts/Makefile.autoconf: use abs_srctree for out-of-tree symlink David Lechner
2026-01-06 20:39 ` Sean Anderson
@ 2026-01-06 23:17 ` Tom Rini
1 sibling, 0 replies; 3+ messages in thread
From: Tom Rini @ 2026-01-06 23:17 UTC (permalink / raw)
To: Rayagonda Kokatanur, Sughosh Ganu, Ilias Apalodimas,
David Lechner
Cc: Julien Stephan, u-boot
On Mon, 05 Jan 2026 14:35:04 -0600, David Lechner wrote:
> Replace usage of $(srctree) with $(abs_srctree) when creating a symlink
> to include/asm/arch in out of tree builds.
>
> When building_out_of_srctree is true, $(srctree) is just "..", so the
> created symlink was broken, for example:
>
> build-mt8365_evk/include/asm/arch -> ../arch/arm/include/asm/arch-mediatek
>
> [...]
Applied to u-boot/master, thanks!
[1/1] scripts/Makefile.autoconf: use abs_srctree for out-of-tree symlink
commit: 726d11289f2776098b6fcd99b413b590782a556d
--
Tom
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2026-01-06 23:17 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-01-05 20:35 [PATCH] scripts/Makefile.autoconf: use abs_srctree for out-of-tree symlink David Lechner
2026-01-06 20:39 ` Sean Anderson
2026-01-06 23:17 ` Tom Rini
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox